MaxGekk closed pull request #45359: [SPARK-46961][SS] Using ProcessorContext to
store and retrieve handle
URL: https://github.com/apache/spark/pull/45359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
MaxGekk commented on PR #45359:
URL: https://github.com/apache/spark/pull/45359#issuecomment-1977192138
All GAs passed.
+1, LGTM. Merging to master.
Thank you, @ericm-db and @anishshri-db for review.
--
This is an automated message from the Apache Git Service.
To respond to the
MaxGekk commented on code in PR #45359:
URL: https://github.com/apache/spark/pull/45359#discussion_r1511578822
##
sql/api/src/main/scala/org/apache/spark/sql/errors/ExecutionErrors.scala:
##
@@ -53,6 +53,12 @@ private[sql] trait ExecutionErrors extends
DataTypeErrorsBase {
ericm-db commented on code in PR #45359:
URL: https://github.com/apache/spark/pull/45359#discussion_r1511477968
##
sql/api/src/main/scala/org/apache/spark/sql/errors/ExecutionErrors.scala:
##
@@ -53,6 +53,12 @@ private[sql] trait ExecutionErrors extends
DataTypeErrorsBase {
MaxGekk commented on code in PR #45359:
URL: https://github.com/apache/spark/pull/45359#discussion_r1511001426
##
sql/api/src/main/scala/org/apache/spark/sql/errors/ExecutionErrors.scala:
##
@@ -53,6 +53,12 @@ private[sql] trait ExecutionErrors extends
DataTypeErrorsBase {
ericm-db commented on code in PR #45359:
URL: https://github.com/apache/spark/pull/45359#discussion_r1510692025
##
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateSuite.scala:
##
@@ -195,6 +179,20 @@ class TransformWithStateSuite extends
MaxGekk commented on code in PR #45359:
URL: https://github.com/apache/spark/pull/45359#discussion_r1510018920
##
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateSuite.scala:
##
@@ -195,6 +179,20 @@ class TransformWithStateSuite extends
ericm-db commented on PR #45359:
URL: https://github.com/apache/spark/pull/45359#issuecomment-1973745035
cc @HeartSaVioR @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
anishshri-db commented on code in PR #45359:
URL: https://github.com/apache/spark/pull/45359#discussion_r1509393780
##
common/utils/src/main/resources/error/error-classes.json:
##
@@ -3320,6 +3320,13 @@
],
"sqlState" : "42802"
},
+
anishshri-db commented on code in PR #45359:
URL: https://github.com/apache/spark/pull/45359#discussion_r1509389021
##
sql/api/src/main/scala/org/apache/spark/sql/errors/ExecutionErrors.scala:
##
@@ -53,6 +53,12 @@ private[sql] trait ExecutionErrors extends
DataTypeErrorsBase
anishshri-db commented on code in PR #45359:
URL: https://github.com/apache/spark/pull/45359#discussion_r1509389021
##
sql/api/src/main/scala/org/apache/spark/sql/errors/ExecutionErrors.scala:
##
@@ -53,6 +53,12 @@ private[sql] trait ExecutionErrors extends
DataTypeErrorsBase
ericm-db opened a new pull request, #45359:
URL: https://github.com/apache/spark/pull/45359
### What changes were proposed in this pull request?
Setting the processorHandle as a part of the statefulProcessor, so that the
user doesn't have to explicitly keep track of it, and
ericm-db closed pull request #45002: [SPARK-46961][SS] Using ProcessorContext
to store and retrieve handle
URL: https://github.com/apache/spark/pull/45002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ericm-db commented on code in PR #45002:
URL: https://github.com/apache/spark/pull/45002#discussion_r1482110798
##
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateSuite.scala:
##
@@ -31,14 +31,9 @@ object TransformWithStateSuiteUtils {
class
anishshri-db commented on code in PR #45002:
URL: https://github.com/apache/spark/pull/45002#discussion_r1481977985
##
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateSuite.scala:
##
@@ -31,14 +31,9 @@ object TransformWithStateSuiteUtils {
class
anishshri-db commented on code in PR #45002:
URL: https://github.com/apache/spark/pull/45002#discussion_r1481976306
##
sql/api/src/main/scala/org/apache/spark/sql/streaming/StatefulProcessor.scala:
##
@@ -27,19 +27,16 @@ import org.apache.spark.annotation.{Evolving,
ericm-db commented on code in PR #45002:
URL: https://github.com/apache/spark/pull/45002#discussion_r1481973732
##
sql/api/src/main/scala/org/apache/spark/sql/streaming/StatefulProcessor.scala:
##
@@ -27,19 +27,16 @@ import org.apache.spark.annotation.{Evolving, Experimental}
anishshri-db commented on code in PR #45002:
URL: https://github.com/apache/spark/pull/45002#discussion_r1481971683
##
sql/api/src/main/scala/org/apache/spark/sql/streaming/StatefulProcessor.scala:
##
@@ -60,4 +57,21 @@ private[sql] trait StatefulProcessor[K, I, O] extends
anishshri-db commented on code in PR #45002:
URL: https://github.com/apache/spark/pull/45002#discussion_r1481972279
##
sql/api/src/main/scala/org/apache/spark/sql/streaming/StatefulProcessor.scala:
##
@@ -60,4 +57,21 @@ private[sql] trait StatefulProcessor[K, I, O] extends
anishshri-db commented on code in PR #45002:
URL: https://github.com/apache/spark/pull/45002#discussion_r1481970354
##
sql/api/src/main/scala/org/apache/spark/sql/streaming/StatefulProcessor.scala:
##
@@ -60,4 +57,21 @@ private[sql] trait StatefulProcessor[K, I, O] extends
anishshri-db commented on code in PR #45002:
URL: https://github.com/apache/spark/pull/45002#discussion_r1481970354
##
sql/api/src/main/scala/org/apache/spark/sql/streaming/StatefulProcessor.scala:
##
@@ -60,4 +57,21 @@ private[sql] trait StatefulProcessor[K, I, O] extends
anishshri-db commented on code in PR #45002:
URL: https://github.com/apache/spark/pull/45002#discussion_r1481969778
##
sql/api/src/main/scala/org/apache/spark/sql/streaming/StatefulProcessor.scala:
##
@@ -27,19 +27,16 @@ import org.apache.spark.annotation.{Evolving,
22 matches
Mail list logo