Re: [PR] [SPARK-47044] Add executed query for JDBC external datasources to explain output [spark]

2024-02-19 Thread via GitHub
urosstan-db commented on PR #45102: URL: https://github.com/apache/spark/pull/45102#issuecomment-1952678599 > is there any security concern? do we need to do redaction? There should not be any concern if we don't save query result anywhere? Spark UI will also create UI for plan on u

Re: [PR] [SPARK-47044] Add executed query for JDBC external datasources to explain output [spark]

2024-02-19 Thread via GitHub
urosstan-db commented on code in PR #45102: URL: https://github.com/apache/spark/pull/45102#discussion_r1494692948 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcSQLQueryBuilder.scala: ## @@ -81,17 +81,21 @@ class JdbcSQLQueryBuilder(dialect: JdbcDialect, options: JDB

Re: [PR] [SPARK-47044] Add executed query for JDBC external datasources to explain output [spark]

2024-02-19 Thread via GitHub
cloud-fan commented on PR #45102: URL: https://github.com/apache/spark/pull/45102#issuecomment-1952643638 is there any security concern? do we need to do redaction? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] [SPARK-47044] Add executed query for JDBC external datasources to explain output [spark]

2024-02-19 Thread via GitHub
cloud-fan commented on code in PR #45102: URL: https://github.com/apache/spark/pull/45102#discussion_r1494684198 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcSQLQueryBuilder.scala: ## @@ -81,17 +81,21 @@ class JdbcSQLQueryBuilder(dialect: JdbcDialect, options: JDBCO

Re: [PR] [SPARK-47044] Add executed query for JDBC external datasources to explain output [spark]

2024-02-19 Thread via GitHub
urosstan-db commented on code in PR #45102: URL: https://github.com/apache/spark/pull/45102#discussion_r1494338113 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcSQLQueryBuilder.scala: ## @@ -81,17 +81,20 @@ class JdbcSQLQueryBuilder(dialect: JdbcDialect, options: JDB

Re: [PR] [SPARK-47044] Add executed query for JDBC external datasources to explain output [spark]

2024-02-14 Thread via GitHub
dtenedor commented on code in PR #45102: URL: https://github.com/apache/spark/pull/45102#discussion_r1490403653 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcSQLQueryBuilder.scala: ## @@ -81,17 +81,20 @@ class JdbcSQLQueryBuilder(dialect: JdbcDialect, options: JDBCOp