Re: [PR] [SPARK-47070] Fix invalid aggregation after subquery rewrite [spark]

2024-03-01 Thread via GitHub
anton5798 commented on PR #45133: URL: https://github.com/apache/spark/pull/45133#issuecomment-1973897479 @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [SPARK-47070] Fix invalid aggregation after subquery rewrite [spark]

2024-03-01 Thread via GitHub
jchen5 commented on code in PR #45133: URL: https://github.com/apache/spark/pull/45133#discussion_r1509535334 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala: ## @@ -248,24 +248,72 @@ object RewritePredicateSubquery extends Rule[LogicalPlan]

Re: [PR] [SPARK-47070] Fix invalid aggregation after subquery rewrite [spark]

2024-03-01 Thread via GitHub
jchen5 commented on code in PR #45133: URL: https://github.com/apache/spark/pull/45133#discussion_r1509535334 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala: ## @@ -248,24 +248,72 @@ object RewritePredicateSubquery extends Rule[LogicalPlan]

Re: [PR] [SPARK-47070] Fix invalid aggregation after subquery rewrite [spark]

2024-03-01 Thread via GitHub
anton5798 commented on code in PR #45133: URL: https://github.com/apache/spark/pull/45133#discussion_r1509548922 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala: ## @@ -248,24 +248,72 @@ object RewritePredicateSubquery extends Rule[LogicalPl

Re: [PR] [SPARK-47070] Fix invalid aggregation after subquery rewrite [spark]

2024-03-03 Thread via GitHub
cloud-fan commented on PR #45133: URL: https://github.com/apache/spark/pull/45133#issuecomment-1975747191 > Semantically, we should wrap in any_value(), but any_value() throws RuntimeReplaceableAggregate.aggBufferAttributes should not be called and is not fully supported It's because

Re: [PR] [SPARK-47070] Fix invalid aggregation after subquery rewrite [spark]

2024-03-03 Thread via GitHub
anton5798 commented on PR #45133: URL: https://github.com/apache/spark/pull/45133#issuecomment-1975792360 @cloud-fan updated the code & pr desc! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] [SPARK-47070] Fix invalid aggregation after subquery rewrite [spark]

2024-03-04 Thread via GitHub
cloud-fan commented on code in PR #45133: URL: https://github.com/apache/spark/pull/45133#discussion_r1510764662 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala: ## @@ -248,24 +248,76 @@ object RewritePredicateSubquery extends Rule[LogicalPl

Re: [PR] [SPARK-47070] Fix invalid aggregation after subquery rewrite [spark]

2024-03-04 Thread via GitHub
cloud-fan commented on code in PR #45133: URL: https://github.com/apache/spark/pull/45133#discussion_r1510765933 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala: ## @@ -248,24 +248,76 @@ object RewritePredicateSubquery extends Rule[LogicalPl

Re: [PR] [SPARK-47070] Fix invalid aggregation after subquery rewrite [spark]

2024-03-04 Thread via GitHub
anton5798 commented on code in PR #45133: URL: https://github.com/apache/spark/pull/45133#discussion_r1510784699 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala: ## @@ -248,24 +248,76 @@ object RewritePredicateSubquery extends Rule[LogicalPl

Re: [PR] [SPARK-47070] Fix invalid aggregation after subquery rewrite [spark]

2024-03-04 Thread via GitHub
anton5798 commented on code in PR #45133: URL: https://github.com/apache/spark/pull/45133#discussion_r1510790734 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala: ## @@ -248,24 +248,76 @@ object RewritePredicateSubquery extends Rule[LogicalPl

Re: [PR] [SPARK-47070] Fix invalid aggregation after subquery rewrite [spark]

2024-03-04 Thread via GitHub
anton5798 commented on code in PR #45133: URL: https://github.com/apache/spark/pull/45133#discussion_r1510902398 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala: ## @@ -248,24 +248,76 @@ object RewritePredicateSubquery extends Rule[LogicalPl

Re: [PR] [SPARK-47070] Fix invalid aggregation after subquery rewrite [spark]

2024-03-04 Thread via GitHub
cloud-fan commented on PR #45133: URL: https://github.com/apache/spark/pull/45133#issuecomment-1976762374 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [SPARK-47070] Fix invalid aggregation after subquery rewrite [spark]

2024-03-04 Thread via GitHub
cloud-fan closed pull request #45133: [SPARK-47070] Fix invalid aggregation after subquery rewrite URL: https://github.com/apache/spark/pull/45133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the