dongjoon-hyun commented on PR #45201:
URL: https://github.com/apache/spark/pull/45201#issuecomment-2103839853
It's supposed to be here as a last resort until we release Apache Spark
4.0.0 successfully without reverting Hive 2.3.10, @pan3793 .
--
This is an automated message from the
pan3793 commented on PR #45201:
URL: https://github.com/apache/spark/pull/45201#issuecomment-2103713964
@dongjoon-hyun Jackson 1.x can be removed after SPARK-47018 (bump Hive
2.3.10), what should we do for `hive-jackson-provided`?
--
This is an automated message from the Apache Git
dongjoon-hyun commented on PR #45201:
URL: https://github.com/apache/spark/pull/45201#issuecomment-1958122180
Thank you, @xinrong-meng .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
xinrong-meng commented on PR #45201:
URL: https://github.com/apache/spark/pull/45201#issuecomment-1958118726
Makes sense, thank you @dongjoon-hyun !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dongjoon-hyun closed pull request #45201: [SPARK-47119][BUILD] Add
`hive-jackson-provided` profile
URL: https://github.com/apache/spark/pull/45201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dongjoon-hyun commented on PR #45201:
URL: https://github.com/apache/spark/pull/45201#issuecomment-1957867204
Merged to master for Apache Spark 4.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dongjoon-hyun commented on PR #45201:
URL: https://github.com/apache/spark/pull/45201#issuecomment-1957769401
Thank you, @viirya !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dongjoon-hyun commented on code in PR #45201:
URL: https://github.com/apache/spark/pull/45201#discussion_r1498189758
##
assembly/pom.xml:
##
@@ -266,6 +266,13 @@
hive-provided
provided
+provided
Review Comment:
Yes!
--
This is an
viirya commented on code in PR #45201:
URL: https://github.com/apache/spark/pull/45201#discussion_r1498189241
##
assembly/pom.xml:
##
@@ -266,6 +266,13 @@
hive-provided
provided
+provided
Review Comment:
The name `hive-jackson-provided` makes
viirya commented on code in PR #45201:
URL: https://github.com/apache/spark/pull/45201#discussion_r1498188651
##
assembly/pom.xml:
##
@@ -266,6 +266,13 @@
hive-provided
provided
+provided
Review Comment:
Oh, `hive-jackson-provided` has hive
dongjoon-hyun commented on PR #45201:
URL: https://github.com/apache/spark/pull/45201#issuecomment-1957761126
To @xinrong-meng and @viirya , I updated the PR description. You can see
that Hive jars are there and only CodeHaus Jacksons are gone.
--
This is an automated message from the
dongjoon-hyun commented on code in PR #45201:
URL: https://github.com/apache/spark/pull/45201#discussion_r1498186928
##
assembly/pom.xml:
##
@@ -266,6 +266,13 @@
hive-provided
provided
+provided
Review Comment:
Previously, these dependencies
viirya commented on code in PR #45201:
URL: https://github.com/apache/spark/pull/45201#discussion_r1498184744
##
assembly/pom.xml:
##
@@ -266,6 +266,13 @@
hive-provided
provided
+provided
Review Comment:
Hmm, both in `hive-provided` and
dongjoon-hyun commented on PR #45201:
URL: https://github.com/apache/spark/pull/45201#issuecomment-1957752573
Thank you for review. This PR is for the users who keep Hive and exclude
`CodeHaus Jackson` only. For example, a user who can use Spark Thrift Server
without Hive UDFs,
xinrong-meng commented on PR #45201:
URL: https://github.com/apache/spark/pull/45201#issuecomment-1957746586
I may not have enought context. The existing `hive-provided` seems to be
changed to expect Jackson dependencies to be present in the runtime. Is that
expected?
--
This is an
dongjoon-hyun commented on PR #45201:
URL: https://github.com/apache/spark/pull/45201#issuecomment-1957743988
Could you review this PR, @viirya ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dongjoon-hyun opened a new pull request, #45201:
URL: https://github.com/apache/spark/pull/45201
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
###
17 matches
Mail list logo
