Re: [PR] [SPARK-47153][CORE] Guard serialize/deserialize in JavaSerializer with try-with-resource block [spark]

2024-06-08 Thread via GitHub
github-actions[bot] closed pull request #45238: [SPARK-47153][CORE] Guard serialize/deserialize in JavaSerializer with try-with-resource block URL: https://github.com/apache/spark/pull/45238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [SPARK-47153][CORE] Guard serialize/deserialize in JavaSerializer with try-with-resource block [spark]

2024-06-07 Thread via GitHub
github-actions[bot] commented on PR #45238: URL: https://github.com/apache/spark/pull/45238#issuecomment-2155719350 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.

Re: [PR] [SPARK-47153][CORE] Guard serialize/deserialize in JavaSerializer with try-with-resource block [spark]

2024-02-28 Thread via GitHub
jwang0306 commented on PR #45238: URL: https://github.com/apache/spark/pull/45238#issuecomment-1969964182 > These are ByteArray Input/Output Stream's - which are scoped to that specific method; I am not sure I see value in wrapping it. Thanks for the input, @mridulm. At the moment I

Re: [PR] [SPARK-47153][CORE] Guard serialize/deserialize in JavaSerializer with try-with-resource block [spark]

2024-02-27 Thread via GitHub
jwang0306 commented on code in PR #45238: URL: https://github.com/apache/spark/pull/45238#discussion_r1505389956 ## core/src/main/scala/org/apache/spark/serializer/JavaSerializer.scala: ## @@ -118,22 +118,24 @@ private[spark] class JavaSerializerInstance( override def

Re: [PR] [SPARK-47153][CORE] Guard serialize/deserialize in JavaSerializer with try-with-resource block [spark]

2024-02-26 Thread via GitHub
LuciferYang commented on code in PR #45238: URL: https://github.com/apache/spark/pull/45238#discussion_r1503688318 ## core/src/main/scala/org/apache/spark/serializer/JavaSerializer.scala: ## @@ -118,22 +118,24 @@ private[spark] class JavaSerializerInstance( override def