Re: [PR] [SPARK-47229][CORE][SQL][SS][YARN][CONNECT] Change the never changed `var` to `val` [spark]

2024-02-29 Thread via GitHub
dongjoon-hyun commented on PR #45338: URL: https://github.com/apache/spark/pull/45338#issuecomment-1971736612 Merged to master for Apache Spark 4.0.0. Thank you, @LuciferYang and @MaxGekk . -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] [SPARK-47229][CORE][SQL][SS][YARN][CONNECT] Change the never changed `var` to `val` [spark]

2024-02-29 Thread via GitHub
dongjoon-hyun closed pull request #45338: [SPARK-47229][CORE][SQL][SS][YARN][CONNECT] Change the never changed `var` to `val` URL: https://github.com/apache/spark/pull/45338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] [SPARK-47229][CORE][SQL][SS][YARN][CONNECT] Change the never changed `var` to `val` [spark]

2024-02-29 Thread via GitHub
LuciferYang commented on code in PR #45338: URL: https://github.com/apache/spark/pull/45338#discussion_r1508024797 ## resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala: ## @@ -535,7 +535,7 @@ private[spark] class Client( // If preload is enable

Re: [PR] [SPARK-47229][CORE][SQL][SS][YARN][CONNECT] Change the never changed `var` to `val` [spark]

2024-02-29 Thread via GitHub
LuciferYang commented on PR #45338: URL: https://github.com/apache/spark/pull/45338#issuecomment-1971739941 Thanks @dongjoon-hyun and @MaxGekk ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th