Re: [PR] [SPARK-47242][BUILD] Bump ap-loader 3.0(v8) to support for async-profiler 3.0 [spark]

dongjoon-hyun commented on PR #45351: URL: https://github.com/apache/spark/pull/45351#issuecomment-1973807623 To @SteNicholas , for this kind of PR, we can use simply `[BUILD]` tag like GitHub Action bot suggested. ![Screenshot 2024-03-01 at 11 39 13](https://github.com/apache/spark/

Re: [PR] [SPARK-47242][BUILD] Bump ap-loader 3.0(v8) to support for async-profiler 3.0 [spark]

parthchandra commented on PR #45351: URL: https://github.com/apache/spark/pull/45351#issuecomment-1974173364 Yes there is no good way to test this in ci. Let me try it out and make sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] [SPARK-47242][BUILD] Bump ap-loader 3.0(v8) to support for async-profiler 3.0 [spark]

dongjoon-hyun commented on PR #45351: URL: https://github.com/apache/spark/pull/45351#issuecomment-1974828172 Thank you so much, @parthchandra ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] [SPARK-47242][BUILD] Bump ap-loader 3.0(v8) to support for async-profiler 3.0 [spark]

SteNicholas commented on PR #45351: URL: https://github.com/apache/spark/pull/45351#issuecomment-1975460640 @parthchandra, thank you try it out. Have you tried anything wrong? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] [SPARK-47242][BUILD] Bump ap-loader 3.0(v8) to support for async-profiler 3.0 [spark]

HyukjinKwon commented on PR #45351: URL: https://github.com/apache/spark/pull/45351#issuecomment-1975495691 The original PR does not have its test together (https://github.com/apache/spark/pull/44021). @SteNicholas Mind describing how you tested this? -- This is an automated message from

Re: [PR] [SPARK-47242][BUILD] Bump ap-loader 3.0(v8) to support for async-profiler 3.0 [spark]

SteNicholas commented on PR #45351: URL: https://github.com/apache/spark/pull/45351#issuecomment-1975895901 > The original PR does not have its test together (#44021). @SteNicholas Mind describing how you tested this? @HyukjinKwon, I only tested this bump in production environment of

Re: [PR] [SPARK-47242][BUILD] Bump ap-loader 3.0(v8) to support for async-profiler 3.0 [spark]

HyukjinKwon commented on PR #45351: URL: https://github.com/apache/spark/pull/45351#issuecomment-1975909802 That's fine. My point is that please describe it in the PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [SPARK-47242][BUILD] Bump ap-loader 3.0(v8) to support for async-profiler 3.0 [spark]

parthchandra commented on PR #45351: URL: https://github.com/apache/spark/pull/45351#issuecomment-1977330468 > @parthchandra, thank you try it out. Have you tried anything wrong? I was able to try it out locally (non production) and the jfr files written were fine. I didn't see much d

Re: [PR] [SPARK-47242][BUILD] Bump ap-loader 3.0(v8) to support for async-profiler 3.0 [spark]

dongjoon-hyun closed pull request #45351: [SPARK-47242][BUILD] Bump ap-loader 3.0(v8) to support for async-profiler 3.0 URL: https://github.com/apache/spark/pull/45351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] [SPARK-47242][BUILD] Bump ap-loader 3.0(v8) to support for async-profiler 3.0 [spark]

dongjoon-hyun commented on PR #45351: URL: https://github.com/apache/spark/pull/45351#issuecomment-1977336300 I added you to the Apache Spark contributor group, @SteNicholas , and assigned SPARK-47242 to you. Welcome to the Apache Spark community! -- This is an automated message from t