Re: [PR] [SPARK-47682][SQL] Support cast from variant. [spark]

2024-04-08 Thread via GitHub
cloud-fan commented on PR #45807: URL: https://github.com/apache/spark/pull/45807#issuecomment-2044110214 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [SPARK-47682][SQL] Support cast from variant. [spark]

2024-04-08 Thread via GitHub
cloud-fan closed pull request #45807: [SPARK-47682][SQL] Support cast from variant. URL: https://github.com/apache/spark/pull/45807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [SPARK-47682][SQL] Support cast from variant. [spark]

2024-04-08 Thread via GitHub
chenhao-db commented on PR #45807: URL: https://github.com/apache/spark/pull/45807#issuecomment-2043169795 @cloud-fan Could you help review this PR? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] [SPARK-47682][SQL] Support cast from variant. [spark]

2024-04-07 Thread via GitHub
chenhao-db commented on code in PR #45807: URL: https://github.com/apache/spark/pull/45807#discussion_r1555249662 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala: ## @@ -1198,6 +1208,20 @@ case class Cast( case _ if from == NullType =>

Re: [PR] [SPARK-47682][SQL] Support cast from variant. [spark]

2024-04-07 Thread via GitHub
cloud-fan commented on code in PR #45807: URL: https://github.com/apache/spark/pull/45807#discussion_r1555185070 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala: ## @@ -1198,6 +1208,20 @@ case class Cast( case _ if from == NullType => (

Re: [PR] [SPARK-47682][SQL] Support cast from variant. [spark]

2024-04-02 Thread via GitHub
chenhao-db commented on PR #45807: URL: https://github.com/apache/spark/pull/45807#issuecomment-2033348791 @HyukjinKwon Sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [SPARK-47682][SQL] Support cast from variant. [spark]

2024-04-02 Thread via GitHub
HyukjinKwon commented on PR #45807: URL: https://github.com/apache/spark/pull/45807#issuecomment-2033343284 Can you keep the PR template please? https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE -- This is an automated message from the Apache Git Service. To respon

[PR] [SPARK-47682][SQL] Support cast from variant. [spark]

2024-04-01 Thread via GitHub
chenhao-db opened a new pull request, #45807: URL: https://github.com/apache/spark/pull/45807 ### What changes were proposed in this pull request? This PR allows casting from variant to another type. It has the same semantics as `variant_get` with an empty path. ### How was thi