Re: [PR] [SPARK-47733][SS] Add custom metrics for transformWithState operator part of query progress [spark]

2024-04-12 Thread via GitHub
HeartSaVioR closed pull request #45937: [SPARK-47733][SS] Add custom metrics for transformWithState operator part of query progress URL: https://github.com/apache/spark/pull/45937 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] [SPARK-47733][SS] Add custom metrics for transformWithState operator part of query progress [spark]

2024-04-12 Thread via GitHub
HeartSaVioR commented on PR #45937: URL: https://github.com/apache/spark/pull/45937#issuecomment-2051214351 Thanks! Merging to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-47733][SS] Add custom metrics for transformWithState operator part of query progress [spark]

2024-04-11 Thread via GitHub
HeartSaVioR commented on code in PR #45937: URL: https://github.com/apache/spark/pull/45937#discussion_r1561908874 ## sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithListStateSuite.scala: ## @@ -307,7 +307,10 @@ class TransformWithListStateSuite extends Strea

Re: [PR] [SPARK-47733][SS] Add custom metrics for transformWithState operator part of query progress [spark]

2024-04-11 Thread via GitHub
anishshri-db commented on code in PR #45937: URL: https://github.com/apache/spark/pull/45937#discussion_r1561386255 ## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TTLState.scala: ## @@ -105,17 +109,21 @@ abstract class SingleKeyTTLStateImpl( /** * Cle

Re: [PR] [SPARK-47733][SS] Add custom metrics for transformWithState operator part of query progress [spark]

2024-04-11 Thread via GitHub
sahnib commented on code in PR #45937: URL: https://github.com/apache/spark/pull/45937#discussion_r1561381648 ## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TTLState.scala: ## @@ -105,17 +109,21 @@ abstract class SingleKeyTTLStateImpl( /** * Clears an

Re: [PR] [SPARK-47733][SS] Add custom metrics for transformWithState operator part of query progress [spark]

2024-04-10 Thread via GitHub
anishshri-db commented on PR #45937: URL: https://github.com/apache/spark/pull/45937#issuecomment-2048792306 > Should we also add some metrics around ttl? (Like keys deleted from state on ttl expiry?) Done, added -- This is an automated message from the Apache Git Service. To respo

Re: [PR] [SPARK-47733][SS] Add custom metrics for transformWithState operator part of query progress [spark]

2024-04-10 Thread via GitHub
anishshri-db commented on code in PR #45937: URL: https://github.com/apache/spark/pull/45937#discussion_r1560336821 ## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulProcessorHandleImpl.scala: ## @@ -112,6 +116,10 @@ class StatefulProcessorHandleImpl(

Re: [PR] [SPARK-47733][SS] Add custom metrics for transformWithState operator part of query progress [spark]

2024-04-10 Thread via GitHub
sahnib commented on code in PR #45937: URL: https://github.com/apache/spark/pull/45937#discussion_r1560074588 ## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulProcessorHandleImpl.scala: ## @@ -112,6 +116,10 @@ class StatefulProcessorHandleImpl( pr

Re: [PR] [SPARK-47733][SS] Add custom metrics for transformWithState operator part of query progress [spark]

2024-04-09 Thread via GitHub
anishshri-db commented on PR #45937: URL: https://github.com/apache/spark/pull/45937#issuecomment-2046169178 @sahnib @HeartSaVioR - PTAL, thx ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the