Re: [PR] [SPARK-47765][SQL] Add SET COLLATION to parser rules [spark]

mihailom-db commented on PR #45946: URL: https://github.com/apache/spark/pull/45946#issuecomment-2060579504 Yeah forgot to block it. Will create a followup to add that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [SPARK-47765][SQL] Add SET COLLATION to parser rules [spark]

cloud-fan commented on PR #45946: URL: https://github.com/apache/spark/pull/45946#issuecomment-2060252622 Shall we fail this command if the string collation feature flag is turned off? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [SPARK-47765][SQL] Add SET COLLATION to parser rules [spark]

cloud-fan closed pull request #45946: [SPARK-47765][SQL] Add SET COLLATION to parser rules URL: https://github.com/apache/spark/pull/45946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [SPARK-47765][SQL] Add SET COLLATION to parser rules [spark]

cloud-fan commented on PR #45946: URL: https://github.com/apache/spark/pull/45946#issuecomment-2051862860 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-47765][SQL] Add SET COLLATION to parser rules [spark]

cloud-fan commented on code in PR #45946: URL: https://github.com/apache/spark/pull/45946#discussion_r1561965680 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ## @@ -202,6 +202,22 @@ public static StringSearch getStringSearch(

Re: [PR] [SPARK-47765][SQL] Add SET COLLATION to parser rules [spark]

cloud-fan commented on code in PR #45946: URL: https://github.com/apache/spark/pull/45946#discussion_r1561034979 ## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ## @@ -772,6 +772,8 @@ object SQLConf { " produced by a builtin function such as

Re: [PR] [SPARK-47765][SQL] Add SET COLLATION to parser rules [spark]

mihailom-db commented on code in PR #45946: URL: https://github.com/apache/spark/pull/45946#discussion_r1561024421 ## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ## @@ -772,6 +772,8 @@ object SQLConf { " produced by a builtin function such

Re: [PR] [SPARK-47765][SQL] Add SET COLLATION to parser rules [spark]

cloud-fan commented on code in PR #45946: URL: https://github.com/apache/spark/pull/45946#discussion_r1560952934 ## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ## @@ -772,6 +772,8 @@ object SQLConf { " produced by a builtin function such as

Re: [PR] [SPARK-47765][SQL] Add SET COLLATION to parser rules [spark]

mihailom-db commented on code in PR #45946: URL: https://github.com/apache/spark/pull/45946#discussion_r1560529470 ## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ## @@ -772,6 +772,7 @@ object SQLConf { " produced by a builtin function such

Re: [PR] [SPARK-47765][SQL] Add SET COLLATION to parser rules [spark]

mihailom-db commented on code in PR #45946: URL: https://github.com/apache/spark/pull/45946#discussion_r1560529083 ## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ## @@ -772,6 +772,7 @@ object SQLConf { " produced by a builtin function such

Re: [PR] [SPARK-47765][SQL] Add SET COLLATION to parser rules [spark]

mihailom-db commented on code in PR #45946: URL: https://github.com/apache/spark/pull/45946#discussion_r1560526628 ## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ## @@ -772,6 +772,7 @@ object SQLConf { " produced by a builtin function such

Re: [PR] [SPARK-47765][SQL] Add SET COLLATION to parser rules [spark]

cloud-fan commented on code in PR #45946: URL: https://github.com/apache/spark/pull/45946#discussion_r1560523261 ## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ## @@ -772,6 +772,7 @@ object SQLConf { " produced by a builtin function such as

Re: [PR] [SPARK-47765][SQL] Add SET COLLATION to parser rules [spark]

cloud-fan commented on code in PR #45946: URL: https://github.com/apache/spark/pull/45946#discussion_r1560522533 ## sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala: ## @@ -505,7 +505,23 @@ class SQLConfSuite extends QueryTest with SharedSparkSession {

Re: [PR] [SPARK-47765][SQL] Add SET COLLATION to parser rules [spark]

cloud-fan commented on code in PR #45946: URL: https://github.com/apache/spark/pull/45946#discussion_r1560522065 ## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ## @@ -772,6 +772,7 @@ object SQLConf { " produced by a builtin function such as

Re: [PR] [SPARK-47765][SQL] Add SET COLLATION to parser rules [spark]

cloud-fan commented on code in PR #45946: URL: https://github.com/apache/spark/pull/45946#discussion_r1560522355 ## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ## @@ -772,6 +772,7 @@ object SQLConf { " produced by a builtin function such as

Re: [PR] [SPARK-47765][SQL] Add SET COLLATION to parser rules [spark]

mihailom-db commented on code in PR #45946: URL: https://github.com/apache/spark/pull/45946#discussion_r1560519969 ## sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala: ## @@ -1062,4 +1062,11 @@ class CollationSuite extends DatasourceV2SQLBase with

Re: [PR] [SPARK-47765][SQL] Add SET COLLATION to parser rules [spark]

cloud-fan commented on code in PR #45946: URL: https://github.com/apache/spark/pull/45946#discussion_r1560342794 ## sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala: ## @@ -1062,4 +1062,11 @@ class CollationSuite extends DatasourceV2SQLBase with

Re: [PR] [SPARK-47765][SQL] Add SET COLLATION to parser rules [spark]

cloud-fan commented on code in PR #45946: URL: https://github.com/apache/spark/pull/45946#discussion_r1559288999 ## sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala: ## @@ -1062,4 +1062,10 @@ class CollationSuite extends DatasourceV2SQLBase with

[PR] [SPARK-47765][SQL] Add SET COLLATION to parser rules [spark]

mihailom-db opened a new pull request, #45946: URL: https://github.com/apache/spark/pull/45946 ### What changes were proposed in this pull request? Addition of a new statement SET COLLATION collationName. ### Why are the changes needed? Requested by @srielau in order to