LuciferYang commented on PR #46249:
URL: https://github.com/apache/spark/pull/46249#issuecomment-2081298871
late LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
panbingkun commented on PR #46249:
URL: https://github.com/apache/spark/pull/46249#issuecomment-2080233200
Great!
+1, LGTM. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dongjoon-hyun closed pull request #46249: [SPARK-48011][Core] Store LogKey name
as a value to avoid generating new string instances
URL: https://github.com/apache/spark/pull/46249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
gengliangwang commented on PR #46249:
URL: https://github.com/apache/spark/pull/46249#issuecomment-2079860587
cc @panbingkun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
gengliangwang opened a new pull request, #46249:
URL: https://github.com/apache/spark/pull/46249
### What changes were proposed in this pull request?
Store LogKey name as a value to avoid generating new string instances
### Why are the changes needed?
To save memo
gengliangwang commented on code in PR #46249:
URL: https://github.com/apache/spark/pull/46249#discussion_r1581359491
##
common/utils/src/main/scala/org/apache/spark/internal/LogKey.scala:
##
@@ -16,10 +16,14 @@
*/
package org.apache.spark.internal
+import java.util.Locale
+
