dongjoon-hyun closed pull request #46288: [SPARK-48049][BUILD] Upgrade Scala to
2.13.14
URL: https://github.com/apache/spark/pull/46288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
panbingkun commented on code in PR #46288:
URL: https://github.com/apache/spark/pull/46288#discussion_r1600764596
##
project/SparkBuild.scala:
##
@@ -266,7 +266,7 @@ object SparkBuild extends PomBuild {
.orElse(sys.props.get("java.home").map { p => new
panbingkun commented on code in PR #46288:
URL: https://github.com/apache/spark/pull/46288#discussion_r1600764596
##
project/SparkBuild.scala:
##
@@ -266,7 +266,7 @@ object SparkBuild extends PomBuild {
.orElse(sys.props.get("java.home").map { p => new
panbingkun commented on code in PR #46288:
URL: https://github.com/apache/spark/pull/46288#discussion_r1600020913
##
project/SparkBuild.scala:
##
@@ -266,7 +266,7 @@ object SparkBuild extends PomBuild {
.orElse(sys.props.get("java.home").map { p => new
panbingkun commented on code in PR #46288:
URL: https://github.com/apache/spark/pull/46288#discussion_r1600020913
##
project/SparkBuild.scala:
##
@@ -266,7 +266,7 @@ object SparkBuild extends PomBuild {
.orElse(sys.props.get("java.home").map { p => new
LuciferYang commented on code in PR #46288:
URL: https://github.com/apache/spark/pull/46288#discussion_r1599902760
##
project/SparkBuild.scala:
##
@@ -266,7 +266,7 @@ object SparkBuild extends PomBuild {
.orElse(sys.props.get("java.home").map { p => new
panbingkun commented on PR #46288:
URL: https://github.com/apache/spark/pull/46288#issuecomment-2109705338
> https://github.com/com-lihaoyi/Ammonite/releases/tag/3.0.0-M2
>
> 3.0.0-M2 released ~ @panbingkun
Thanks~ ❤️
Updated.
--
This is an automated message from the
LuciferYang commented on PR #46288:
URL: https://github.com/apache/spark/pull/46288#issuecomment-2109686654
https://github.com/com-lihaoyi/Ammonite/releases/tag/3.0.0-M2
3.0.0-M2 released ~ @panbingkun
--
This is an automated message from the Apache Git Service.
To respond to the
dongjoon-hyun commented on PR #46288:
URL: https://github.com/apache/spark/pull/46288#issuecomment-2098787633
Thank you for confirming. Ya, let's wait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
panbingkun commented on PR #46288:
URL: https://github.com/apache/spark/pull/46288#issuecomment-2098219208
> > > * Is the PR ready?
> > > * `ammonite` 3.0.0-M1` is enough?
> > >
> > > * https://ammonite.io/#3.0.0-M1
> >
> >
> > I use this version
LuciferYang commented on PR #46288:
URL: https://github.com/apache/spark/pull/46288#issuecomment-2098208895
> > * Is the PR ready?
> > * `ammonite` 3.0.0-M1` is enough?
> >
> > * https://ammonite.io/#3.0.0-M1
>
> I use this version
panbingkun commented on PR #46288:
URL: https://github.com/apache/spark/pull/46288#issuecomment-2097636775
> * Is the PR ready?
> * `ammonite` 3.0.0-M1` is enough?
>
> * https://ammonite.io/#3.0.0-M1
I use this version
LuciferYang commented on PR #46288:
URL: https://github.com/apache/spark/pull/46288#issuecomment-2097501153
I think we need wait a new Ammonite release version, as 3.0-M1 does not
support Scala 2.13.14.
dongjoon-hyun commented on PR #46288:
URL: https://github.com/apache/spark/pull/46288#issuecomment-2096470803
- Is the PR ready?
- `ammonite` 3.0.0-M1` is enough?
- https://ammonite.io/#3.0.0-M1
--
This is an automated message from the Apache Git Service.
To respond to the
dongjoon-hyun commented on PR #46288:
URL: https://github.com/apache/spark/pull/46288#issuecomment-2096458751
Thank you, @panbingkun .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dongjoon-hyun commented on code in PR #46288:
URL: https://github.com/apache/spark/pull/46288#discussion_r1591275127
##
pom.xml:
##
@@ -2981,6 +2981,9 @@
${java.version}
test
provided
+
+
panbingkun commented on PR #46288:
URL: https://github.com/apache/spark/pull/46288#issuecomment-2095480361
@dongjoon-hyun @LuciferYang
Based on the detailed explanation of
https://github.com/scala/bug/issues/12994,
panbingkun commented on PR #46288:
URL: https://github.com/apache/spark/pull/46288#issuecomment-2095042166
> Do we have a corresponding issue in the Scala community or JLine community
(or GitHub issue)?
>
> IMO, a. We can ignore Scala 2.13.14 completely due to this issue. b. We
can
LuciferYang commented on PR #46288:
URL: https://github.com/apache/spark/pull/46288#issuecomment-2094049100
> Do we have a corresponding issue in the Scala community or JLine community
(or GitHub issue)?
>
> IMO, a. We can ignore Scala 2.13.14 completely due to this issue. b. We
can
LuciferYang commented on PR #46288:
URL: https://github.com/apache/spark/pull/46288#issuecomment-2094048178
> > Thank you for the analysis and sharing, @panbingkun and @LuciferYang .
>
> > [INFO] Restricted to JDK 17 yet org.jline:jline:jar:3.25.1:compile
contains
panbingkun commented on PR #46288:
URL: https://github.com/apache/spark/pull/46288#issuecomment-2093917835
Currently, this GA has turned green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
panbingkun commented on PR #46288:
URL: https://github.com/apache/spark/pull/46288#issuecomment-2093915493
> Thank you for the analysis and sharing, @panbingkun and @LuciferYang .
> [INFO] Restricted to JDK 17 yet org.jline:jline:jar:3.25.1:compile
contains
dongjoon-hyun commented on PR #46288:
URL: https://github.com/apache/spark/pull/46288#issuecomment-2093258975
Thank you for the analysis and sharing, @panbingkun and @LuciferYang .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
LuciferYang commented on PR #46288:
URL: https://github.com/apache/spark/pull/46288#issuecomment-2093165641
[INFO] Restricted to JDK 17 yet org.jline:jline:jar:3.25.1:compile contains
org/jline/terminal/impl/ffm/CLibrary$termios.class targeted to 65.-257
Oh... It seems that
LuciferYang commented on PR #46288:
URL: https://github.com/apache/spark/pull/46288#issuecomment-2093132416
https://github.com/jline/jline3/blob/c75301facc8716b59c1d57d3e3c5943358022560/pom.xml#L93-L95
panbingkun commented on PR #46288:
URL: https://github.com/apache/spark/pull/46288#issuecomment-2093048107
@SethTisue
Just right, you are here too
https://github.com/scala/scala/pull/10717
dongjoon-hyun commented on code in PR #46288:
URL: https://github.com/apache/spark/pull/46288#discussion_r1587813517
##
connector/connect/client/jvm/pom.xml:
##
@@ -73,7 +73,7 @@
com.lihaoyi
- ammonite_${scala.version}
+ ammonite_2.13.13
Review
panbingkun commented on code in PR #46288:
URL: https://github.com/apache/spark/pull/46288#discussion_r1587786326
##
connector/connect/client/jvm/pom.xml:
##
@@ -73,7 +73,7 @@
com.lihaoyi
- ammonite_${scala.version}
+ ammonite_2.13.13
Review
panbingkun commented on PR #46288:
URL: https://github.com/apache/spark/pull/46288#issuecomment-2090712115
> jline
I guess it may be related to the fact that the `Ammonite` supporting `scala
2.13.14` has not been released.
--
This is an automated message from the Apache Git
dongjoon-hyun commented on PR #46288:
URL: https://github.com/apache/spark/pull/46288#issuecomment-2090615461
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
panbingkun commented on PR #46288:
URL: https://github.com/apache/spark/pull/46288#issuecomment-2089952489
>
https://repo1.maven.org/maven2/com/typesafe/genjavadoc/genjavadoc-plugin_2.13.14/0.19/
I have updated the version of `genjavadoc` in the file
`project/SparkBuild.scala`.
--
panbingkun commented on PR #46288:
URL: https://github.com/apache/spark/pull/46288#issuecomment-2089669299
> Although we are waiting for `Ammonite` still, could you base this PR once
more, @panbingkun ?
>
> * [Add support for Scala 2.13.14
dongjoon-hyun commented on PR #46288:
URL: https://github.com/apache/spark/pull/46288#issuecomment-2089216404
Although we are waiting for `Ammonite` still, could you base this PR once
more, @panbingkun ?
- https://github.com/com-lihaoyi/Ammonite/pull/1482
--
This is an automated
dongjoon-hyun commented on PR #46288:
URL: https://github.com/apache/spark/pull/46288#issuecomment-2088823817
Thank you so much, @SethTisue !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
SethTisue commented on PR #46288:
URL: https://github.com/apache/spark/pull/46288#issuecomment-2088541151
https://repo1.maven.org/maven2/com/typesafe/genjavadoc/genjavadoc-plugin_2.13.14/0.19/
--
This is an automated message from the Apache Git Service.
To respond to the message, please
35 matches
Mail list logo
