Re: [PR] [SPARK-48142][PYTHON][CONNECT][TESTS] Enable `CogroupedApplyInPandasTests.test_wrong_args` [spark]

2024-05-06 Thread via GitHub
zhengruifeng commented on PR #46397: URL: https://github.com/apache/spark/pull/46397#issuecomment-2097185722 thanks @xinrong-meng merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [SPARK-48142][PYTHON][CONNECT][TESTS] Enable `CogroupedApplyInPandasTests.test_wrong_args` [spark]

2024-05-06 Thread via GitHub
zhengruifeng closed pull request #46397: [SPARK-48142][PYTHON][CONNECT][TESTS] Enable `CogroupedApplyInPandasTests.test_wrong_args` URL: https://github.com/apache/spark/pull/46397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [SPARK-48142][PYTHON][CONNECT][TESTS] Enable `CogroupedApplyInPandasTests.test_wrong_args` [spark]

2024-05-06 Thread via GitHub
xinrong-meng commented on PR #46397: URL: https://github.com/apache/spark/pull/46397#issuecomment-2096610525 LGTM thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [SPARK-48142][PYTHON][CONNECT][TESTS] Enable `CogroupedApplyInPandasTests.test_wrong_args` [spark]

2024-05-06 Thread via GitHub
zhengruifeng commented on code in PR #46397: URL: https://github.com/apache/spark/pull/46397#discussion_r1590766241 ## python/pyspark/sql/connect/group.py: ## @@ -398,11 +398,18 @@ def applyInPandas( ) -> "DataFrame": from pyspark.sql.connect.udf import

Re: [PR] [SPARK-48142][PYTHON][CONNECT][TESTS] Enable `CogroupedApplyInPandasTests.test_wrong_args` [spark]

2024-05-06 Thread via GitHub
zhengruifeng commented on code in PR #46397: URL: https://github.com/apache/spark/pull/46397#discussion_r1590766241 ## python/pyspark/sql/connect/group.py: ## @@ -398,11 +398,18 @@ def applyInPandas( ) -> "DataFrame": from pyspark.sql.connect.udf import