HyukjinKwon commented on PR #46408:
URL: https://github.com/apache/spark/pull/46408#issuecomment-2230017862
This is what I tried:
```diff
ff --git
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/CreateJacksonParser.scala
b/sql/catalyst/src/main/scala/org/apache/sp
HyukjinKwon commented on PR #46408:
URL: https://github.com/apache/spark/pull/46408#issuecomment-2230017438
Hm, I think this PR also doesn't cover multiline cases.
Another problem is that it seems `parser.currentLocation.getByteOffset`
doesn't report correctly too so we cannot really
HyukjinKwon commented on PR #46408:
URL: https://github.com/apache/spark/pull/46408#issuecomment-2229681590
Let me take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
sandip-db commented on PR #46408:
URL: https://github.com/apache/spark/pull/46408#issuecomment-2225838233
I did some tests and it looks like that this PR doesn't address the same
issue with from_json. Json expressions including from_json use
[CreateJacksonParser.utf8String](https://github.c
HyukjinKwon commented on PR #46408:
URL: https://github.com/apache/spark/pull/46408#issuecomment-2223501345
sent offline ping too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
HyukjinKwon commented on PR #46408:
URL: https://github.com/apache/spark/pull/46408#issuecomment-2223500412
ping @eric-maynard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
revans2 commented on PR #46408:
URL: https://github.com/apache/spark/pull/46408#issuecomment-973633
@eric-maynard and @HyukjinKwon any update on fixing at least from_json if
not also get_json_object? If you need me to try and try and debug this and put
up a patch I am happy to.
--
T
HyukjinKwon commented on PR #46408:
URL: https://github.com/apache/spark/pull/46408#issuecomment-2103609498
btw you can trigger on your own
https://github.com/eric-maynard/spark/runs/24789350525 I can't trigger :-).
--
This is an automated message from the Apache Git Service.
To respond t
HyukjinKwon closed pull request #46408: [SPARK-48148][CORE] JSON objects should
not be modified when read as STRING
URL: https://github.com/apache/spark/pull/46408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
HyukjinKwon commented on PR #46408:
URL: https://github.com/apache/spark/pull/46408#issuecomment-2103609100
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
eric-maynard commented on PR #46408:
URL: https://github.com/apache/spark/pull/46408#issuecomment-2103174421
Hey @HyukjinKwon, can you take another look and possible re-trigger tests? I
believe multiline should be working now.
--
This is an automated message from the Apache Git Service.
T
eric-maynard commented on code in PR #46408:
URL: https://github.com/apache/spark/pull/46408#discussion_r1595695553
##
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala:
##
@@ -3900,26 +3900,26 @@ abstract class JsonSuite
}
}
HyukjinKwon commented on PR #46408:
URL: https://github.com/apache/spark/pull/46408#issuecomment-2101842606
```
SPARK-48148: values are unchanged when read as string *** FAILED *** (134
milliseconds)
```
seems it fails
--
This is an automated message from the Apache Git Servi
HyukjinKwon commented on code in PR #46408:
URL: https://github.com/apache/spark/pull/46408#discussion_r1594851880
##
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala:
##
@@ -3865,6 +3865,65 @@ abstract class JsonSuite
}
}
}
HyukjinKwon commented on code in PR #46408:
URL: https://github.com/apache/spark/pull/46408#discussion_r1594852087
##
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala:
##
@@ -3865,6 +3865,65 @@ abstract class JsonSuite
}
}
}
HyukjinKwon commented on code in PR #46408:
URL: https://github.com/apache/spark/pull/46408#discussion_r1594852326
##
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala:
##
@@ -3865,6 +3865,65 @@ abstract class JsonSuite
}
}
}
HyukjinKwon commented on code in PR #46408:
URL: https://github.com/apache/spark/pull/46408#discussion_r1594851819
##
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala:
##
@@ -3865,6 +3865,65 @@ abstract class JsonSuite
}
}
}
eric-maynard commented on code in PR #46408:
URL: https://github.com/apache/spark/pull/46408#discussion_r1594623695
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala:
##
@@ -280,13 +280,32 @@ class JacksonParser(
case VALUE_STRING =>
eric-maynard commented on code in PR #46408:
URL: https://github.com/apache/spark/pull/46408#discussion_r1594767881
##
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala:
##
@@ -3865,6 +3865,24 @@ abstract class JsonSuite
}
}
}
eric-maynard commented on code in PR #46408:
URL: https://github.com/apache/spark/pull/46408#discussion_r1594623260
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala:
##
@@ -280,13 +280,32 @@ class JacksonParser(
case VALUE_STRING =>
sadikovi commented on code in PR #46408:
URL: https://github.com/apache/spark/pull/46408#discussion_r1594580639
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala:
##
@@ -280,13 +280,32 @@ class JacksonParser(
case VALUE_STRING =>
sadikovi commented on PR #46408:
URL: https://github.com/apache/spark/pull/46408#issuecomment-2101372332
cc @dongjoon-hyun @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
eric-maynard commented on code in PR #46408:
URL: https://github.com/apache/spark/pull/46408#discussion_r1591615927
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala:
##
@@ -280,13 +280,32 @@ class JacksonParser(
case VALUE_STRING =>
eric-maynard opened a new pull request, #46408:
URL: https://github.com/apache/spark/pull/46408
### What changes were proposed in this pull request?
Currently, when reading a JSON like this:
```
{"a": {"b": -999.995}}
```
With the schema:
24 matches
Mail list logo
