Re: [PR] [SPARK-48228][PYTHON][CONNECT] Implement the missing function validation in ApplyInXXX [spark]

2024-05-14 Thread via GitHub
xinrong-meng commented on PR #46519: URL: https://github.com/apache/spark/pull/46519#issuecomment-2110802986 Late LGTM, thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] [SPARK-48228][PYTHON][CONNECT] Implement the missing function validation in ApplyInXXX [spark]

2024-05-09 Thread via GitHub
zhengruifeng commented on PR #46519: URL: https://github.com/apache/spark/pull/46519#issuecomment-2103877686 @dongjoon-hyun and @HyukjinKwon thanks for reviews -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] [SPARK-48228][PYTHON][CONNECT] Implement the missing function validation in ApplyInXXX [spark]

2024-05-09 Thread via GitHub
dongjoon-hyun commented on PR #46519: URL: https://github.com/apache/spark/pull/46519#issuecomment-2103868519 Merged to master for Apache Spark 4.0.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [SPARK-48228][PYTHON][CONNECT] Implement the missing function validation in ApplyInXXX [spark]

2024-05-09 Thread via GitHub
dongjoon-hyun closed pull request #46519: [SPARK-48228][PYTHON][CONNECT] Implement the missing function validation in ApplyInXXX URL: https://github.com/apache/spark/pull/46519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [SPARK-48228][PYTHON][CONNECT] Implement the missing function validation in ApplyInXXX [spark]

2024-05-09 Thread via GitHub
zhengruifeng commented on code in PR #46519: URL: https://github.com/apache/spark/pull/46519#discussion_r1596217131 ## python/pyspark/sql/connect/group.py: ## @@ -34,6 +34,7 @@ from pyspark.util import PythonEvalType from pyspark.sql.group import GroupedData as PySparkGroupedD

[PR] [SPARK-48228][PYTHON][CONNECT] Implement the missing function validation in ApplyInXXX [spark]

2024-05-09 Thread via GitHub
zhengruifeng opened a new pull request, #46519: URL: https://github.com/apache/spark/pull/46519 ### What changes were proposed in this pull request? Implement the missing function validation in ApplyInXXX https://github.com/apache/spark/pull/46397 fixed this issue for `Cogrouped.Ap