yaooqinn commented on PR #46609:
URL: https://github.com/apache/spark/pull/46609#issuecomment-2121794324
Merged to master.
Thank you @panbingkun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
yaooqinn closed pull request #46609: [SPARK-48300][SQL] Codegen Support for
`from_xml`
URL: https://github.com/apache/spark/pull/46609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
yaooqinn commented on code in PR #46609:
URL: https://github.com/apache/spark/pull/46609#discussion_r1607505328
##
sql/core/src/test/scala/org/apache/spark/sql/XmlFunctionsSuite.scala:
##
@@ -40,6 +40,17 @@ class XmlFunctionsSuite extends QueryTest with
SharedSparkSession {
panbingkun commented on PR #46609:
URL: https://github.com/apache/spark/pull/46609#issuecomment-2121582579
It has rebase the master. At present, this PR is only for `codegen support
for from_xml`
@sandip-db @HyukjinKwon @yaooqinn @cloud-fan
--
This is an automated message from the Apa
panbingkun commented on PR #46609:
URL: https://github.com/apache/spark/pull/46609#issuecomment-2119553250
cc @sandip-db @HyukjinKwon @cloud-fan @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
panbingkun commented on code in PR #46609:
URL: https://github.com/apache/spark/pull/46609#discussion_r1603226466
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xmlExpressions.scala:
##
@@ -104,7 +103,7 @@ case class XmlToStructs(
if (mode != Permi
panbingkun opened a new pull request, #46609:
URL: https://github.com/apache/spark/pull/46609
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How
