cloud-fan closed pull request #46617: [SPARK-48307][SQL] InlineCTE should keep
not-inlined relations in the original WithCTE node
URL: https://github.com/apache/spark/pull/46617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
cloud-fan commented on PR #46617:
URL: https://github.com/apache/spark/pull/46617#issuecomment-2148488195
thanks for the review, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
cloud-fan commented on PR #46617:
URL: https://github.com/apache/spark/pull/46617#issuecomment-2121381949
> Repartition? Do you mean Relation?
It's Reparition, because we rely on shuffle reuse to reuse CTE relations.
--
This is an automated message from the Apache Git Service.
To re
viirya commented on PR #46617:
URL: https://github.com/apache/spark/pull/46617#issuecomment-2120577446
> This is not true anymore after https://github.com/apache/spark/pull/42036
. It's not a big deal as we replace not-inlined CTE relations with Repartition
during
`Repartition? Do yo
viirya commented on code in PR #46617:
URL: https://github.com/apache/spark/pull/46617#discussion_r1606854563
##
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/InlineCTESuite.scala:
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
amaliujia commented on code in PR #46617:
URL: https://github.com/apache/spark/pull/46617#discussion_r1603865663
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InlineCTE.scala:
##
@@ -74,34 +70,33 @@ case class InlineCTE(alwaysInline: Boolean = false) ext
cloud-fan commented on PR #46617:
URL: https://github.com/apache/spark/pull/46617#issuecomment-2115021011
cc @viirya @amaliujia @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
cloud-fan opened a new pull request, #46617:
URL: https://github.com/apache/spark/pull/46617
### What changes were proposed in this pull request?
I noticed an outdated comment in the rule `InlineCTE`
```
// CTEs in SQL Commands have been inlined by `CTESubstitution`
