Re: [PR] [SPARK-48403][SQL] Fix Lower & Upper expressions for UTF8_BINARY_LCASE & ICU collations [spark]

2024-06-10 Thread via GitHub
cloud-fan commented on PR #46720: URL: https://github.com/apache/spark/pull/46720#issuecomment-2158788972 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-48403][SQL] Fix Lower & Upper expressions for UTF8_BINARY_LCASE & ICU collations [spark]

2024-06-10 Thread via GitHub
cloud-fan closed pull request #46720: [SPARK-48403][SQL] Fix Lower & Upper expressions for UTF8_BINARY_LCASE & ICU collations URL: https://github.com/apache/spark/pull/46720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [SPARK-48403][SQL] Fix Lower & Upper expressions for UTF8_BINARY_LCASE & ICU collations [spark]

2024-06-07 Thread via GitHub
uros-db commented on code in PR #46720: URL: https://github.com/apache/spark/pull/46720#discussion_r1630998971 ## common/unsafe/src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java: ## @@ -494,10 +494,10 @@ public void testUpper() throws SparkException {

Re: [PR] [SPARK-48403][SQL] Fix Lower & Upper expressions for UTF8_BINARY_LCASE & ICU collations [spark]

2024-06-06 Thread via GitHub
mkaravel commented on code in PR #46720: URL: https://github.com/apache/spark/pull/46720#discussion_r1630676281 ## common/unsafe/src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java: ## @@ -494,10 +494,10 @@ public void testUpper() throws SparkException {