Re: [PR] [SPARK-48851][SQL] Change the value of `SCHEMA_NOT_FOUND` from `namespace` to `catalog.namespace` [spark]

2024-07-21 Thread via GitHub
zhengruifeng commented on PR #47276: URL: https://github.com/apache/spark/pull/47276#issuecomment-2241860283 This change is not only a user-facing change, it actually breaks the exception handling in external catalogs like: ``` try { } catch { case e: NoSuchDatabaseExce

Re: [PR] [SPARK-48851][SQL] Change the value of `SCHEMA_NOT_FOUND` from `namespace` to `catalog.namespace` [spark]

2024-07-10 Thread via GitHub
panbingkun commented on PR #47276: URL: https://github.com/apache/spark/pull/47276#issuecomment-147757 > thanks, merging to master! Thank you for your review. I will fix similar scenarios (when `table` not exist), by adding `catalog name` for `the table` to make it more consis

Re: [PR] [SPARK-48851][SQL] Change the value of `SCHEMA_NOT_FOUND` from `namespace` to `catalog.namespace` [spark]

2024-07-10 Thread via GitHub
cloud-fan closed pull request #47276: [SPARK-48851][SQL] Change the value of `SCHEMA_NOT_FOUND` from `namespace` to `catalog.namespace` URL: https://github.com/apache/spark/pull/47276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] [SPARK-48851][SQL] Change the value of `SCHEMA_NOT_FOUND` from `namespace` to `catalog.namespace` [spark]

2024-07-10 Thread via GitHub
cloud-fan commented on PR #47276: URL: https://github.com/apache/spark/pull/47276#issuecomment-054976 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [SPARK-48851][SQL] Change the value of `SCHEMA_NOT_FOUND` from `namespace` to `catalog.namespace` [spark]

2024-07-10 Thread via GitHub
cloud-fan commented on code in PR #47276: URL: https://github.com/apache/spark/pull/47276#discussion_r1672180189 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala: ## @@ -71,7 +71,9 @@ class SessionCatalog( functionExpressionBuilder: