panbingkun commented on code in PR #43751:
URL: https://github.com/apache/spark/pull/43751#discussion_r1505232316
##
docs/sql-ref-syntax-aux-show-tables.md:
##
@@ -40,12 +40,18 @@ SHOW TABLES [ { FROM | IN } database_name ] [ LIKE
regex_pattern ]
* **regex_pattern**
-
panbingkun commented on code in PR #43751:
URL: https://github.com/apache/spark/pull/43751#discussion_r1505232316
##
docs/sql-ref-syntax-aux-show-tables.md:
##
@@ -40,12 +40,18 @@ SHOW TABLES [ { FROM | IN } database_name ] [ LIKE
regex_pattern ]
* **regex_pattern**
-
panbingkun commented on code in PR #43751:
URL: https://github.com/apache/spark/pull/43751#discussion_r1505253654
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/StringUtils.scala:
##
@@ -107,27 +107,82 @@ object StringUtils extends Logging {
def isFalseStri
panbingkun commented on code in PR #43751:
URL: https://github.com/apache/spark/pull/43751#discussion_r1505263446
##
sql/core/src/test/resources/sql-tests/analyzer-results/show-tables.sql.out:
##
@@ -60,37 +60,37 @@ ShowTables [namespace#x, tableName#x, isTemporary#x]
-- !q
panbingkun commented on code in PR #43751:
URL: https://github.com/apache/spark/pull/43751#discussion_r1505263771
##
sql/core/src/test/resources/sql-tests/analyzer-results/show-views.sql.out:
##
@@ -77,31 +77,31 @@ ShowViewsCommand global_temp, [namespace#x, viewName#x,
isTempo
cloud-fan commented on PR #43751:
URL: https://github.com/apache/spark/pull/43751#issuecomment-1968294284
This is a hard decision. Technically the behavior of LIKE in many commands
(`SHOW TABLES LIKE ...`) relies on the underlying catalog, which can be HMS of
different versions, or a Hive-c
panbingkun commented on code in PR #43751:
URL: https://github.com/apache/spark/pull/43751#discussion_r1505518259
##
sql/core/src/test/scala/org/apache/spark/sql/execution/command/ShowFunctionsSuiteBase.scala:
##
@@ -159,15 +160,18 @@ trait ShowFunctionsSuiteBase extends QueryTe
panbingkun commented on code in PR #43751:
URL: https://github.com/apache/spark/pull/43751#discussion_r1505550273
##
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala:
##
@@ -626,7 +626,12 @@ private[client] class Shim_v2_0 extends Shim with Logging {
panbingkun commented on code in PR #43751:
URL: https://github.com/apache/spark/pull/43751#discussion_r1505561012
##
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/MetadataOperation.java:
##
@@ -57,54 +57,6 @@ public void close() throws HiveSQLExceptio
panbingkun commented on code in PR #43751:
URL: https://github.com/apache/spark/pull/43751#discussion_r1505578877
##
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetFunctionsOperation.scala:
##
@@ -81,7 +87,7 @@ private[hive] class SparkGetFun
panbingkun commented on code in PR #43751:
URL: https://github.com/apache/spark/pull/43751#discussion_r1505581906
##
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExec.scala:
##
@@ -39,7 +39,7 @@ case class ShowTablesExec(
val tables = ca
panbingkun commented on code in PR #43751:
URL: https://github.com/apache/spark/pull/43751#discussion_r1505582663
##
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowNamespacesExec.scala:
##
@@ -53,7 +53,7 @@ case class ShowNamespacesExec(
val row
panbingkun commented on code in PR #43751:
URL: https://github.com/apache/spark/pull/43751#discussion_r1505586754
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/StringUtils.scala:
##
@@ -107,27 +107,82 @@ object StringUtils extends Logging {
def isFalseStri
panbingkun commented on PR #43751:
URL: https://github.com/apache/spark/pull/43751#issuecomment-1968709145
> This is a hard decision. Technically the behavior of LIKE in many commands
(`SHOW TABLES LIKE ...`) relies on the underlying catalog, which can be HMS of
different versions, or a Hiv
14 matches
Mail list logo
