Re: [PR] [WIP][SPARK-47858][SPARK-47852][PYTHON][SQL] Refactoring the structure for DataFrame error context [spark]

2024-04-15 Thread via GitHub
itholic commented on code in PR #46063: URL: https://github.com/apache/spark/pull/46063#discussion_r1566715537 ## python/pyspark/errors/utils.py: ## @@ -119,3 +124,59 @@ def get_message_template(self, error_class: str) -> str: message_template = main_message_templat

Re: [PR] [WIP][SPARK-47858][SPARK-47852][PYTHON][SQL] Refactoring the structure for DataFrame error context [spark]

2024-04-15 Thread via GitHub
itholic commented on code in PR #46063: URL: https://github.com/apache/spark/pull/46063#discussion_r1566715097 ## python/pyspark/sql/tests/test_dataframe.py: ## @@ -1319,6 +1289,9 @@ def test_dataframe_error_context(self): class DataFrameTests(DataFrameTestsMixin, ReusedSQL

Re: [PR] [WIP][SPARK-47858][SPARK-47852][PYTHON][SQL] Refactoring the structure for DataFrame error context [spark]

2024-04-15 Thread via GitHub
zhengruifeng commented on code in PR #46063: URL: https://github.com/apache/spark/pull/46063#discussion_r1566707884 ## python/pyspark/errors/utils.py: ## @@ -119,3 +124,59 @@ def get_message_template(self, error_class: str) -> str: message_template = main_message_te

Re: [PR] [WIP][SPARK-47858][SPARK-47852][PYTHON][SQL] Refactoring the structure for DataFrame error context [spark]

2024-04-15 Thread via GitHub
zhengruifeng commented on code in PR #46063: URL: https://github.com/apache/spark/pull/46063#discussion_r1566706967 ## python/pyspark/sql/tests/test_dataframe.py: ## @@ -1319,6 +1289,9 @@ def test_dataframe_error_context(self): class DataFrameTests(DataFrameTestsMixin, Reus

Re: [PR] [WIP][SPARK-47858][SPARK-47852][PYTHON][SQL] Refactoring the structure for DataFrame error context [spark]

2024-04-15 Thread via GitHub
zhengruifeng commented on code in PR #46063: URL: https://github.com/apache/spark/pull/46063#discussion_r1566705061 ## python/pyspark/errors/utils.py: ## @@ -119,3 +124,59 @@ def get_message_template(self, error_class: str) -> str: message_template = main_message_te

Re: [PR] [WIP][SPARK-47858][SPARK-47852][PYTHON][SQL] Refactoring the structure for DataFrame error context [spark]

2024-04-15 Thread via GitHub
itholic commented on code in PR #46063: URL: https://github.com/apache/spark/pull/46063#discussion_r1566678165 ## sql/api/src/main/scala/org/apache/spark/sql/catalyst/trees/QueryContexts.scala: ## @@ -160,6 +160,8 @@ case class DataFrameQueryContext( val pysparkFragment: Stri

Re: [PR] [WIP][SPARK-47858][SPARK-47852][PYTHON][SQL] Refactoring the structure for DataFrame error context [spark]

2024-04-15 Thread via GitHub
ueshin commented on code in PR #46063: URL: https://github.com/apache/spark/pull/46063#discussion_r1566619646 ## sql/api/src/main/scala/org/apache/spark/sql/catalyst/trees/QueryContexts.scala: ## @@ -160,6 +160,8 @@ case class DataFrameQueryContext( val pysparkFragment: Strin