Re: [PR] [WIP] Add support for java 17 and explicit Python versions from spark 3.5.0 onwards [spark-docker]

2023-10-15 Thread via GitHub
vakarisbk commented on code in PR #56: URL: https://github.com/apache/spark-docker/pull/56#discussion_r1359853632 ## .github/workflows/test.yml: ## @@ -37,12 +37,15 @@ on: - 3.3.0 java: description: 'The Java version of Spark image.' -default: 11

Re: [PR] [WIP] Add support for java 17 and explicit Python versions from spark 3.5.0 onwards [spark-docker]

2023-10-15 Thread via GitHub
vakarisbk commented on code in PR #56: URL: https://github.com/apache/spark-docker/pull/56#discussion_r1359852744 ## 3.5.0/scala2.12-java11-python3-r-ubuntu/Dockerfile: ## @@ -20,7 +20,10 @@ USER root RUN set -ex; \ apt-get update; \ -apt-get install -y python3 pytho

Re: [PR] [WIP] Add support for java 17 and explicit Python versions from spark 3.5.0 onwards [spark-docker]

2023-10-15 Thread via GitHub
vakarisbk commented on code in PR #56: URL: https://github.com/apache/spark-docker/pull/56#discussion_r1359852798 ## add-dockerfiles.sh: ## @@ -44,12 +48,20 @@ for TAG in $TAGS; do if echo $TAG | grep -q "r-"; then OPTS+=" --sparkr" fi + +if echo $TAG

Re: [PR] [WIP] Add support for java 17 and explicit Python versions from spark 3.5.0 onwards [spark-docker]

2023-10-13 Thread via GitHub
Yikun commented on code in PR #56: URL: https://github.com/apache/spark-docker/pull/56#discussion_r1358357340 ## 3.5.0/scala2.12-java11-python3-r-ubuntu/Dockerfile: ## @@ -20,7 +20,10 @@ USER root RUN set -ex; \ apt-get update; \ -apt-get install -y python3 python3-p

Re: [PR] [WIP] Add support for java 17 and explicit Python versions from spark 3.5.0 onwards [spark-docker]

2023-10-13 Thread via GitHub
Yikun commented on code in PR #56: URL: https://github.com/apache/spark-docker/pull/56#discussion_r1358357340 ## 3.5.0/scala2.12-java11-python3-r-ubuntu/Dockerfile: ## @@ -20,7 +20,10 @@ USER root RUN set -ex; \ apt-get update; \ -apt-get install -y python3 python3-p

Re: [PR] [WIP] Add support for java 17 and explicit Python versions from spark 3.5.0 onwards [spark-docker]

2023-10-13 Thread via GitHub
Yikun commented on code in PR #56: URL: https://github.com/apache/spark-docker/pull/56#discussion_r1358361784 ## tools/template.py: ## @@ -59,7 +59,7 @@ def parse_opts(): parser.add_argument( "-j", "--java-version", -help="The Spark version of Dock

Re: [PR] [WIP] Add support for java 17 and explicit Python versions from spark 3.5.0 onwards [spark-docker]

2023-10-13 Thread via GitHub
Yikun commented on code in PR #56: URL: https://github.com/apache/spark-docker/pull/56#discussion_r1358361340 ## .github/workflows/test.yml: ## @@ -37,12 +37,15 @@ on: - 3.3.0 java: description: 'The Java version of Spark image.' -default: 11 +

Re: [PR] [WIP] Add support for java 17 and explicit Python versions from spark 3.5.0 onwards [spark-docker]

2023-10-13 Thread via GitHub
Yikun commented on code in PR #56: URL: https://github.com/apache/spark-docker/pull/56#discussion_r1358359041 ## add-dockerfiles.sh: ## @@ -44,12 +48,20 @@ for TAG in $TAGS; do if echo $TAG | grep -q "r-"; then OPTS+=" --sparkr" fi + +if echo $TAG | gr