dbatomic opened a new pull request, #44537:
URL: https://github.com/apache/spark/pull/44537
# Rough POC for collations in Spark
## High level changes
- Collation suite that test currently supported features (start with this
file).
- Global, singleton `CollatorFactory`. For given
github-actions[bot] commented on PR #44537:
URL: https://github.com/apache/spark/pull/44537#issuecomment-2130548277
We're closing this PR because it hasn't been updated in a while. This isn't
a judgement on the merit of the PR in any way. It's just a way of keeping the
PR queue manageable.
github-actions[bot] closed pull request #44537: Collations proof of concept
URL: https://github.com/apache/spark/pull/44537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
milastdbx commented on code in PR #44537:
URL: https://github.com/apache/spark/pull/44537#discussion_r1441518135
##
sql/core/src/main/scala/org/apache/spark/sql/execution/dynamicpruning/PartitionPruning.scala:
##
@@ -207,14 +208,20 @@ object PartitionPruning extends Rule[Logical
dbatomic commented on code in PR #44537:
URL: https://github.com/apache/spark/pull/44537#discussion_r1441563199
##
sql/core/src/main/scala/org/apache/spark/sql/execution/dynamicpruning/PartitionPruning.scala:
##
@@ -207,14 +208,20 @@ object PartitionPruning extends Rule[LogicalP
stefankandic commented on code in PR #44537:
URL: https://github.com/apache/spark/pull/44537#discussion_r1457159311
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -1390,8 +1497,13 @@ public UTF8String copy() {
@Override
public int com
stefankandic commented on code in PR #44537:
URL: https://github.com/apache/spark/pull/44537#discussion_r1457160277
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -1401,10 +1513,17 @@ public int compare(final UTF8String other) {
@Override
stefankandic commented on code in PR #44537:
URL: https://github.com/apache/spark/pull/44537#discussion_r1466438453
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ToStringBase.scala:
##
@@ -256,11 +258,11 @@ trait ToStringBase { self: UnaryExpression wi
stefankandic commented on code in PR #44537:
URL: https://github.com/apache/spark/pull/44537#discussion_r1470942382
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ToStringBase.scala:
##
@@ -231,11 +232,12 @@ trait ToStringBase { self: UnaryExpression wi
