Re: [PR] [SPARK-46249][SS] Require instance lock for acquiring RocksDB metrics to prevent race with background operations [spark]

2023-12-04 Thread via GitHub
HeartSaVioR closed pull request #44165: [SPARK-46249][SS] Require instance lock for acquiring RocksDB metrics to prevent race with background operations URL: https://github.com/apache/spark/pull/44165 -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] [SPARK-46249][SS] Require instance lock for acquiring RocksDB metrics to prevent race with background operations [spark]

2023-12-04 Thread via GitHub
HeartSaVioR commented on PR #44165: URL: https://github.com/apache/spark/pull/44165#issuecomment-1840065025 Thanks! Merging to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-46249][SS] Require instance lock for acquiring RocksDB metrics to prevent race with background operations [spark]

2023-12-04 Thread via GitHub
HeartSaVioR commented on PR #44165: URL: https://github.com/apache/spark/pull/44165#issuecomment-1840064037 This only failed in docker integration test suite which is unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [SPARK-46249][SS] Require instance lock for acquiring RocksDB metrics to prevent race with background operations [spark]

2023-12-04 Thread via GitHub
anishshri-db commented on code in PR #44165: URL: https://github.com/apache/spark/pull/44165#discussion_r1414826922 ## sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreSuite.scala: ## @@ -131,19 +131,21 @@ class RocksDBStateStoreSuite exten

Re: [PR] [SPARK-46249][SS] Require instance lock for acquiring RocksDB metrics to prevent race with background operations [spark]

2023-12-04 Thread via GitHub
HeartSaVioR commented on code in PR #44165: URL: https://github.com/apache/spark/pull/44165#discussion_r1414814387 ## sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreSuite.scala: ## @@ -131,19 +131,21 @@ class RocksDBStateStoreSuite extend

Re: [PR] [SPARK-46249][SS] Require instance lock for acquiring RocksDB metrics to prevent race with background operations [spark]

2023-12-04 Thread via GitHub
anishshri-db commented on code in PR #44165: URL: https://github.com/apache/spark/pull/44165#discussion_r1414787796 ## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala: ## @@ -137,6 +137,10 @@ class RocksDB( @volatile private var numKeysOnW

Re: [PR] [SPARK-46249][SS] Require instance lock for acquiring RocksDB metrics to prevent race with background operations [spark]

2023-12-04 Thread via GitHub
HeartSaVioR commented on code in PR #44165: URL: https://github.com/apache/spark/pull/44165#discussion_r1414783355 ## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala: ## @@ -137,6 +137,10 @@ class RocksDB( @volatile private var numKeysOnWr

Re: [PR] [SPARK-46249][SS] Require instance lock for acquiring RocksDB metrics to prevent race with background operations [spark]

2023-12-04 Thread via GitHub
anishshri-db commented on PR #44165: URL: https://github.com/apache/spark/pull/44165#issuecomment-1839490380 cc - @HeartSaVioR - PTAL, thx ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp