Re: [PR] [SPARK-48146][SQL] Fix aggregate function in With expression child assertion [spark]

2024-05-10 Thread via GitHub
kelvinjian-db commented on code in PR #46443: URL: https://github.com/apache/spark/pull/46443#discussion_r1597045459 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/With.scala: ## @@ -92,6 +95,21 @@ object With { val commonExprRefs =

Re: [PR] [SPARK-48146][SQL] Fix aggregate function in With expression child assertion [spark]

2024-05-10 Thread via GitHub
cloud-fan closed pull request #46443: [SPARK-48146][SQL] Fix aggregate function in With expression child assertion URL: https://github.com/apache/spark/pull/46443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [SPARK-48146][SQL] Fix aggregate function in With expression child assertion [spark]

2024-05-10 Thread via GitHub
cloud-fan commented on PR #46443: URL: https://github.com/apache/spark/pull/46443#issuecomment-2104728640 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-48146][SQL] Fix aggregate function in With expression child assertion [spark]

2024-05-10 Thread via GitHub
cloud-fan commented on code in PR #46443: URL: https://github.com/apache/spark/pull/46443#discussion_r1596840882 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/With.scala: ## @@ -92,6 +95,21 @@ object With { val commonExprRefs =

Re: [PR] [SPARK-48146][SQL] Fix aggregate function in With expression child assertion [spark]

2024-05-10 Thread via GitHub
cloud-fan commented on code in PR #46443: URL: https://github.com/apache/spark/pull/46443#discussion_r1596840882 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/With.scala: ## @@ -92,6 +95,21 @@ object With { val commonExprRefs =

Re: [PR] [SPARK-48146][SQL] Fix aggregate function in With expression child assertion [spark]

2024-05-09 Thread via GitHub
kelvinjian-db commented on code in PR #46443: URL: https://github.com/apache/spark/pull/46443#discussion_r1595803069 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/With.scala: ## @@ -92,6 +95,26 @@ object With { val commonExprRefs =

Re: [PR] [SPARK-48146][SQL] Fix aggregate function in With expression child assertion [spark]

2024-05-09 Thread via GitHub
kelvinjian-db commented on code in PR #46443: URL: https://github.com/apache/spark/pull/46443#discussion_r1595796862 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/With.scala: ## @@ -92,6 +95,26 @@ object With { val commonExprRefs =

Re: [PR] [SPARK-48146][SQL] Fix aggregate function in With expression child assertion [spark]

2024-05-08 Thread via GitHub
cloud-fan commented on code in PR #46443: URL: https://github.com/apache/spark/pull/46443#discussion_r1594911102 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/With.scala: ## @@ -92,6 +95,26 @@ object With { val commonExprRefs =