[GitHub] spark pull request: [SPARK-15296][MLlib] Refactor All Java Tests t...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13101#issuecomment-219910742 **[Test build #58737 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58737/consoleFull)** for PR 13101 at commit [`f3fa1f5`](https://gi

[GitHub] spark pull request: [SPARK-15345][SQL][PYSPARK]. SparkSession's co...

2016-05-17 Thread zjffdu
Github user zjffdu commented on the pull request: https://github.com/apache/spark/pull/13160#issuecomment-219910757 Changing sql conf setting seems a better approach. Besides that some other setting in SparkSession#Build also won't take effect if there's already an existing SparkConte

[GitHub] spark pull request: [SPARK-15345][SQL][PYSPARK]. SparkSession's co...

2016-05-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13160#issuecomment-219911211 logging a warning seems like a good idea! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] spark pull request: [SPARK-15031][EXAMPLES][FOLLOW-UP] Make Python...

2016-05-17 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/13135#discussion_r63638222 --- Diff: examples/src/main/python/ml/simple_params_example.py --- @@ -36,18 +35,20 @@ if len(sys.argv) > 1: --- End diff -- It see

[GitHub] spark pull request: [SPARK-8603] [sparkR] In windows, Incorrect fi...

2016-05-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/7025#discussion_r63638336 --- Diff: R/pkg/R/client.R --- @@ -42,6 +42,19 @@ determineSparkSubmitBin <- function() { } sparkSubmitBinName } +# R supports both

[GitHub] spark pull request: [SPARK-15031][EXAMPLES][FOLLOW-UP] Make Python...

2016-05-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13135#discussion_r63638465 --- Diff: examples/src/main/python/ml/simple_params_example.py --- @@ -36,18 +35,20 @@ if len(sys.argv) > 1: --- End diff -- Hm.. Is

[GitHub] spark pull request: [SPARK-15031][EXAMPLES][FOLLOW-UP] Make Python...

2016-05-17 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/13135#discussion_r63638842 --- Diff: examples/src/main/python/ml/simple_params_example.py --- @@ -36,18 +35,20 @@ if len(sys.argv) > 1: --- End diff -- This c

[GitHub] spark pull request: [SPARK-15375][SQL][Streaming] Add ConsoleSink ...

2016-05-17 Thread jerryshao
GitHub user jerryshao opened a pull request: https://github.com/apache/spark/pull/13162 [SPARK-15375][SQL][Streaming] Add ConsoleSink to structure streaming ## What changes were proposed in this pull request? Add ConsoleSink to structure streaming, user could use it to displ

[GitHub] spark pull request: [SPARK-15375][SQL][Streaming] Add ConsoleSink ...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13162#issuecomment-219914340 **[Test build #58738 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58738/consoleFull)** for PR 13162 at commit [`235f5d2`](https://gi

[GitHub] spark pull request: [SPARK-15342][SQL][PySpark] PySpark test for n...

2016-05-17 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/13134#issuecomment-219914749 cc @davies Please take a look, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] spark pull request: [SPARK-13081][PYSPARK][SPARK_SUBMIT]. Allow se...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13146#issuecomment-219914744 **[Test build #58732 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58732/consoleFull)** for PR 13146 at commit [`305125d`](https://g

[GitHub] spark pull request: [SPARK-13081][PYSPARK][SPARK_SUBMIT]. Allow se...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13146#issuecomment-219914888 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13081][PYSPARK][SPARK_SUBMIT]. Allow se...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13146#issuecomment-219914887 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15296][MLlib] Refactor All Java Tests t...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13101#issuecomment-219915297 **[Test build #58737 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58737/consoleFull)** for PR 13101 at commit [`f3fa1f5`](https://g

[GitHub] spark pull request: [SPARK-15296][MLlib] Refactor All Java Tests t...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13101#issuecomment-219915350 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15296][MLlib] Refactor All Java Tests t...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13101#issuecomment-219915352 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15031][EXAMPLES][FOLLOW-UP] Make Python...

2016-05-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13135#discussion_r63640687 --- Diff: examples/src/main/python/ml/simple_params_example.py --- @@ -36,18 +35,20 @@ if len(sys.argv) > 1: --- End diff -- I see..

[GitHub] spark pull request: [SPARK-15031][EXAMPLES][FOLLOW-UP] Make Python...

2016-05-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13135#discussion_r63640828 --- Diff: examples/src/main/python/ml/simple_params_example.py --- @@ -36,18 +35,20 @@ if len(sys.argv) > 1: --- End diff -- @yanbol

[GitHub] spark pull request: [SPARK-15334][SQL] HiveClient facade not compa...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13127#issuecomment-219918225 **[Test build #58739 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58739/consoleFull)** for PR 13127 at commit [`3d694df`](https://gi

[GitHub] spark pull request: [SPARK-15334][SQL] HiveClient facade not compa...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13127#issuecomment-219918389 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15334][SQL] HiveClient facade not compa...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13127#issuecomment-219918386 **[Test build #58739 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58739/consoleFull)** for PR 13127 at commit [`3d694df`](https://g

[GitHub] spark pull request: [SPARK-15334][SQL] HiveClient facade not compa...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13127#issuecomment-219918387 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15367] [SQL] Add refreshTable back

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13156#issuecomment-219918792 **[Test build #58740 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58740/consoleFull)** for PR 13156 at commit [`4ac3b76`](https://gi

[GitHub] spark pull request: [SPARK-15192][SQL] null check for SparkSession...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13008#issuecomment-219920209 **[Test build #58741 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58741/consoleFull)** for PR 13008 at commit [`57efddb`](https://gi

[GitHub] spark pull request: [SPARK-14851] [Core] Support radix sort with n...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13161#issuecomment-219920955 **[Test build #58735 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58735/consoleFull)** for PR 13161 at commit [`7d29dc3`](https://g

[GitHub] spark pull request: [SPARK-14851] [Core] Support radix sort with n...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13161#issuecomment-219921049 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14851] [Core] Support radix sort with n...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13161#issuecomment-219921050 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15339] [ML] ML 2.0 QA: Scala APIs and c...

2016-05-17 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13129#discussion_r63643069 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala --- @@ -252,7 +250,7 @@ class LinearRegression @Since("1.3.0") (@Sinc

[GitHub] spark pull request: [SPARK-15367] [SQL] Add refreshTable back

2016-05-17 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/13156#discussion_r63643173 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala --- @@ -622,7 +622,7 @@ class MetastoreDataSourcesSuite extends Q

[GitHub] spark pull request: [SPARK-15031][EXAMPLES][FOLLOW-UP] Make Python...

2016-05-17 Thread MLnick
Github user MLnick commented on the pull request: https://github.com/apache/spark/pull/13135#issuecomment-219922114 @HyukjinKwon ah right, of course. I forgot the params get set during `fit` in Python. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] spark pull request: [SPARK-15339] [ML] ML 2.0 QA: Scala APIs and c...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13129#issuecomment-219922177 **[Test build #58742 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58742/consoleFull)** for PR 13129 at commit [`374e610`](https://gi

[GitHub] spark pull request: [SPARK-14851] [Core] Support radix sort with n...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13161#issuecomment-21990 **[Test build #58736 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58736/consoleFull)** for PR 13161 at commit [`77d7b17`](https://g

[GitHub] spark pull request: [SPARK-14851] [Core] Support radix sort with n...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13161#issuecomment-219922326 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15031][EXAMPLES][FOLLOW-UP] Make Python...

2016-05-17 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/13135#discussion_r63643565 --- Diff: examples/src/main/python/ml/simple_params_example.py --- @@ -36,18 +35,20 @@ if len(sys.argv) > 1: --- End diff -- We're moving

[GitHub] spark pull request: [SPARK-14851] [Core] Support radix sort with n...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13161#issuecomment-219922327 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15375][SQL][Streaming] Add ConsoleSink ...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13162#issuecomment-219922548 **[Test build #58738 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58738/consoleFull)** for PR 13162 at commit [`235f5d2`](https://g

[GitHub] spark pull request: [SPARK-15375][SQL][Streaming] Add ConsoleSink ...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13162#issuecomment-219922683 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15375][SQL][Streaming] Add ConsoleSink ...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13162#issuecomment-219922682 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15367] [SQL] Add refreshTable back

2016-05-17 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13156#discussion_r63644169 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala --- @@ -622,7 +622,7 @@ class MetastoreDataSourcesSuite exten

[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13148#issuecomment-219923723 **[Test build #58743 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58743/consoleFull)** for PR 13148 at commit [`c0f3bf7`](https://gi

[GitHub] spark pull request: [SPARK-15339] [ML] ML 2.0 QA: Scala APIs and c...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13129#issuecomment-219924209 **[Test build #58744 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58744/consoleFull)** for PR 13129 at commit [`d38b1eb`](https://gi

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...

2016-05-17 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/12836#issuecomment-219925061 I mean is it too simple to allow grouping by columns only - what if after grouped by columns the dataset is too large to fit in memory? What if we are to support

[GitHub] spark pull request: [SPARK-15031][EXAMPLES][FOLLOW-UP] Make Python...

2016-05-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13135#discussion_r63644923 --- Diff: examples/src/main/python/ml/simple_params_example.py --- @@ -36,18 +35,20 @@ if len(sys.argv) > 1: --- End diff -- Thank y

[GitHub] spark pull request: [SPARK-15031][EXAMPLES][FOLLOW-UP] Make Python...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13135#issuecomment-219925856 **[Test build #58745 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58745/consoleFull)** for PR 13135 at commit [`bb88635`](https://gi

[GitHub] spark pull request: [SPARK-15339] [ML] ML 2.0 QA: Scala APIs and c...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13129#issuecomment-219926031 **[Test build #58742 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58742/consoleFull)** for PR 13129 at commit [`374e610`](https://g

[GitHub] spark pull request: [SPARK-15339] [ML] ML 2.0 QA: Scala APIs and c...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13129#issuecomment-219926097 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15339] [ML] ML 2.0 QA: Scala APIs and c...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13129#issuecomment-219926099 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15031][EXAMPLES][FOLLOW-UP] Make Python...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13135#issuecomment-219926703 **[Test build #58745 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58745/consoleFull)** for PR 13135 at commit [`bb88635`](https://g

[GitHub] spark pull request: [SPARK-15031][EXAMPLES][FOLLOW-UP] Make Python...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13135#issuecomment-219926748 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15031][EXAMPLES][FOLLOW-UP] Make Python...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13135#issuecomment-219926751 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15075] [SQL] Cleanup dependencies betwe...

2016-05-17 Thread dilipbiswal
Github user dilipbiswal commented on the pull request: https://github.com/apache/spark/pull/13102#issuecomment-219927191 cc @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-15075] [SQL] Cleanup dependencies betwe...

2016-05-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13102#issuecomment-219927672 Sorry this is not what I meant in the JIRA ticket. What I meant was that we should just save SparkSessions, and then SQLContext calls into that. I didn't mean to literall

[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13148#issuecomment-219927963 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13148#issuecomment-219927902 **[Test build #58743 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58743/consoleFull)** for PR 13148 at commit [`c0f3bf7`](https://g

[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13148#issuecomment-219927964 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15367] [SQL] Add refreshTable back

2016-05-17 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13156#discussion_r63646713 --- Diff: sql/hivecontext-compatibility/src/test/scala/org/apache/spark/sql/hive/HiveContextCompatibilitySuite.scala --- @@ -99,4 +105,41 @@ class HiveCon

[GitHub] spark pull request: [SPARK-15339] [ML] ML 2.0 QA: Scala APIs and c...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13129#issuecomment-219928428 **[Test build #58744 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58744/consoleFull)** for PR 13129 at commit [`d38b1eb`](https://g

[GitHub] spark pull request: [SPARK-15339] [ML] ML 2.0 QA: Scala APIs and c...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13129#issuecomment-219928499 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15339] [ML] ML 2.0 QA: Scala APIs and c...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13129#issuecomment-219928497 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15192][SQL] null check for SparkSession...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13008#issuecomment-219929172 **[Test build #58741 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58741/consoleFull)** for PR 13008 at commit [`57efddb`](https://g

[GitHub] spark pull request: [SPARK-15192][SQL] null check for SparkSession...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13008#issuecomment-219929253 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15192][SQL] null check for SparkSession...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13008#issuecomment-219929255 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15367] [SQL] Add refreshTable back

2016-05-17 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13156#discussion_r63647706 --- Diff: sql/hivecontext-compatibility/src/test/scala/org/apache/spark/sql/hive/HiveContextCompatibilitySuite.scala --- @@ -99,4 +105,41 @@ class HiveCo

[GitHub] spark pull request: [SPARK-15205][SQL][WIP] Codegen can compile th...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12979#issuecomment-219930465 **[Test build #58746 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58746/consoleFull)** for PR 12979 at commit [`4cb5ed3`](https://gi

[GitHub] spark pull request: [SPARK-15367] [SQL] Add refreshTable back

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13156#issuecomment-219931325 **[Test build #58740 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58740/consoleFull)** for PR 13156 at commit [`4ac3b76`](https://g

[GitHub] spark pull request: [SPARK-15367] [SQL] Add refreshTable back

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13156#issuecomment-219931474 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15367] [SQL] Add refreshTable back

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13156#issuecomment-219931477 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15165][SQL] Codegen can break because t...

2016-05-17 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/12939#issuecomment-219931480 Lots of punctuation characters like `*`, `+` can be used as an operator in expressions so I'm afraid comments in generated code will be difficult to read if characters

[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...

2016-05-17 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-219931535 cc @andrewor14 @zsxwing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-15165][SQL] Codegen can break because t...

2016-05-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12939#issuecomment-219931861 We can just expand the whitelist and add * + and such into that can't we? My main worry is that security is very difficult to get right, and having a whitelist substantial

[GitHub] spark pull request: [SPARK-15205][SQL] Codegen can compile the sam...

2016-05-17 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/12979#issuecomment-219932274 @sarutak It's expected to compile twice on two different queries, it does not worth to optimize this corner case (ideally it should generate different source code even w

[GitHub] spark pull request: [SPARK-15165][SQL] Codegen can break because t...

2016-05-17 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/12939#issuecomment-219932692 O.K. Initially we add some characters to the whitelist and if we need some more characters, we'll consider whether it should be add or not at any time. How about this

[GitHub] spark pull request: [SPARK-15334][SQL] HiveClient facade not compa...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13127#issuecomment-219933026 **[Test build #58747 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58747/consoleFull)** for PR 13127 at commit [`14ade4a`](https://gi

[GitHub] spark pull request: [SPARK-15165][SQL] Codegen can break because t...

2016-05-17 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/12939#issuecomment-219933074 @rxin If there is any new bug found on this, we could switch to white list, otherwise I'd like to have the current solution. --- If your project is set up for it, you c

[GitHub] spark pull request: [SPARK-15165][SQL] Codegen can break because t...

2016-05-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12939#issuecomment-219933348 @davies this is the 2nd security bug with codegen we found already. @sarutak sgtm. --- If your project is set up for it, you can reply to this email and have you

[GitHub] spark pull request: [SPARK-15165][SQL] Codegen can break because t...

2016-05-17 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/12939#issuecomment-219934463 @sarutak That's true. Should `/` also be common used? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-15334][SQL] HiveClient facade not compa...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13127#issuecomment-219935041 **[Test build #58748 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58748/consoleFull)** for PR 13127 at commit [`4494c43`](https://gi

[GitHub] spark pull request: [SPARK-15165][SQL] Codegen can break because t...

2016-05-17 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/12939#issuecomment-219935334 Either way works for me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-15370] [SQL] Update RewriteCorrelatedSc...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13155#issuecomment-219936663 **[Test build #2990 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2990/consoleFull)** for PR 13155 at commit [`76d9f45`](https://g

[GitHub] spark pull request: [SPARK-14978][PySpark] PySpark TrainValidation...

2016-05-17 Thread MLnick
Github user MLnick commented on the pull request: https://github.com/apache/spark/pull/12767#issuecomment-219936689 Merged to master/branch-2.0. Thanks @vectorijk @holdenk @sethah for the review! --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] spark pull request: [SPARK-14978][PySpark] PySpark TrainValidation...

2016-05-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12767 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-14978][PySpark] PySpark TrainValidation...

2016-05-17 Thread MLnick
Github user MLnick commented on the pull request: https://github.com/apache/spark/pull/12767#issuecomment-219937205 @taku-k please provide your JIRA username so I can assign the ticket to you. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-15370] [SQL] Update RewriteCorrelatedSc...

2016-05-17 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13155#discussion_r63651907 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1648,16 +1648,56 @@ object RewriteCorrelatedScalarS

[GitHub] spark pull request: [SPARK-15370] [SQL] Update RewriteCorrelatedSc...

2016-05-17 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13155#discussion_r63651882 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1648,16 +1648,56 @@ object RewriteCorrelatedScalarS

[GitHub] spark pull request: [SPARK-15370] [SQL] Update RewriteCorrelatedSc...

2016-05-17 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13155#discussion_r63651943 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1648,16 +1648,56 @@ object RewriteCorrelatedScalarS

[GitHub] spark pull request: [SPARK-11827] [SQL] Adding java.math.BigIntege...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10125#issuecomment-219938017 **[Test build #58749 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58749/consoleFull)** for PR 10125 at commit [`9aa8c25`](https://gi

[GitHub] spark pull request: [SPARK-6320][SQL] Move planLater method into G...

2016-05-17 Thread ueshin
Github user ueshin commented on the pull request: https://github.com/apache/spark/pull/13147#issuecomment-219938062 @marmbrus Thank you for your comments. I see but apparently we are lacking the `planLater` functionality for extra strategies. Could you give me the earlier proto

[GitHub] spark pull request: [SPARK-14978][PySpark] PySpark TrainValidation...

2016-05-17 Thread taku-k
Github user taku-k commented on the pull request: https://github.com/apache/spark/pull/12767#issuecomment-219938151 @MLnick Thanks! My JIRA username is `taku-k`. It's the same as the github username. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] spark pull request: [SPARK-15165][SQL] Codegen can break because t...

2016-05-17 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/12939#issuecomment-219938986 `/` is used as the division operator and `*` is used as the multiplication operator so it's good to add those characters but we should `*/` so we need to add `\*(?!/)`

[GitHub] spark pull request: [SPARK-15334][SQL] HiveClient facade not compa...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13127#issuecomment-219940202 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15334][SQL] HiveClient facade not compa...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13127#issuecomment-219940081 **[Test build #58747 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58747/consoleFull)** for PR 13127 at commit [`14ade4a`](https://g

[GitHub] spark pull request: [SPARK-15334][SQL] HiveClient facade not compa...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13127#issuecomment-219940203 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-17 Thread tejasapatil
Github user tejasapatil commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-219941867 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

<    1   2   3   4   5   6