Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14638#discussion_r90098551
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala ---
@@ -122,10 +126,20 @@ class HadoopTableReader(
val attrsWithIndex =
Github user wangmiao1981 commented on the issue:
https://github.com/apache/spark/pull/15910
@yanboliang @felixcheung I am back from vacation and made changes according
to your comments.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
r
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14638#discussion_r90098793
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala ---
@@ -122,10 +126,20 @@ class HadoopTableReader(
val attrsWithIndex =
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15975#discussion_r90098792
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -76,9 +76,6 @@ class JDBCOptions(
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16064
**[Test build #69344 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69344/consoleFull)**
for PR 16064 at commit
[`7040089`](https://github.com/apache/spark/commit/7
Github user nsyca commented on a diff in the pull request:
https://github.com/apache/spark/pull/16044#discussion_r90100457
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -932,7 +932,7 @@ object PushPredicateThroughJoin extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14638#discussion_r90101517
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala ---
@@ -122,10 +126,20 @@ class HadoopTableReader(
val attrsWith
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15979
FWIW I don't think we should call it nonflat.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/16048
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, o
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16048
**[Test build #69345 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69345/consoleFull)**
for PR 16048 at commit
[`9ff2ed4`](https://github.com/apache/spark/commit/9
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15982
**[Test build #69337 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69337/consoleFull)**
for PR 15982 at commit
[`2e03ee6`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15982
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69337/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15982
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16064
**[Test build #69344 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69344/consoleFull)**
for PR 16064 at commit
[`7040089`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16064
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16064
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69344/
Test PASSed.
---
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/15924#discussion_r90090753
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala
---
@@ -129,48 +129,18 @@ class HDFSMetadataLog[T <: AnyRe
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15954#discussion_r90108129
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamTest.scala ---
@@ -669,55 +658,48 @@ trait StreamTest extends QueryTest with
SharedSQLCo
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15954
**[Test build #69346 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69346/consoleFull)**
for PR 15954 at commit
[`d9d8f82`](https://github.com/apache/spark/commit/d
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/16038
Without understanding the specifics of the ML part here - wont the actual
impact of a large dense vector on Task 'bytes' be minimal at best ?
We do compress the task binary; and 1B zero's should
GitHub user markhamstra opened a pull request:
https://github.com/apache/spark/pull/16065
[SPARK-17064][SQL] Changed ExchangeCoordinator re-partitioning to avoid
additional data â¦
## What changes were proposed in this pull request?
Re-partitioning logic in ExchangeCoordin
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15924
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16065
**[Test build #69347 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69347/consoleFull)**
for PR 16065 at commit
[`561fcf6`](https://github.com/apache/spark/commit/5
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/16063#discussion_r90110048
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -482,21 +482,6 @@ object TypeCoercion {
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/16065
Wrong JIRA ticket?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/16065
@rxin fixed it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, o
Github user squito commented on the issue:
https://github.com/apache/spark/pull/15505
I agree with Kay that putting in a smaller change first is better, assuming
it still has the performance gains. That doesn't preclude any further
optimizations that are bigger changes.
I'm
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15982
**[Test build #69348 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69348/consoleFull)**
for PR 15982 at commit
[`8ac9276`](https://github.com/apache/spark/commit/8
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15954#discussion_r90112136
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQuery.scala ---
@@ -38,11 +40,11 @@ trait StreamingQuery {
def name: String
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14638#discussion_r90112125
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala ---
@@ -113,6 +113,10 @@ class HadoopTableReader(
val tablePath =
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/16066
[SPARK-18632][SQL] AggregateFunction should not implement
ImplicitCastInputTypes
## What changes were proposed in this pull request?
`AggregateFunction` currently implements `ImplicitCastInp
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16066
**[Test build #69349 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69349/consoleFull)**
for PR 16066 at commit
[`9a722cf`](https://github.com/apache/spark/commit/9
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16066
cc @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/16065
cc @yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16066#discussion_r90114430
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Last.scala
---
@@ -56,6 +52,20 @@ case class Last(child: Expression,
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/16066
LGTM other than that tiny comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r90114390
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
---
@@ -408,14 +411,18 @@ class HiveCommandSuite extends QueryTes
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r90092813
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -922,6 +923,29 @@ private[spark] class HiveExternalCatalog(conf:
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r90103384
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -189,11 +189,28 @@ abstract class ExternalCatalog {
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r90092477
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -922,6 +923,29 @@ private[spark] class HiveExternalCatalog(conf:
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r90097773
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -482,6 +482,19 @@ class InMemoryCatalog(
}
Github user ericl commented on the issue:
https://github.com/apache/spark/pull/15998
* looks good once InMemoryCatalog is fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15877
Thanks - I'm going to merge this in master. I will submit a follow-up PR to
simplify this a little bit, and remove the handling of float/double/decimal
types and require explicit user action on how to
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15877
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16063
**[Test build #69343 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69343/consoleFull)**
for PR 16063 at commit
[`7596b5a`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16063
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69343/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16063
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16062
**[Test build #69340 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69340/consoleFull)**
for PR 16062 at commit
[`30c5d6f`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16062
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16062
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69340/
Test PASSed.
---
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/16067
[SPARK-17897] [SQL] Fixed IsNotNull Inference Rule
### What changes were proposed in this pull request?
The `constraints` of an operator is the expressions that evaluate to `true`
for all th
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16048
**[Test build #69351 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69351/consoleFull)**
for PR 16048 at commit
[`27102eb`](https://github.com/apache/spark/commit/2
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16067
**[Test build #69350 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69350/consoleFull)**
for PR 16067 at commit
[`0722ae5`](https://github.com/apache/spark/commit/0
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16044
**[Test build #69341 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69341/consoleFull)**
for PR 16044 at commit
[`d4002c7`](https://github.com/apache/spark/commit/
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16009#discussion_r90120095
--- Diff: docs/ml-features.md ---
@@ -1188,7 +1188,9 @@ categorical features. The number of bins is set by
the `numBuckets` parameter. I
that the number
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16044
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69341/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16044
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15877
Hey guys - after looking at the pr more, I'm afraid we have gone overboard
with testing here. Most of the test cases written are just repeating each other
and doing exactly the same thing. For testing
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15954
**[Test build #69352 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69352/consoleFull)**
for PR 15954 at commit
[`aa8af9c`](https://github.com/apache/spark/commit/a
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15877#discussion_r90122127
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountMinSketchAggSuite.scala
---
@@ -0,0 +1,320 @@
+/*
+ * Li
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14638#discussion_r90123854
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala ---
@@ -113,6 +113,10 @@ class HadoopTableReader(
val tabl
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/15946
@lw-lin could you close this one please? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15954
**[Test build #69353 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69353/consoleFull)**
for PR 15954 at commit
[`c11d2e5`](https://github.com/apache/spark/commit/c
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15780
**[Test build #69342 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69342/consoleFull)**
for PR 15780 at commit
[`39e4930`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15780
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69342/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15780
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15954
**[Test build #69352 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69352/consoleFull)**
for PR 15954 at commit
[`aa8af9c`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15954
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69352/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15954
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/15982#discussion_r90127514
--- Diff:
core/src/test/java/org/apache/spark/unsafe/map/AbstractBytesToBytesMapSuite.java
---
@@ -75,13 +75,6 @@
@Mock(answer = RETURNS_SMART_NULLS)
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/15982#discussion_r90126726
--- Diff:
core/src/test/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriterSuite.java
---
@@ -40,9 +41,11 @@
import org.mockito.stubbing.Answer;
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/15982#discussion_r90121766
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriter.java ---
@@ -337,42 +340,47 @@ void forceSorterToSpill() throws IOException {
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/15982#discussion_r90127615
--- Diff:
core/src/test/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorterSuite.java
---
@@ -86,14 +88,7 @@ public int compare(
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/16065
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15954
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15954
**[Test build #69353 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69353/consoleFull)**
for PR 15954 at commit
[`c11d2e5`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15954
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69353/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16067
**[Test build #69354 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69354/consoleFull)**
for PR 16067 at commit
[`f693040`](https://github.com/apache/spark/commit/f
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/15861#discussion_r90129155
--- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala
---
@@ -1089,66 +1064,10 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)])
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/15861#discussion_r90116879
--- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala
---
@@ -1016,11 +1013,6 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)])
/
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/15861#discussion_r88075283
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/HadoopMapRedCommitProtocol.scala
---
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Soft
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/15861#discussion_r90122251
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/SparkHadoopWriter.scala ---
@@ -0,0 +1,408 @@
+/*
+ * Licensed to the Apache Software Foun
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/15861#discussion_r90121527
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/SparkHadoopWriter.scala ---
@@ -0,0 +1,408 @@
+/*
+ * Licensed to the Apache Software Foun
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/15861#discussion_r90120144
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/SparkHadoopWriter.scala ---
@@ -0,0 +1,408 @@
+/*
+ * Licensed to the Apache Software Foun
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/15861#discussion_r90127987
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/SparkHadoopWriter.scala ---
@@ -0,0 +1,408 @@
+/*
+ * Licensed to the Apache Software Foun
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/15861#discussion_r90129259
--- Diff:
core/src/test/scala/org/apache/spark/rdd/PairRDDFunctionsSuite.scala ---
@@ -561,7 +561,7 @@ class PairRDDFunctionsSuite extends SparkFunSuite with
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/15861#discussion_r88077635
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/SparkHadoopWriter.scala ---
@@ -0,0 +1,408 @@
+/*
+ * Licensed to the Apache Software Foun
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/15861#discussion_r90121670
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/SparkHadoopWriter.scala ---
@@ -0,0 +1,408 @@
+/*
+ * Licensed to the Apache Software Foun
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/15861#discussion_r87708046
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/SparkHadoopWriter.scala ---
@@ -0,0 +1,408 @@
+/*
+ * Licensed to the Apache Software Foun
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/15861#discussion_r90119536
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/SparkHadoopWriter.scala ---
@@ -0,0 +1,408 @@
+/*
+ * Licensed to the Apache Software Foun
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/15861#discussion_r90124359
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/SparkHadoopWriter.scala ---
@@ -0,0 +1,408 @@
+/*
+ * Licensed to the Apache Software Foun
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/15861
@jiangxb1987 I did a single pass review - particularly given the
similarities in both the codepaths and the classnames, I will need to go over
it again to ensure we dont miss anything.
---
If your
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15954
**[Test build #69355 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69355/consoleFull)**
for PR 15954 at commit
[`69d9b4a`](https://github.com/apache/spark/commit/6
Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/15954#discussion_r90130320
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQuery.scala ---
@@ -64,23 +68,26 @@ trait StreamingQuery {
/**
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16066
**[Test build #69356 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69356/consoleFull)**
for PR 16066 at commit
[`1246792`](https://github.com/apache/spark/commit/1
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15255
**[Test build #69357 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69357/consoleFull)**
for PR 15255 at commit
[`57817a1`](https://github.com/apache/spark/commit/5
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16048
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16048
**[Test build #69345 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69345/consoleFull)**
for PR 16048 at commit
[`9ff2ed4`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16048
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69345/
Test FAILed.
---
Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/15954#discussion_r90132677
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala
---
@@ -59,13 +62,20 @@ class StreamingQueryManager private[sql]
301 - 400 of 671 matches
Mail list logo
