Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19192
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19193
**[Test build #81644 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81644/testReport)**
for PR 19193 at commit
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/16158#discussion_r138133273
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/ValidatorParams.scala ---
@@ -85,6 +86,32 @@ private[ml] trait ValidatorParams extends HasSeed
Github user hhbyyh commented on the issue:
https://github.com/apache/spark/pull/16158
Update:
To support pipeline estimator, change the tuning summary column name to
include full param reference:
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/18982
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19195
**[Test build #81646 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81646/testReport)**
for PR 19195 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19106#discussion_r138135778
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala
---
@@ -245,6 +245,10 @@ private[ml] object
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19106#discussion_r138130375
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala
---
@@ -245,6 +245,10 @@ private[ml] object
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19134
OK by me, if it's all on-purpose. So, am I right that all of the Pyspark
Kafka integration is effectively deprecated as of this change, because it
depends on now-deprecated 0.8 support? just want to
Github user smurching commented on the issue:
https://github.com/apache/spark/pull/19186
Note: This PR follows up on the work/discussions in
[https://github.com/apache/spark/pull/17014](https://github.com/apache/spark/pull/17014)
---
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r138144992
--- Diff: python/pyspark/ml/param/_shared_params_code_gen.py ---
@@ -152,6 +152,8 @@ def get$Name(self):
("varianceCol", "column name for
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/19130#discussion_r138151499
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -367,6 +368,52 @@ object SparkSubmit extends CommandLineUtils with
Logging
Github user smurching commented on a diff in the pull request:
https://github.com/apache/spark/pull/19186#discussion_r138139729
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -300,20 +300,23 @@ class KMeans @Since("1.5.0") (
Github user smurching commented on a diff in the pull request:
https://github.com/apache/spark/pull/19186#discussion_r138136774
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -483,24 +488,17 @@ class LogisticRegression
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r138144361
--- Diff: python/pyspark/ml/tuning.py ---
@@ -255,18 +257,27 @@ def _fit(self, dataset):
randCol = self.uid + "_rand"
df =
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r138142834
--- Diff: python/pyspark/ml/tuning.py ---
@@ -208,23 +210,23 @@ class CrossValidator(Estimator, ValidatorParams,
MLReadable, MLWritable):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18875
**[Test build #81641 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81641/testReport)**
for PR 18875 at commit
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r138151063
--- Diff: python/pyspark/ml/tuning.py ---
@@ -193,7 +194,8 @@ class CrossValidator(Estimator, ValidatorParams,
MLReadable, MLWritable):
>>> lr
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18875
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18875
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81643/
Test PASSed.
---
Github user smurching commented on a diff in the pull request:
https://github.com/apache/spark/pull/19186#discussion_r138137893
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -163,9 +165,7 @@ final class OneVsRestModel private[ml] (
Github user smurching commented on a diff in the pull request:
https://github.com/apache/spark/pull/19186#discussion_r138139091
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -82,7 +82,8 @@ private[shared] object
Github user smurching commented on a diff in the pull request:
https://github.com/apache/spark/pull/19186#discussion_r138140113
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/IsotonicRegression.scala ---
@@ -165,8 +170,7 @@ class IsotonicRegression @Since("1.5.0")
Github user smurching commented on a diff in the pull request:
https://github.com/apache/spark/pull/19186#discussion_r138139539
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -444,13 +444,13 @@ class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18875
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18875
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81641/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18875
**[Test build #81643 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81643/testReport)**
for PR 18875 at commit
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/19130#discussion_r138154503
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -367,6 +368,52 @@ object SparkSubmit extends CommandLineUtils with
Logging
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19193
**[Test build #81644 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81644/testReport)**
for PR 19193 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19110
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81653/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19110
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18538
@mgaido91 These are my last comments, it should be ready to merge once they
are addressed. Thanks for your contribution.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19196
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19196
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81656/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19196
**[Test build #81656 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81656/testReport)**
for PR 19196 at commit
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18538#discussion_r138256035
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -0,0 +1,438 @@
+/*
+ * Licensed to the Apache
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18538#discussion_r138255937
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -0,0 +1,438 @@
+/*
+ * Licensed to the Apache
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18538#discussion_r138255474
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -0,0 +1,438 @@
+/*
+ * Licensed to the Apache
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18538#discussion_r138255648
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -0,0 +1,438 @@
+/*
+ * Licensed to the Apache
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19110
**[Test build #81653 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81653/testReport)**
for PR 19110 at commit
Github user erenavsarogullari commented on the issue:
https://github.com/apache/spark/pull/15326
Hi @kayousterhout,
Many thanks again for your review.
Patch is ready to re-review.
---
-
To unsubscribe,
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r137942548
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -229,10 +254,22 @@ private[history] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r137942697
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -301,9 +334,13 @@ private[history] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r137942178
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -742,53 +698,146 @@ private[history] object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r137942487
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -422,208 +455,101 @@ private[history] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r137940633
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -117,17 +122,37 @@ private[history] class
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19118
You don't have to use `saveAsHadoopFile`, just call `saveAsHadoopDataset`
directly?
---
-
To unsubscribe, e-mail:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r137941077
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -117,17 +122,37 @@ private[history] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r137942186
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -742,53 +698,146 @@ private[history] object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r137941159
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -742,53 +698,146 @@ private[history] object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r137942598
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -229,10 +254,22 @@ private[history] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r137942907
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -316,25 +353,21 @@ private[history] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r137940658
--- Diff: core/src/main/scala/org/apache/spark/deploy/history/config.scala
---
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r138191841
--- Diff: core/src/main/scala/org/apache/spark/deploy/history/config.scala
---
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r137942505
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -742,53 +698,146 @@ private[history] object
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/19107
@WeichenXu123 I just commented on
https://issues.apache.org/jira/browse/SPARK-18608 to clarify our efforts here.
Can you please either retarget this for SPARK-18608 and update it, or ask
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19194
**[Test build #81645 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81645/testReport)**
for PR 19194 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19194
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19194
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81645/
Test PASSed.
---
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19110#discussion_r138180599
--- Diff: python/pyspark/ml/param/shared.py ---
@@ -608,6 +608,30 @@ def getAggregationDepth(self):
return
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/19110
Other than that 1 item, this looks ready
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81647/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #81647 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81647/testReport)**
for PR 18982 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user original-brownbear commented on the issue:
https://github.com/apache/spark/pull/19182
@srowen looks like we're all green :)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/18592#discussion_r138220942
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala
---
@@ -99,6 +95,20 @@ object TPCDSQueryBenchmark {
301 - 366 of 366 matches
Mail list logo
