Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/18924#discussion_r142833499
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -462,36 +462,55 @@ final class OnlineLDAOptimizer extends LDAOptim
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r142835260
--- Diff: python/pyspark/sql/group.py ---
@@ -192,7 +193,66 @@ def pivot(self, pivot_col, values=None):
jgd = self._jgd.pivot(pivot_col)
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r142836245
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/object.scala
---
@@ -519,3 +519,18 @@ case class CoGroup(
outputO
GitHub user lw-lin opened a pull request:
https://github.com/apache/spark/pull/19435
[WIP][SS][MINOR] "keyWithIndexToNumValues" -> "keyWithIndexToValue"
## What changes were proposed in this pull request?
This PR changes `keyWithIndexToNumValues` to `keyWithIndexToValue`.
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r142836297
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/object.scala
---
@@ -519,3 +519,18 @@ case class CoGroup(
outputO
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19435
**[Test build #82462 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82462/testReport)**
for PR 19435 at commit
[`c62ba65`](https://github.com/apache/spark/commit/c6
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19435#discussion_r142836474
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -291,7 +291,7 @@ class Symmetric
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19416
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r142836611
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ArrowEvalPythonExec.scala
---
@@ -26,6 +26,25 @@ import org.apache.spark.sql.catalys
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/18732
I pushed a new commit addressing the comments. Let me scan through the
comments again. I think there are some comments around worker.py not being
addressed yet.
---
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18732
**[Test build #82463 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82463/testReport)**
for PR 18732 at commit
[`657942b`](https://github.com/apache/spark/commit/65
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19424#discussion_r142838899
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/PushDownOperatorsToDataSource.scala
---
@@ -0,0 +1,99 @@
+/*
+ *
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r142839010
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ArrowEvalPythonExec.scala
---
@@ -26,6 +26,25 @@ import org.apache.spark.sql.cat
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19424
**[Test build #82464 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82464/testReport)**
for PR 19424 at commit
[`df1d1c5`](https://github.com/apache/spark/commit/df
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/19436
[SQL][WIP] Fix FlatMapGroupsInR's child distribution when grouping
attributes are empty
## What changes were proposed in this pull request?
Looks like `FlatMapGroupsInRExec.requiredChildDis
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19436
**[Test build #82465 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82465/testReport)**
for PR 19436 at commit
[`6710141`](https://github.com/apache/spark/commit/67
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18732
**[Test build #82466 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82466/testReport)**
for PR 18732 at commit
[`fa88c88`](https://github.com/apache/spark/commit/fa
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r142840490
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/object.scala
---
@@ -519,3 +519,18 @@ case class CoGroup(
out
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19418
**[Test build #82467 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82467/testReport)**
for PR 19418 at commit
[`773b429`](https://github.com/apache/spark/commit/77
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r142841543
--- Diff: python/pyspark/sql/group.py ---
@@ -192,7 +193,67 @@ def pivot(self, pivot_col, values=None):
jgd = self._jgd.pivot(pivot_col)
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19418#discussion_r142841674
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -697,7 +697,14 @@ class CodegenContext {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19436
**[Test build #82468 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82468/testReport)**
for PR 19436 at commit
[`e0af5d6`](https://github.com/apache/spark/commit/e0
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/19432
Thanks! Merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: re
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19432
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19418
**[Test build #82467 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82467/testReport)**
for PR 19418 at commit
[`773b429`](https://github.com/apache/spark/commit/7
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19418
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82467/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19418
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19418#discussion_r142844714
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -697,7 +697,14 @@ class CodegenContext {
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19436
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82468/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19436
**[Test build #82468 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82468/testReport)**
for PR 19436 at commit
[`e0af5d6`](https://github.com/apache/spark/commit/e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19436
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r142845456
--- Diff: python/pyspark/sql/group.py ---
@@ -192,7 +193,67 @@ def pivot(self, pivot_col, values=None):
jgd = self._jgd.pivot(pivot_col)
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18732
**[Test build #82469 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82469/testReport)**
for PR 18732 at commit
[`e4efb32`](https://github.com/apache/spark/commit/e4
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19436
Ok. The added test works to verify this is an issue. See the test result of
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82468/testReport.
---
--
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19436
**[Test build #82470 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82470/testReport)**
for PR 19436 at commit
[`6710141`](https://github.com/apache/spark/commit/67
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19424
**[Test build #82464 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82464/testReport)**
for PR 19424 at commit
[`df1d1c5`](https://github.com/apache/spark/commit/d
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19424
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19424
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82464/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19418
**[Test build #82471 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82471/testReport)**
for PR 19418 at commit
[`3f8ce9a`](https://github.com/apache/spark/commit/3f
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19418#discussion_r142847702
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -697,7 +697,12 @@ class CodegenContext {
Github user rekhajoshm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19418#discussion_r142848020
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -697,7 +697,12 @@ class CodegenContex
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19436
LGTM mind opening a JIRA?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18732
**[Test build #82463 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82463/testReport)**
for PR 18732 at commit
[`657942b`](https://github.com/apache/spark/commit/6
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18732
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82463/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18732
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19436
@HyukjinKwon Yeah, wait me few minutes. Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19418
From the stacktrace posted in the JIRA, the problematic code is:
/* 151 */ comp = agg_bufValue.compare(smj_value3);
`agg_bufValue` is a `long` but `smj_value3` is a `UT
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19435
**[Test build #82462 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82462/testReport)**
for PR 19435 at commit
[`c62ba65`](https://github.com/apache/spark/commit/c
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19435
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19435
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82462/
Test PASSed.
---
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19436#discussion_r142849580
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/objects.scala ---
@@ -394,7 +394,11 @@ case class FlatMapGroupsInRExec(
override
Github user rekhajoshm commented on the issue:
https://github.com/apache/spark/pull/19418
@viirya You are correct, i am on latest master, and i did not get it yet.
This PR was to have a defensive condition. As, if this happens only under
certain unique data/flow, this is the one place
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19436#discussion_r142850005
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/objects.scala ---
@@ -394,7 +394,11 @@ case class FlatMapGroupsInRExec(
override def
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18732
**[Test build #82466 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82466/testReport)**
for PR 18732 at commit
[`fa88c88`](https://github.com/apache/spark/commit/f
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19418
I think we don't want to add such defensive condition and avoid the
logtrace. Without that, we don't know the problem is happened. We should
identify the issue and fix it if it is really there, inste
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18732
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18732
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82466/
Test FAILed.
---
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/13440
@srowen @thunterdb any more thoughts on this?
how about @sethah @yanboliang @jkbradley?
---
-
To unsubscribe, e-mail: rev
Github user rekhajoshm closed the pull request at:
https://github.com/apache/spark/pull/19418
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19436
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19436
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82465/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19436
**[Test build #82465 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82465/testReport)**
for PR 19436 at commit
[`6710141`](https://github.com/apache/spark/commit/6
Github user lw-lin commented on the issue:
https://github.com/apache/spark/pull/19435
@tdas would you take a look, thanks
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19418
**[Test build #82471 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82471/testReport)**
for PR 19418 at commit
[`3f8ce9a`](https://github.com/apache/spark/commit/3
Github user squito commented on the issue:
https://github.com/apache/spark/pull/19194
btw I'm going to have really intermittent access for a few weeks, so you
don't need to wait for me to proceed with this @tgravescs
---
-
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19418
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82471/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19418
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19337#discussion_r142853643
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -224,6 +224,20 @@ private[clustering] trait LDAParams extends Params
with HasF
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19337#discussion_r142853109
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -224,6 +224,20 @@ private[clustering] trait LDAParams extends Params
with HasF
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19337#discussion_r142854372
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -322,6 +326,13 @@ final class OnlineLDAOptimizer extends LDAOptimi
Github user squito commented on the issue:
https://github.com/apache/spark/pull/19287
lgtm, thanks @xuanyuanking
@jerryshao can you merge this? I will have very intermittent access for a
few weeks, I'd prefer not to merge in case there is any issue that needs an
urgent foll
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19436
**[Test build #82472 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82472/testReport)**
for PR 19436 at commit
[`0e111a8`](https://github.com/apache/spark/commit/0e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18732
**[Test build #82469 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82469/testReport)**
for PR 18732 at commit
[`e4efb32`](https://github.com/apache/spark/commit/e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18732
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82469/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18732
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
201 - 275 of 275 matches
Mail list logo
