[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

2017-10-23 Thread jsnowacki
Github user jsnowacki commented on the issue: https://github.com/apache/spark/pull/19370 @HyukjinKwon I've updated the PR description. Let me know if this is sufficient. --- - To unsubscribe, e-mail: reviews-unsubsc

[GitHub] spark issue #19529: [SPARK-22308] Support alternative unit testing styles in...

2017-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19529 **[Test build #82969 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82969/testReport)** for PR 19529 at commit [`4218b86`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #19529: [SPARK-22308] Support alternative unit testing styles in...

2017-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19529 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19529: [SPARK-22308] Support alternative unit testing styles in...

2017-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19529 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82969/ Test FAILed. ---

[GitHub] spark issue #19555: [SPARK-22133][DOCS] Documentation for Mesos Reject Offer...

2017-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19555 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #17100: [SPARK-13947][SQL] The error message from using an inval...

2017-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17100 **[Test build #82970 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82970/testReport)** for PR 17100 at commit [`6e8ab42`](https://github.com/apache/spark/commit/6e

[GitHub] spark pull request #19555: [SPARK-22133][DOCS] Documentation for Mesos Rejec...

2017-10-23 Thread windkit
GitHub user windkit opened a pull request: https://github.com/apache/spark/pull/19555 [SPARK-22133][DOCS] Documentation for Mesos Reject Offer Configurations ## What changes were proposed in this pull request? Documentation about Mesos Reject Offer Configurations ## Rel

[GitHub] spark pull request #19510: [SPARK-22292][Mesos] Added spark.mem.max support ...

2017-10-23 Thread windkit
Github user windkit commented on a diff in the pull request: https://github.com/apache/spark/pull/19510#discussion_r146180171 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala --- @@ -64,6 +64,7 @@ pr

[GitHub] spark pull request #19556: [SPARK-22328][Core] ClosureCleaner should not mis...

2017-10-23 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/19556 [SPARK-22328][Core] ClosureCleaner should not miss referenced superclass fields ## What changes were proposed in this pull request? When the given closure uses some fields defined in super

[GitHub] spark issue #19556: [SPARK-22328][Core] ClosureCleaner should not miss refer...

2017-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19556 **[Test build #82971 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82971/testReport)** for PR 19556 at commit [`29c5d73`](https://github.com/apache/spark/commit/29

[GitHub] spark pull request #19557: [SPARK-22281][SPARKR] Handle R method breaking si...

2017-10-23 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/19557 [SPARK-22281][SPARKR] Handle R method breaking signature changes ## What changes were proposed in this pull request? This is to fix the code for the latest R changes in R-devel ```

[GitHub] spark issue #19557: [SPARK-22281][SPARKR] Handle R method breaking signature...

2017-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19557 **[Test build #82972 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82972/testReport)** for PR 19557 at commit [`7b145ba`](https://github.com/apache/spark/commit/7b

[GitHub] spark pull request #19557: [SPARK-22281][SPARKR] Handle R method breaking si...

2017-10-23 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/19557#discussion_r146182283 --- Diff: R/pkg/R/DataFrame.R --- @@ -3247,12 +3247,23 @@ setMethod("as.data.frame", #' } #' @seealso \link{detach} #' @note attach since

[GitHub] spark pull request #19529: [SPARK-22308] Support alternative unit testing st...

2017-10-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19529#discussion_r146185476 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala --- @@ -52,249 +36,23 @@ import org.apache.spark.util.{UninterruptibleThread,

[GitHub] spark pull request #19529: [SPARK-22308] Support alternative unit testing st...

2017-10-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19529#discussion_r146185226 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/PlanTest.scala --- @@ -18,158 +18,9 @@ package org.apache.spark.sql.catalyst.

[GitHub] spark pull request #19529: [SPARK-22308] Support alternative unit testing st...

2017-10-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19529#discussion_r146186223 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/test/SharedSparkSession.scala --- @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] spark pull request #19529: [SPARK-22308] Support alternative unit testing st...

2017-10-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19529#discussion_r146185400 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/test/GenericFlatSpecSuite.scala --- @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software F

[GitHub] spark pull request #18492: [SPARK-19326] Speculated task attempts do not get...

2017-10-23 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/18492#discussion_r146190420 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -373,8 +373,14 @@ private[spark] class ExecutorAllocationManager(

[GitHub] spark issue #19557: [SPARK-22281][SPARKR] Handle R method breaking signature...

2017-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19557 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82972/ Test PASSed. ---

[GitHub] spark issue #19557: [SPARK-22281][SPARKR] Handle R method breaking signature...

2017-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19557 **[Test build #82972 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82972/testReport)** for PR 19557 at commit [`7b145ba`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #19557: [SPARK-22281][SPARKR] Handle R method breaking signature...

2017-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19557 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19556: [SPARK-22328][Core] ClosureCleaner should not miss refer...

2017-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19556 **[Test build #82973 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82973/testReport)** for PR 19556 at commit [`6606910`](https://github.com/apache/spark/commit/66

[GitHub] spark issue #18685: [SPARK-21439][PySpark] Support for ABCMeta in PySpark

2017-10-23 Thread maver1ck
Github user maver1ck commented on the issue: https://github.com/apache/spark/pull/18685 I realized that changes here was added also in SPARK-21070. https://github.com/apache/spark/commit/751f513367ae776c6d6815e1ce138078924872eb So we can close this PR. --- -

[GitHub] spark issue #17100: [SPARK-13947][SQL] The error message from using an inval...

2017-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17100 **[Test build #82970 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82970/testReport)** for PR 17100 at commit [`6e8ab42`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #17100: [SPARK-13947][SQL] The error message from using an inval...

2017-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17100 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82970/ Test FAILed. ---

[GitHub] spark issue #17100: [SPARK-13947][SQL] The error message from using an inval...

2017-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17100 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-23 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146205865 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -270,12 +271,25 @@ trait CheckAnalysis extends Predic

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-23 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146207532 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala --- @@ -408,16 +408,28 @@ class AnalysisErrorSuite exte

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-23 Thread rberenguel
Github user rberenguel commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146208143 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala --- @@ -408,16 +408,28 @@ class AnalysisErrorSuite

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-23 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146208370 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -270,12 +271,25 @@ trait CheckAnalysis extends Predic

[GitHub] spark issue #17100: [SPARK-13947][SQL] The error message from using an inval...

2017-10-23 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/17100 @rberenguel Could you fix [this comment](https://github.com/apache/spark/pull/17100#pullrequestreview-71023434)? --- - To unsubscr

[GitHub] spark issue #19439: [SPARK-21866][ML][PySpark] Adding spark image reader

2017-10-23 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/19439 @hhbyyh Thanks for your comments! > Another option is that to support all bytes[], short[], int[], float[] and double[] as data storage type candidates, and switch among them according

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-23 Thread rberenguel
Github user rberenguel commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146211291 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -270,12 +271,25 @@ trait CheckAnalysis extends P

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-23 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146211140 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -270,12 +270,27 @@ trait CheckAnalysis extends Predic

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-23 Thread rberenguel
Github user rberenguel commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146211895 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -270,12 +270,27 @@ trait CheckAnalysis extends P

[GitHub] spark pull request #19458: [SPARK-22227][CORE] DiskBlockManager.getAllBlocks...

2017-10-23 Thread superbobry
Github user superbobry commented on a diff in the pull request: https://github.com/apache/spark/pull/19458#discussion_r146213702 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala --- @@ -100,7 +100,16 @@ private[spark] class DiskBlockManager(conf: SparkC

[GitHub] spark issue #19556: [SPARK-22328][Core] ClosureCleaner should not miss refer...

2017-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19556 **[Test build #82971 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82971/testReport)** for PR 19556 at commit [`29c5d73`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #19556: [SPARK-22328][Core] ClosureCleaner should not miss refer...

2017-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19556 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19556: [SPARK-22328][Core] ClosureCleaner should not miss refer...

2017-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19556 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82971/ Test FAILed. ---

[GitHub] spark issue #19255: [SPARK-22029][PySpark] Add lru_cache to _parse_datatype_...

2017-10-23 Thread maver1ck
Github user maver1ck commented on the issue: https://github.com/apache/spark/pull/19255 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-23 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146229748 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -270,12 +270,27 @@ trait CheckAnalysis extends Predic

[GitHub] spark pull request #19558: [SPARK-22332][ML][TEST] Fix NaiveBayes unit test ...

2017-10-23 Thread WeichenXu123
GitHub user WeichenXu123 opened a pull request: https://github.com/apache/spark/pull/19558 [SPARK-22332][ML][TEST] Fix NaiveBayes unit test occasionly fail (cause by test dataset not deterministic) ## What changes were proposed in this pull request? Fix NaiveBayes unit test

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-23 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146230050 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -270,12 +270,27 @@ trait CheckAnalysis extends Predic

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-23 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146230295 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -270,12 +270,27 @@ trait CheckAnalysis extends Predic

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-23 Thread rberenguel
Github user rberenguel commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146233808 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -270,12 +270,27 @@ trait CheckAnalysis extends P

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-23 Thread rberenguel
Github user rberenguel commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146234085 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -270,12 +270,27 @@ trait CheckAnalysis extends P

[GitHub] spark issue #19555: [SPARK-22133][DOCS] Documentation for Mesos Reject Offer...

2017-10-23 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/19555 @susanxhuynh could you pls review this? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-23 Thread rberenguel
Github user rberenguel commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146234832 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -270,12 +270,27 @@ trait CheckAnalysis extends P

[GitHub] spark pull request #19551: [WIP][SPARK-17902][R] Revive stringsAsFactors opt...

2017-10-23 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19551#discussion_r146236358 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -499,6 +499,12 @@ test_that("create DataFrame with different data types", { expect_equal(c

[GitHub] spark pull request #19551: [WIP][SPARK-17902][R] Revive stringsAsFactors opt...

2017-10-23 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19551#discussion_r146236525 --- Diff: R/pkg/R/DataFrame.R --- @@ -1191,6 +1191,9 @@ setMethod("collect", vec <- do.call(c, col) sto

[GitHub] spark issue #18685: [SPARK-21439][PySpark] Support for ABCMeta in PySpark

2017-10-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18685 Let's close this then :). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

2017-10-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19370 👍 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.

[GitHub] spark pull request #19559: [SPARK-22333][SQL]ColumnReference should get high...

2017-10-23 Thread DonnyZone
GitHub user DonnyZone opened a pull request: https://github.com/apache/spark/pull/19559 [SPARK-22333][SQL]ColumnReference should get higher priority than timeFunctionCall(CURRENT_DATE, CURRENT_TIMESTAMP) ## What changes were proposed in this pull request? https://issues.apache.o

[GitHub] spark issue #19559: [SPARK-22333][SQL]ColumnReference should get higher prio...

2017-10-23 Thread DonnyZone
Github user DonnyZone commented on the issue: https://github.com/apache/spark/pull/19559 ping @hvanhovell @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mai

[GitHub] spark issue #19556: [SPARK-22328][Core] ClosureCleaner should not miss refer...

2017-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19556 **[Test build #82973 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82973/testReport)** for PR 19556 at commit [`6606910`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #19559: [SPARK-22333][SQL]ColumnReference should get higher prio...

2017-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19559 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19556: [SPARK-22328][Core] ClosureCleaner should not miss refer...

2017-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19556 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82973/ Test PASSed. ---

[GitHub] spark issue #19556: [SPARK-22328][Core] ClosureCleaner should not miss refer...

2017-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19556 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19255: [SPARK-22029][PySpark] Add lru_cache to _parse_datatype_...

2017-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19255 **[Test build #82976 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82976/testReport)** for PR 19255 at commit [`679141d`](https://github.com/apache/spark/commit/67

[GitHub] spark issue #19255: [SPARK-22029][PySpark] Add lru_cache to _parse_datatype_...

2017-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19255 **[Test build #82977 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82977/testReport)** for PR 19255 at commit [`679141d`](https://github.com/apache/spark/commit/67

[GitHub] spark issue #17100: [SPARK-13947][SQL] The error message from using an inval...

2017-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17100 **[Test build #82981 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82981/testReport)** for PR 17100 at commit [`e3cc455`](https://github.com/apache/spark/commit/e3

[GitHub] spark issue #19558: [SPARK-22332][ML][TEST] Fix NaiveBayes unit test occasio...

2017-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19558 **[Test build #82978 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82978/testReport)** for PR 19558 at commit [`be2606b`](https://github.com/apache/spark/commit/be

[GitHub] spark issue #17100: [SPARK-13947][SQL] The error message from using an inval...

2017-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17100 **[Test build #82980 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82980/testReport)** for PR 17100 at commit [`33a8a71`](https://github.com/apache/spark/commit/33

[GitHub] spark issue #17100: [SPARK-13947][SQL] The error message from using an inval...

2017-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17100 **[Test build #82979 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82979/testReport)** for PR 17100 at commit [`72b72cf`](https://github.com/apache/spark/commit/72

[GitHub] spark issue #19551: [SPARK-17902][R] Revive stringsAsFactors option for coll...

2017-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19551 **[Test build #82982 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82982/testReport)** for PR 19551 at commit [`f9e42d5`](https://github.com/apache/spark/commit/f9

[GitHub] spark issue #19558: [SPARK-22332][ML][TEST] Fix NaiveBayes unit test occasio...

2017-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19558 **[Test build #82974 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82974/testReport)** for PR 19558 at commit [`de780e3`](https://github.com/apache/spark/commit/de

[GitHub] spark issue #19556: [SPARK-22328][Core] ClosureCleaner should not miss refer...

2017-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19556 **[Test build #82975 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82975/testReport)** for PR 19556 at commit [`5ac7540`](https://github.com/apache/spark/commit/5a

[GitHub] spark issue #19558: [SPARK-22332][ML][TEST] Fix NaiveBayes unit test occasio...

2017-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19558 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19558: [SPARK-22332][ML][TEST] Fix NaiveBayes unit test occasio...

2017-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19558 **[Test build #82974 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82974/testReport)** for PR 19558 at commit [`de780e3`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #19558: [SPARK-22332][ML][TEST] Fix NaiveBayes unit test occasio...

2017-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19558 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82974/ Test FAILed. ---

[GitHub] spark issue #19558: [SPARK-22332][ML][TEST] Fix NaiveBayes unit test occasio...

2017-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19558 **[Test build #82978 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82978/testReport)** for PR 19558 at commit [`be2606b`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #19558: [SPARK-22332][ML][TEST] Fix NaiveBayes unit test occasio...

2017-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19558 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82978/ Test FAILed. ---

[GitHub] spark issue #19558: [SPARK-22332][ML][TEST] Fix NaiveBayes unit test occasio...

2017-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19558 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #19555: [SPARK-22133][DOCS] Documentation for Mesos Rejec...

2017-10-23 Thread ArtRand
Github user ArtRand commented on a diff in the pull request: https://github.com/apache/spark/pull/19555#discussion_r146242931 --- Diff: docs/running-on-mesos.md --- @@ -344,6 +345,13 @@ See the [configuration page](configuration.html) for information on Spark config

[GitHub] spark pull request #19555: [SPARK-22133][DOCS] Documentation for Mesos Rejec...

2017-10-23 Thread ArtRand
Github user ArtRand commented on a diff in the pull request: https://github.com/apache/spark/pull/19555#discussion_r146242882 --- Diff: docs/running-on-mesos.md --- @@ -196,17 +196,18 @@ configuration variables: * Executor memory: `spark.executor.memory` * Executor c

[GitHub] spark pull request #19555: [SPARK-22133][DOCS] Documentation for Mesos Rejec...

2017-10-23 Thread ArtRand
Github user ArtRand commented on a diff in the pull request: https://github.com/apache/spark/pull/19555#discussion_r146242613 --- Diff: docs/running-on-mesos.md --- @@ -196,17 +196,18 @@ configuration variables: * Executor memory: `spark.executor.memory` * Executor c

[GitHub] spark pull request #19555: [SPARK-22133][DOCS] Documentation for Mesos Rejec...

2017-10-23 Thread ArtRand
Github user ArtRand commented on a diff in the pull request: https://github.com/apache/spark/pull/19555#discussion_r146244212 --- Diff: docs/running-on-mesos.md --- @@ -613,6 +621,41 @@ See the [configuration page](configuration.html) for information on Spark config driver

[GitHub] spark issue #19559: [SPARK-22333][SQL]ColumnReference should get higher prio...

2017-10-23 Thread DonnyZone
Github user DonnyZone commented on the issue: https://github.com/apache/spark/pull/19559 ping @gatorsmile @hvanhovell @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comm

[GitHub] spark issue #19558: [SPARK-22332][ML][TEST] Fix NaiveBayes unit test occasio...

2017-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19558 **[Test build #82983 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82983/testReport)** for PR 19558 at commit [`331d026`](https://github.com/apache/spark/commit/33

[GitHub] spark issue #19558: [SPARK-22332][ML][TEST] Fix NaiveBayes unit test occasio...

2017-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19558 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82983/ Test FAILed. ---

[GitHub] spark issue #19558: [SPARK-22332][ML][TEST] Fix NaiveBayes unit test occasio...

2017-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19558 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19558: [SPARK-22332][ML][TEST] Fix NaiveBayes unit test occasio...

2017-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19558 **[Test build #82983 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82983/testReport)** for PR 19558 at commit [`331d026`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #19255: [SPARK-22029][PySpark] Add lru_cache to _parse_datatype_...

2017-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19255 **[Test build #82976 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82976/testReport)** for PR 19255 at commit [`679141d`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #19255: [SPARK-22029][PySpark] Add lru_cache to _parse_datatype_...

2017-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19255 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82976/ Test PASSed. ---

[GitHub] spark issue #19255: [SPARK-22029][PySpark] Add lru_cache to _parse_datatype_...

2017-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19255 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19255: [SPARK-22029][PySpark] Add lru_cache to _parse_datatype_...

2017-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19255 **[Test build #82977 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82977/testReport)** for PR 19255 at commit [`679141d`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #19255: [SPARK-22029][PySpark] Add lru_cache to _parse_datatype_...

2017-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19255 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19255: [SPARK-22029][PySpark] Add lru_cache to _parse_datatype_...

2017-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19255 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82977/ Test PASSed. ---

[GitHub] spark pull request #18685: [SPARK-21439][PySpark] Support for ABCMeta in PyS...

2017-10-23 Thread maver1ck
Github user maver1ck closed the pull request at: https://github.com/apache/spark/pull/18685 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19255: [SPARK-22029][PySpark] Add lru_cache to _parse_da...

2017-10-23 Thread maver1ck
Github user maver1ck commented on a diff in the pull request: https://github.com/apache/spark/pull/19255#discussion_r146248695 --- Diff: python/pyspark/sql/types.py --- @@ -24,6 +24,7 @@ import re import base64 from array import array +from functools import lru_ca

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-23 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146251261 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -270,12 +270,27 @@ trait CheckAnalysis extends Predic

[GitHub] spark issue #19551: [SPARK-17902][R] Revive stringsAsFactors option for coll...

2017-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19551 **[Test build #82982 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82982/testReport)** for PR 19551 at commit [`f9e42d5`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #19551: [SPARK-17902][R] Revive stringsAsFactors option for coll...

2017-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19551 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19551: [SPARK-17902][R] Revive stringsAsFactors option for coll...

2017-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19551 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82982/ Test PASSed. ---

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-23 Thread rberenguel
Github user rberenguel commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146252936 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -270,12 +270,27 @@ trait CheckAnalysis extends P

[GitHub] spark issue #19451: SPARK-22181 Adds ReplaceExceptWithNotFilter rule

2017-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19451 **[Test build #82984 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82984/testReport)** for PR 19451 at commit [`e010651`](https://github.com/apache/spark/commit/e0

[GitHub] spark issue #19558: [SPARK-22332][ML][TEST] Fix NaiveBayes unit test occasio...

2017-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19558 **[Test build #82985 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82985/testReport)** for PR 19558 at commit [`3ea8c50`](https://github.com/apache/spark/commit/3e

[GitHub] spark issue #19269: [SPARK-22026][SQL] data source v2 write path

2017-10-23 Thread steveloughran
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/19269 w.r.t init, I'm thinking it's critical to get the DataframeWriter.extraOptions down the tree. This lets committers be tuned on a query-by-query basis for things like conflict management, rathe

[GitHub] spark pull request #19560: [SPARK-22334][SQL] Check table size from HDFS in ...

2017-10-23 Thread jinxing64
GitHub user jinxing64 opened a pull request: https://github.com/apache/spark/pull/19560 [SPARK-22334][SQL] Check table size from HDFS in case the size in metastore is wrong. ## What changes were proposed in this pull request? Currently we use table properties('totalSize') t

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-23 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146256023 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -270,12 +270,25 @@ trait CheckAnalysis extends Predic

  1   2   3   4   >