[GitHub] spark pull request #20350: [SPARK-23179][SQL] Support option to throw except...

2018-01-22 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/20350#discussion_r163008946 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala --- @@ -237,14 +238,26 @@ final class Decimal extends Ordered[Decimal] with

[GitHub] spark issue #20201: [SPARK-22389][SQL] data source v2 partitioning reporting...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20201 **[Test build #86483 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86483/testReport)** for PR 20201 at commit [`28987a7`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #20201: [SPARK-22389][SQL] data source v2 partitioning reporting...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20201 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20201: [SPARK-22389][SQL] data source v2 partitioning reporting...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20201 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86483/ Test PASSed. ---

[GitHub] spark pull request #20201: [SPARK-22389][SQL] data source v2 partitioning re...

2018-01-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20201#discussion_r163008488 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/Partitioning.java --- @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache So

[GitHub] spark pull request #20201: [SPARK-22389][SQL] data source v2 partitioning re...

2018-01-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20201#discussion_r163010318 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/Partitioning.java --- @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache So

[GitHub] spark pull request #20201: [SPARK-22389][SQL] data source v2 partitioning re...

2018-01-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20201#discussion_r163008839 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/Partitioning.java --- @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache So

[GitHub] spark pull request #20201: [SPARK-22389][SQL] data source v2 partitioning re...

2018-01-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20201#discussion_r163010889 --- Diff: sql/core/src/test/java/test/org/apache/spark/sql/sources/v2/JavaPartitionAwareDataSource.java --- @@ -0,0 +1,110 @@ +/* + * Licensed t

[GitHub] spark issue #20345: [SPARK-23172][SQL] Respect Project nodes in ReorderJoin

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20345 **[Test build #86485 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86485/testReport)** for PR 20345 at commit [`ca65b9d`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #20345: [SPARK-23172][SQL] Respect Project nodes in ReorderJoin

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20345 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20345: [SPARK-23172][SQL] Respect Project nodes in ReorderJoin

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20345 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86485/ Test FAILed. ---

[GitHub] spark pull request #20350: [SPARK-23179][SQL] Support option to throw except...

2018-01-22 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20350#discussion_r163013386 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala --- @@ -237,14 +238,26 @@ final class Decimal extends Ordered[Decimal] wit

[GitHub] spark pull request #20297: [SPARK-23020][CORE] Fix races in launcher code, t...

2018-01-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20297#discussion_r163014278 --- Diff: launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java --- @@ -48,14 +48,16 @@ public synchronized void disconnect() {

[GitHub] spark issue #20346: [MINOR][SQL] Fix wrong comments on org.apache.spark.sql....

2018-01-22 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20346 Thank you, @HyukjinKwon and @viirya ! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional com

[GitHub] spark issue #20201: [SPARK-22389][SQL] data source v2 partitioning reporting...

2018-01-22 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20201 LGTM except a few minor comments. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #20343: [SPARK-23167][SQL] Add TPCDS queries v2.7 in TPCD...

2018-01-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20343#discussion_r163016890 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/TPCDSQuerySuite.scala --- @@ -339,6 +340,24 @@ class TPCDSQuerySuite extends BenchmarkQueryTest {

[GitHub] spark issue #20350: [SPARK-23179][SQL] Support option to throw exception if ...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20350 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/107/ Test

[GitHub] spark issue #20350: [SPARK-23179][SQL] Support option to throw exception if ...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20350 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20350: [SPARK-23179][SQL] Support option to throw exception if ...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20350 **[Test build #86488 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86488/testReport)** for PR 20350 at commit [`fcd665e`](https://github.com/apache/spark/commit/fc

[GitHub] spark issue #20201: [SPARK-22389][SQL] data source v2 partitioning reporting...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20201 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/108/ Test

[GitHub] spark issue #20201: [SPARK-22389][SQL] data source v2 partitioning reporting...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20201 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20201: [SPARK-22389][SQL] data source v2 partitioning reporting...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20201 **[Test build #86489 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86489/testReport)** for PR 20201 at commit [`48b9fda`](https://github.com/apache/spark/commit/48

[GitHub] spark issue #20203: [SPARK-22577] [core] executor page blacklist status shou...

2018-01-22 Thread attilapiros
Github user attilapiros commented on the issue: https://github.com/apache/spark/pull/20203 Test failure seems to be unrelated as it it is in org.apache.spark.sql.hive.client.HiveClientSuites. @squito, @tgravescs could you please restart testing --- -

[GitHub] spark pull request #20343: [SPARK-23167][SQL] Add TPCDS queries v2.7 in TPCD...

2018-01-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20343#discussion_r163019362 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/TPCDSQuerySuite.scala --- @@ -244,7 +244,7 @@ class TPCDSQuerySuite extends BenchmarkQueryTest {

[GitHub] spark issue #20344: [MINOR] Typo fixes

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20344 **[Test build #4070 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4070/testReport)** for PR 20344 at commit [`2d5f07d`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #20343: [SPARK-23167][SQL] Add TPCDS queries v2.7 in TPCD...

2018-01-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20343#discussion_r163020873 --- Diff: sql/core/src/test/resources/tpcds-v2.7.0/q11.sql --- @@ -0,0 +1,78 @@ +with year_total as ( + select c_customer_id customer_id +

[GitHub] spark pull request #20343: [SPARK-23167][SQL] Add TPCDS queries v2.7 in TPCD...

2018-01-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20343#discussion_r163021098 --- Diff: sql/core/src/test/resources/tpcds-v2.7.0/q11.sql --- @@ -0,0 +1,78 @@ +with year_total as ( + select c_customer_id customer_id +

[GitHub] spark pull request #20343: [SPARK-23167][SQL] Add TPCDS queries v2.7 in TPCD...

2018-01-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20343#discussion_r163021292 --- Diff: sql/core/src/test/resources/tpcds-v2.7.0/q11.sql --- @@ -0,0 +1,78 @@ +with year_total as ( + select c_customer_id customer_id +

[GitHub] spark issue #20343: [SPARK-23167][SQL] Add TPCDS queries v2.7 in TPCDSQueryS...

2018-01-22 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20343 Regarding the updates of `TPCDSQueryBenchmark`, we can do it in a separate PR. --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #20343: [SPARK-23167][SQL] Add TPCDS queries v2.7 in TPCDSQueryS...

2018-01-22 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20343 Regarding the change you made in `[date] + 14 days -> date + INTERVAL 14 days`, could we first support it before we merge this PR? It sounds like this is trivial to support, right? --- ---

[GitHub] spark issue #20330: [SPARK-23121][core] Fix for ui becoming unaccessible for...

2018-01-22 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20330 Merging to master / 2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revie

[GitHub] spark issue #20342: [SPARK-23170][SQL] Dump the statistics of effective runs...

2018-01-22 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20342 @maropu That is blocked by the design and impl of usage log. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.o

[GitHub] spark pull request #20330: [SPARK-23121][core] Fix for ui becoming unaccessi...

2018-01-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20330 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20343: [SPARK-23167][SQL] Add TPCDS queries v2.7 in TPCD...

2018-01-22 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20343#discussion_r163030125 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/TPCDSQuerySuite.scala --- @@ -244,7 +244,7 @@ class TPCDSQuerySuite extends BenchmarkQueryTest

[GitHub] spark issue #20203: [SPARK-22577] [core] executor page blacklist status shou...

2018-01-22 Thread tgravescs
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/20203 Jenkins, test this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: r

[GitHub] spark issue #20203: [SPARK-22577] [core] executor page blacklist status shou...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20203 **[Test build #86490 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86490/testReport)** for PR 20203 at commit [`882bb9e`](https://github.com/apache/spark/commit/88

[GitHub] spark issue #20344: [MINOR] Typo fixes

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20344 **[Test build #4071 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4071/testReport)** for PR 20344 at commit [`78c5ef5`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #19993: [SPARK-22799][ML] Bucketizer should throw exception if s...

2018-01-22 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/19993 Well yes it would - but the method checks inputCols/inputCol first so will always fail for that reason here, ie we aren’t actually testing the full code path On Mon, 22 Jan 2018 at 16:43,

[GitHub] spark pull request #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

2018-01-22 Thread jose-torres
GitHub user jose-torres opened a pull request: https://github.com/apache/spark/pull/20351 [SPARK-23014][SS] Fully remove V1 memory sink. ## What changes were proposed in this pull request? Fully remove the V1 memory sink, now that all kinds of execution support the V2 versi

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20351 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20351 **[Test build #86491 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86491/testReport)** for PR 20351 at commit [`c75190b`](https://github.com/apache/spark/commit/c7

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19872 **[Test build #86487 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86487/testReport)** for PR 19872 at commit [`91885e5`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19872 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19872 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86487/ Test FAILed. ---

[GitHub] spark issue #17185: [SPARK-19602][SQL] Support column resolution of fully qu...

2018-01-22 Thread skambha
Github user skambha commented on the issue: https://github.com/apache/spark/pull/17185 sure. Let me look into it. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20344: [MINOR] Typo fixes

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20344 **[Test build #86486 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86486/testReport)** for PR 20344 at commit [`78c5ef5`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #20344: [MINOR] Typo fixes

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20344 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86486/ Test PASSed. ---

[GitHub] spark issue #20344: [MINOR] Typo fixes

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20344 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20344: [MINOR] Typo fixes

2018-01-22 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20344 Merged to master/2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #20344: [MINOR] Typo fixes

2018-01-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20344 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19872 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19872 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/109/ Test

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19872 **[Test build #86492 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86492/testReport)** for PR 19872 at commit [`cc659bc`](https://github.com/apache/spark/commit/cc

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-01-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r163046590 --- Diff: core/src/main/scala/org/apache/spark/CacheRecoveryManager.scala --- @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-01-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r163052829 --- Diff: core/src/test/scala/org/apache/spark/CacheRecoveryManagerSuite.scala --- @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-01-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r163052459 --- Diff: core/src/test/scala/org/apache/spark/CacheRecoveryManagerSuite.scala --- @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-01-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r163050512 --- Diff: core/src/test/scala/org/apache/spark/CacheRecoveryManagerSuite.scala --- @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-01-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r163045368 --- Diff: core/src/main/scala/org/apache/spark/CacheRecoveryManager.scala --- @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-01-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r163054043 --- Diff: core/src/test/scala/org/apache/spark/scheduler/CacheRecoveryIntegrationSuite.scala --- @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache So

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-01-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r163053606 --- Diff: core/src/test/scala/org/apache/spark/scheduler/CacheRecoveryIntegrationSuite.scala --- @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache So

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-01-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r163050661 --- Diff: core/src/test/scala/org/apache/spark/CacheRecoveryManagerSuite.scala --- @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-01-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r163042297 --- Diff: core/src/main/scala/org/apache/spark/CacheRecoveryManager.scala --- @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-01-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r163046520 --- Diff: core/src/main/scala/org/apache/spark/CacheRecoveryManager.scala --- @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-01-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r163052910 --- Diff: core/src/test/scala/org/apache/spark/CacheRecoveryManagerSuite.scala --- @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-01-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r163041732 --- Diff: core/src/main/scala/org/apache/spark/CacheRecoveryManager.scala --- @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-01-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r163052565 --- Diff: core/src/test/scala/org/apache/spark/CacheRecoveryManagerSuite.scala --- @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-01-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r163045943 --- Diff: core/src/main/scala/org/apache/spark/CacheRecoveryManager.scala --- @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-01-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r163045008 --- Diff: core/src/main/scala/org/apache/spark/CacheRecoveryManager.scala --- @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-01-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r163051028 --- Diff: core/src/test/scala/org/apache/spark/CacheRecoveryManagerSuite.scala --- @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-01-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r163053874 --- Diff: core/src/test/scala/org/apache/spark/scheduler/CacheRecoveryIntegrationSuite.scala --- @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache So

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-01-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r163048247 --- Diff: core/src/main/scala/org/apache/spark/CacheRecoveryManager.scala --- @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-01-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r163052079 --- Diff: core/src/main/scala/org/apache/spark/CacheRecoveryManager.scala --- @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-01-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r163042811 --- Diff: core/src/main/scala/org/apache/spark/CacheRecoveryManager.scala --- @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-01-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r163055034 --- Diff: core/src/test/scala/org/apache/spark/scheduler/CacheRecoveryIntegrationSuite.scala --- @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache So

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-01-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r163050134 --- Diff: core/src/test/scala/org/apache/spark/CacheRecoveryManagerSuite.scala --- @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-01-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r163047551 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -123,6 +123,16 @@ package object config { .timeConf(TimeUnit.MIL

[GitHub] spark issue #19992: [SPARK-22805][CORE] Use StorageLevel aliases in event lo...

2018-01-22 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/19992 thanks for looking into this @superbobry -- can you actually close this yourself? we can't directly close it (there is a way but its more complicated) --- -

[GitHub] spark pull request #20301: [SPARK-23131][CORE][WIP] Stackoverflow using ML a...

2018-01-22 Thread srowen
Github user srowen closed the pull request at: https://github.com/apache/spark/pull/20301 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20351 **[Test build #86491 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86491/testReport)** for PR 20351 at commit [`c75190b`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20351 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20351 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86491/ Test FAILed. ---

[GitHub] spark issue #20350: [SPARK-23179][SQL] Support option to throw exception if ...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20350 **[Test build #86488 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86488/testReport)** for PR 20350 at commit [`fcd665e`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #20350: [SPARK-23179][SQL] Support option to throw exception if ...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20350 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20350: [SPARK-23179][SQL] Support option to throw exception if ...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20350 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86488/ Test FAILed. ---

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

2018-01-22 Thread jose-torres
Github user jose-torres commented on the issue: https://github.com/apache/spark/pull/20351 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: review

[GitHub] spark pull request #20352: [SPARK-21727][R] Allow multi-element atomic vecto...

2018-01-22 Thread neilalex
GitHub user neilalex opened a pull request: https://github.com/apache/spark/pull/20352 [SPARK-21727][R] Allow multi-element atomic vector as column type in SparkR DataFrame ## What changes were proposed in this pull request? A fix to https://issues.apache.org/jira/browse/SP

[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20352 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20351 **[Test build #86493 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86493/testReport)** for PR 20351 at commit [`c75190b`](https://github.com/apache/spark/commit/c7

[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20352 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-22 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/20352 Jenkins, ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-

[GitHub] spark issue #20350: [SPARK-23179][SQL] Support option to throw exception if ...

2018-01-22 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20350 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20350: [SPARK-23179][SQL] Support option to throw exception if ...

2018-01-22 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20350 cc @gatorsmile @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: r

[GitHub] spark issue #20285: [SPARK-22735][ML][DOC] Added VectorSizeHint docs and exa...

2018-01-22 Thread MrBago
Github user MrBago commented on the issue: https://github.com/apache/spark/pull/20285 I'd like to try and get this patched into 2.3 to make sure our documentation is complete for the 2.3 release. @viirya and @WeichenXu123 would you mind having another look at it? --- --

[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-22 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/20352 @neilalex Can you add the code snippet in the PR description as a new test case ? That way we will ensure this behavior is tested going forward --- ---

[GitHub] spark issue #20350: [SPARK-23179][SQL] Support option to throw exception if ...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20350 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20350: [SPARK-23179][SQL] Support option to throw exception if ...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20350 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/110/ Test

[GitHub] spark issue #20091: [SPARK-22465][FOLLOWUP] Update the number of partitions ...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20091 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/111/ Test

[GitHub] spark issue #20091: [SPARK-22465][FOLLOWUP] Update the number of partitions ...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20091 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20350: [SPARK-23179][SQL] Support option to throw exception if ...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20350 **[Test build #86495 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86495/testReport)** for PR 20350 at commit [`fcd665e`](https://github.com/apache/spark/commit/fc

[GitHub] spark issue #20091: [SPARK-22465][FOLLOWUP] Update the number of partitions ...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20091 **[Test build #86496 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86496/testReport)** for PR 20091 at commit [`ccdc0e6`](https://github.com/apache/spark/commit/cc

<    1   2   3   4   5   6   >