[GitHub] spark pull request #20025: [SPARK-22837][SQL]Session timeout checker does no...

2018-01-22 Thread zuotingbing
Github user zuotingbing commented on a diff in the pull request: https://github.com/apache/spark/pull/20025#discussion_r163127098 --- Diff: sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/SessionManager.java --- @@ -23,11 +23,7 @@ import java.util.Arra

[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-22 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/20352 Thanks @neilalex - Change LGTM. Lets also see if @felixcheung has any comments. --- - To unsubscribe, e-mail: reviews-unsubscr.

[GitHub] spark pull request #19285: [SPARK-22068][CORE]Reduce the duplicate code betw...

2018-01-22 Thread ConeyLiu
Github user ConeyLiu commented on a diff in the pull request: https://github.com/apache/spark/pull/19285#discussion_r163131383 --- Diff: core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala --- @@ -233,17 +235,13 @@ private[spark] class MemoryStore( }

[GitHub] spark pull request #19285: [SPARK-22068][CORE]Reduce the duplicate code betw...

2018-01-22 Thread ConeyLiu
Github user ConeyLiu commented on a diff in the pull request: https://github.com/apache/spark/pull/19285#discussion_r163131519 --- Diff: core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala --- @@ -162,26 +162,29 @@ private[spark] class MemoryStore( }

[GitHub] spark pull request #19285: [SPARK-22068][CORE]Reduce the duplicate code betw...

2018-01-22 Thread ConeyLiu
Github user ConeyLiu commented on a diff in the pull request: https://github.com/apache/spark/pull/19285#discussion_r163131741 --- Diff: core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala --- @@ -162,26 +162,29 @@ private[spark] class MemoryStore( }

[GitHub] spark pull request #20087: [SPARK-21786][SQL] The 'spark.sql.parquet.compres...

2018-01-22 Thread fjh100456
Github user fjh100456 commented on a diff in the pull request: https://github.com/apache/spark/pull/20087#discussion_r163132078 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/SaveAsHiveFile.scala --- @@ -55,18 +55,28 @@ private[hive] trait SaveAsHiveFile ext

[GitHub] spark issue #20177: [SPARK-22954][SQL] Fix the exception thrown by Analyze c...

2018-01-22 Thread suchithjn225
Github user suchithjn225 commented on the issue: https://github.com/apache/spark/pull/20177 I did't understand why the build is getting killed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20177: [SPARK-22954][SQL] Fix the exception thrown by Analyze c...

2018-01-22 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20177 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-

[GitHub] spark pull request #20350: [SPARK-23179][SQL] Support option to throw except...

2018-01-22 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20350#discussion_r163134537 --- Diff: sql/core/src/test/resources/sql-tests/inputs/decimalArithmeticOperations.sql --- @@ -49,7 +49,6 @@ select 1e35 / 0.1; -- arithmetic oper

[GitHub] spark issue #20177: [SPARK-22954][SQL] Fix the exception thrown by Analyze c...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20177 **[Test build #86506 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86506/testReport)** for PR 20177 at commit [`4d4e3fe`](https://github.com/apache/spark/commit/4d

[GitHub] spark pull request #20350: [SPARK-23179][SQL] Support option to throw except...

2018-01-22 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20350#discussion_r163134873 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala --- @@ -237,14 +238,26 @@ final class Decimal extends Ordered[Decimal] with S

[GitHub] spark pull request #20356: [SPARK-23185][SQL] Make the configuration "spark....

2018-01-22 Thread lvdongr
GitHub user lvdongr opened a pull request: https://github.com/apache/spark/pull/20356 [SPARK-23185][SQL] Make the configuration "spark.default.parallelism" can be changed on each SQL session to decrease empty files ## What changes were proposed in this pull request? Make the con

[GitHub] spark issue #20356: [SPARK-23185][SQL] Make the configuration "spark.default...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20356 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20356: [SPARK-23185][SQL] Make the configuration "spark.default...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20356 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20355: SPARK-23148: [SQL] Allow pathnames with special c...

2018-01-22 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20355#discussion_r163129347 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -2063,4 +2063,12 @@ class JsonSuite extends Qu

[GitHub] spark issue #20146: [SPARK-11215][ML] Add multiple columns support to String...

2018-01-22 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20146 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h.

[GitHub] spark issue #20146: [SPARK-11215][ML] Add multiple columns support to String...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20146 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20146: [SPARK-11215][ML] Add multiple columns support to String...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20146 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/120/ Test

[GitHub] spark issue #20146: [SPARK-11215][ML] Add multiple columns support to String...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20146 **[Test build #86507 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86507/testReport)** for PR 20146 at commit [`540c364`](https://github.com/apache/spark/commit/54

[GitHub] spark pull request #20025: [SPARK-22837][SQL]Session timeout checker does no...

2018-01-22 Thread zuotingbing
Github user zuotingbing commented on a diff in the pull request: https://github.com/apache/spark/pull/20025#discussion_r163136632 --- Diff: sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/SessionManager.java --- @@ -80,7 +76,6 @@ public synchronized void in

[GitHub] spark pull request #20355: SPARK-23148: [SQL] Allow pathnames with special c...

2018-01-22 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20355#discussion_r163137474 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/text/TextSuite.scala --- @@ -172,6 +172,14 @@ class TextSuite extends Quer

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20345 **[Test build #86499 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86499/testReport)** for PR 20345 at commit [`ca65b9d`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20345 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20345 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86499/ Test FAILed. ---

[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20025 **[Test build #86508 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86508/testReport)** for PR 20025 at commit [`883deb2`](https://github.com/apache/spark/commit/88

[GitHub] spark pull request #20357: [SPARK-23186][SQL] Loading JDBC Drivers should be...

2018-01-22 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/20357 [SPARK-23186][SQL] Loading JDBC Drivers should be synchronized ## What changes were proposed in this pull request? Since some JDBC Drivers have class initialization code to call `Dri

[GitHub] spark issue #20357: [SPARK-23186][SQL] Loading JDBC Drivers should be synchr...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20357 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20357: [SPARK-23186][SQL] Loading JDBC Drivers should be synchr...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20357 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/121/ Test

[GitHub] spark issue #20357: [SPARK-23186][SQL] Loading JDBC Drivers should be synchr...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20357 **[Test build #86509 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86509/testReport)** for PR 20357 at commit [`f8c3eac`](https://github.com/apache/spark/commit/f8

[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20025 **[Test build #86508 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86508/testReport)** for PR 20025 at commit [`883deb2`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20025 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20025 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86508/ Test PASSed. ---

[GitHub] spark pull request #20358: [SPARK-20749][SQL][FOLLOW-UP] Override prettyName...

2018-01-22 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/20358 [SPARK-20749][SQL][FOLLOW-UP] Override prettyName for bit_length and octet_length ## What changes were proposed in this pull request? We need to override the prettyName for bit_length and oc

[GitHub] spark issue #20358: [SPARK-20749][SQL][FOLLOW-UP] Override prettyName for bi...

2018-01-22 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20358 cc @kiszk @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revi

[GitHub] spark issue #20343: [SPARK-23167][SQL] Add TPCDS queries v2.7 in TPCDSQueryS...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20343 **[Test build #86501 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86501/testReport)** for PR 20343 at commit [`fff88d2`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #20343: [SPARK-23167][SQL] Add TPCDS queries v2.7 in TPCDSQueryS...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20343 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86501/ Test PASSed. ---

[GitHub] spark issue #20343: [SPARK-23167][SQL] Add TPCDS queries v2.7 in TPCDSQueryS...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20343 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-01-22 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20345 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h.

[GitHub] spark pull request #20087: [SPARK-21786][SQL] The 'spark.sql.parquet.compres...

2018-01-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20087#discussion_r163141749 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/SaveAsHiveFile.scala --- @@ -55,18 +55,28 @@ private[hive] trait SaveAsHiveFile ex

[GitHub] spark issue #20358: [SPARK-20749][SQL][FOLLOW-UP] Override prettyName for bi...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20358 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/122/ Test

[GitHub] spark issue #20358: [SPARK-20749][SQL][FOLLOW-UP] Override prettyName for bi...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20358 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20345 **[Test build #86511 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86511/testReport)** for PR 20345 at commit [`f1a6558`](https://github.com/apache/spark/commit/f1

[GitHub] spark issue #20358: [SPARK-20749][SQL][FOLLOW-UP] Override prettyName for bi...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20358 **[Test build #86510 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86510/testReport)** for PR 20358 at commit [`53d74a2`](https://github.com/apache/spark/commit/53

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20345 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/123/ Test

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20345 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #20357: [SPARK-23186][SQL] Loading JDBC Drivers should be...

2018-01-22 Thread dongjoon-hyun
Github user dongjoon-hyun closed the pull request at: https://github.com/apache/spark/pull/20357 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.

[GitHub] spark issue #13599: [SPARK-13587] [PYSPARK] Support virtualenv in pyspark

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13599 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/124/ Test

[GitHub] spark issue #13599: [SPARK-13587] [PYSPARK] Support virtualenv in pyspark

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13599 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #13599: [SPARK-13587] [PYSPARK] Support virtualenv in pyspark

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13599 **[Test build #86512 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86512/testReport)** for PR 13599 at commit [`79be9c1`](https://github.com/apache/spark/commit/79

[GitHub] spark issue #20355: SPARK-23148: [SQL] Allow pathnames with special characte...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20355 **[Test build #86505 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86505/testReport)** for PR 20355 at commit [`9c56736`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20345 **[Test build #86504 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86504/testReport)** for PR 20345 at commit [`f1a6558`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #20356: [SPARK-23185][SQL] Make the configuration "spark.default...

2018-01-22 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20356 Probably, we need more general solution. Please check the related and existing discussion: https://issues.apache.org/jira/browse/SPARK-13184 ---

[GitHub] spark issue #20355: SPARK-23148: [SQL] Allow pathnames with special characte...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20355 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20355: SPARK-23148: [SQL] Allow pathnames with special characte...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20355 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86505/ Test PASSed. ---

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20345 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86504/ Test PASSed. ---

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20345 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #13599: [SPARK-13587] [PYSPARK] Support virtualenv in pyspark

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13599 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #13599: [SPARK-13587] [PYSPARK] Support virtualenv in pyspark

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13599 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/125/ Test

[GitHub] spark pull request #20358: [SPARK-20749][SQL][FOLLOW-UP] Override prettyName...

2018-01-22 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20358#discussion_r163145263 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -141,7 +141,7 @@ statement (LIKE? pattern=STR

[GitHub] spark issue #13599: [SPARK-13587] [PYSPARK] Support virtualenv in pyspark

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13599 **[Test build #86512 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86512/testReport)** for PR 13599 at commit [`79be9c1`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #13599: [SPARK-13587] [PYSPARK] Support virtualenv in pyspark

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13599 **[Test build #86513 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86513/testReport)** for PR 13599 at commit [`581331b`](https://github.com/apache/spark/commit/58

[GitHub] spark issue #13599: [SPARK-13587] [PYSPARK] Support virtualenv in pyspark

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13599 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #13599: [SPARK-13587] [PYSPARK] Support virtualenv in pyspark

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13599 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86512/ Test FAILed. ---

[GitHub] spark issue #13599: [SPARK-13587] [PYSPARK] Support virtualenv in pyspark

2018-01-22 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/spark/pull/13599 @holdenk @HyukjinKwon @ueshin I have updated the PR, and now it also works when executor is restarted and even dynamic allocation is enabled. The only overhead is on the driver side when executor as

[GitHub] spark pull request #20359: [SPARK-23186][SQL] Initialize DriverManager first...

2018-01-22 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/20359 [SPARK-23186][SQL] Initialize DriverManager first before loading JDBC Drivers ## What changes were proposed in this pull request? Since some JDBC Drivers have class initialization co

[GitHub] spark issue #20359: [SPARK-23186][SQL] Initialize DriverManager first before...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20359 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/126/ Test

[GitHub] spark issue #20359: [SPARK-23186][SQL] Initialize DriverManager first before...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20359 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20359: [SPARK-23186][SQL] Initialize DriverManager first before...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20359 **[Test build #86514 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86514/testReport)** for PR 20359 at commit [`234a637`](https://github.com/apache/spark/commit/23

[GitHub] spark pull request #20355: SPARK-23148: [SQL] Allow pathnames with special c...

2018-01-22 Thread henryr
Github user henryr commented on a diff in the pull request: https://github.com/apache/spark/pull/20355#discussion_r163146077 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/text/TextSuite.scala --- @@ -172,6 +172,14 @@ class TextSuite extends QueryTest

[GitHub] spark issue #20358: [SPARK-20749][SQL][FOLLOW-UP] Override prettyName for bi...

2018-01-22 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20358 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apa

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-22 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/19872 Thanks! merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: rev

[GitHub] spark issue #13599: [SPARK-13587] [PYSPARK] Support virtualenv in pyspark

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13599 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86513/ Test FAILed. ---

[GitHub] spark issue #13599: [SPARK-13587] [PYSPARK] Support virtualenv in pyspark

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13599 **[Test build #86513 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86513/testReport)** for PR 13599 at commit [`581331b`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #13599: [SPARK-13587] [PYSPARK] Support virtualenv in pyspark

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13599 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregati...

2018-01-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19872 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20292: [SPARK-23129][CORE] Make deserializeStream of Dis...

2018-01-22 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/20292#discussion_r163146577 --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala --- @@ -463,21 +463,21 @@ class ExternalAppendOnlyMap[K, V, C](

[GitHub] spark pull request #20355: SPARK-23148: [SQL] Allow pathnames with special c...

2018-01-22 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20355#discussion_r163149134 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/text/TextSuite.scala --- @@ -172,6 +172,14 @@ class TextSuite extends Quer

[GitHub] spark pull request #20292: [SPARK-23129][CORE] Make deserializeStream of Dis...

2018-01-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20292#discussion_r163149213 --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala --- @@ -463,21 +463,21 @@ class ExternalAppendOnlyMap[K, V, C]

[GitHub] spark pull request #20292: [SPARK-23129][CORE] Make deserializeStream of Dis...

2018-01-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20292#discussion_r163149478 --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala --- @@ -463,21 +463,21 @@ class ExternalAppendOnlyMap[K, V, C]

[GitHub] spark pull request #20292: [SPARK-23129][CORE] Make deserializeStream of Dis...

2018-01-22 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20292#discussion_r163149674 --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala --- @@ -509,8 +509,8 @@ class ExternalAppendOnlyMap[K, V, C]

[GitHub] spark pull request #20292: [SPARK-23129][CORE] Make deserializeStream of Dis...

2018-01-22 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20292#discussion_r163149829 --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala --- @@ -547,9 +555,9 @@ class ExternalAppendOnlyMap[K, V, C]

[GitHub] spark pull request #20087: [SPARK-21786][SQL] The 'spark.sql.parquet.compres...

2018-01-22 Thread fjh100456
Github user fjh100456 commented on a diff in the pull request: https://github.com/apache/spark/pull/20087#discussion_r163150428 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/SaveAsHiveFile.scala --- @@ -55,18 +55,28 @@ private[hive] trait SaveAsHiveFile ext

[GitHub] spark pull request #20355: SPARK-23148: [SQL] Allow pathnames with special c...

2018-01-22 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20355#discussion_r163152164 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/text/TextSuite.scala --- @@ -172,6 +172,14 @@ class TextSuite extends Quer

[GitHub] spark issue #20224: [SPARK-23032][SQL] Add a per-query codegenStageId to Who...

2018-01-22 Thread rednaxelafx
Github user rednaxelafx commented on the issue: https://github.com/apache/spark/pull/20224 I've updated the PR addressing @gatorsmile 's comments: moved the new utility code to `WholeStageCodegenId` object and added a new test case in `HiveExplainSuite`. ping @gatorsmile @kis

[GitHub] spark issue #20224: [SPARK-23032][SQL] Add a per-query codegenStageId to Who...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20224 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20224: [SPARK-23032][SQL] Add a per-query codegenStageId to Who...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20224 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/127/ Test

[GitHub] spark issue #20224: [SPARK-23032][SQL] Add a per-query codegenStageId to Who...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20224 **[Test build #86515 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86515/testReport)** for PR 20224 at commit [`a0162aa`](https://github.com/apache/spark/commit/a0

[GitHub] spark issue #20177: [SPARK-22954][SQL] Fix the exception thrown by Analyze c...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20177 **[Test build #86506 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86506/testReport)** for PR 20177 at commit [`4d4e3fe`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #20177: [SPARK-22954][SQL] Fix the exception thrown by Analyze c...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20177 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86506/ Test PASSed. ---

[GitHub] spark issue #20177: [SPARK-22954][SQL] Fix the exception thrown by Analyze c...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20177 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20224: [SPARK-23032][SQL] Add a per-query codegenStageId to Who...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20224 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20224: [SPARK-23032][SQL] Add a per-query codegenStageId to Who...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20224 **[Test build #86516 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86516/testReport)** for PR 20224 at commit [`a7ceda2`](https://github.com/apache/spark/commit/a7

[GitHub] spark issue #20224: [SPARK-23032][SQL] Add a per-query codegenStageId to Who...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20224 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/128/ Test

[GitHub] spark pull request #17702: [SPARK-20408][SQL] Get the glob path in parallel ...

2018-01-22 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/17702#discussion_r163156332 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -668,4 +672,31 @@ object DataSource extends Loggi

[GitHub] spark issue #17702: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17702 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/129/ Test

[GitHub] spark issue #17702: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17702 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #17702: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17702 **[Test build #86517 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86517/testReport)** for PR 17702 at commit [`dc373ae`](https://github.com/apache/spark/commit/dc

[GitHub] spark pull request #20360: [SPARK-23177][SQL][PySpark] Extract zero-paramete...

2018-01-22 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/20360 [SPARK-23177][SQL][PySpark] Extract zero-parameter UDFs from aggregate ## What changes were proposed in this pull request? We extract Python UDFs in logical aggregate which depends on aggreg

[GitHub] spark issue #20360: [SPARK-23177][SQL][PySpark] Extract zero-parameter UDFs ...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20360 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/130/ Test

[GitHub] spark issue #20360: [SPARK-23177][SQL][PySpark] Extract zero-parameter UDFs ...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20360 **[Test build #86518 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86518/testReport)** for PR 20360 at commit [`b6cb621`](https://github.com/apache/spark/commit/b6

<    1   2   3   4   5   6   >