Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/19993
Overall looks good with @jkbradley's changes. I just left a comment on the
param test cases as I think they're not quite complete
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20201
**[Test build #86483 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86483/testReport)**
for PR 20201 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18692
> The point of this issue is not performance improvement, but that some (in
our case automatically generated) queries do not work at all with SPARK,
whereas there is no problem with these queries
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20350#discussion_r163007885
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -237,14 +238,26 @@ final class Decimal extends Ordered[Decimal]
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20350#discussion_r163008946
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -237,14 +238,26 @@ final class Decimal extends Ordered[Decimal] with
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20201
**[Test build #86483 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86483/testReport)**
for PR 20201 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20201
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86483/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20201
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20201#discussion_r163008488
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/Partitioning.java
---
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20201#discussion_r163010318
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/Partitioning.java
---
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20201#discussion_r163008839
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/Partitioning.java
---
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20201#discussion_r163010889
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/sources/v2/JavaPartitionAwareDataSource.java
---
@@ -0,0 +1,110 @@
+/*
+ * Licensed
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20345
**[Test build #86485 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86485/testReport)**
for PR 20345 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20345
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86485/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20345
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20350#discussion_r163013386
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -237,14 +238,26 @@ final class Decimal extends Ordered[Decimal]
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20297#discussion_r163014278
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java ---
@@ -48,14 +48,16 @@ public synchronized void disconnect() {
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20346
Thank you, @HyukjinKwon and @viirya !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20201
LGTM except a few minor comments.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20350
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/107/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20350
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20343#discussion_r163016890
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TPCDSQuerySuite.scala ---
@@ -339,6 +340,24 @@ class TPCDSQuerySuite extends BenchmarkQueryTest {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20350
**[Test build #86488 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86488/testReport)**
for PR 20350 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20201
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/108/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20201
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20201
**[Test build #86489 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86489/testReport)**
for PR 20201 at commit
Github user attilapiros commented on the issue:
https://github.com/apache/spark/pull/20203
Test failure seems to be unrelated as it it is in
org.apache.spark.sql.hive.client.HiveClientSuites.
@squito, @tgravescs could you please restart testing
---
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20343#discussion_r163019362
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TPCDSQuerySuite.scala ---
@@ -244,7 +244,7 @@ class TPCDSQuerySuite extends BenchmarkQueryTest {
501 - 528 of 528 matches
Mail list logo
