Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21815
cc @gengliangwang @cloud-fan This needs a careful review.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21798#discussion_r203946680
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroFileFormat.scala ---
@@ -275,10 +273,12 @@ private[avro] object AvroFileFormat {
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21772
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21772
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93314/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21823
**[Test build #93312 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93312/testReport)**
for PR 21823 at commit
[`2b2a5a3`](https://github.com/apache/spark/commit/2
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21823
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93312/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21823
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21798
LGTM except a comment
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: revi
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21804#discussion_r203947449
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/FeatureHasher.scala ---
@@ -208,8 +208,9 @@ class FeatureHasher(@Since("2.3.0") override val u
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21804#discussion_r203947486
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/HashingTF.scala
---
@@ -104,7 +104,7 @@ class HashingTF @Since("1.4.0") (@Since("1.4.0")
over
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21815#discussion_r203947912
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/FileSourceScanExecSuite.scala
---
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apach
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21815
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apa
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21804
LGTM
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comm
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21804
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21805#discussion_r203949905
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetCacheSuite.scala ---
@@ -206,4 +206,19 @@ class DatasetCacheSuite extends QueryTest with
Share
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r203948972
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ---
@@ -120,11 +121,26 @@ abstract class JdbcDialect extends Serializable
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r203949498
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -105,7 +105,12 @@ object JdbcUtils extends Logg
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20057
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21049
@dilipbiswal Can you take this over?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional command
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21813
**[Test build #93313 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93313/testReport)**
for PR 21813 at commit
[`2ecf3e1`](https://github.com/apache/spark/commit/2
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21823
> so the sql analyzer get the filed of 'key' from the original table 'src',
which is lowercase.
shouldn't we always do it?
---
--
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21813
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93313/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21813
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20057
**[Test build #93322 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93322/testReport)**
for PR 20057 at commit
[`bc75051`](https://github.com/apache/spark/commit/bc
Github user eatoncys commented on the issue:
https://github.com/apache/spark/pull/21823
@cloud-fan Cast 'Key' to lower case is done by rule of ResolveReferences:
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/21049
@gatorsmile Sure.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21813
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21813
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21821
**[Test build #93319 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93319/testReport)**
for PR 21821 at commit
[`9edc28f`](https://github.com/apache/spark/commit/9
501 - 529 of 529 matches
Mail list logo
