Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r214697039
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/DataWritingCommand.scala
---
@@ -53,3 +57,21 @@ trait DataWritingCommand
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22315#discussion_r214647587
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1464,17 +1464,33 @@ case class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22319#discussion_r214659962
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -129,3 +135,12 @@ case class UserDefinedFunction
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22320
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95609/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22315
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22320
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22179
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95613/
Test FAILed.
---
Github user peter-toth commented on a diff in the pull request:
https://github.com/apache/spark/pull/22318#discussion_r214666206
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameJoinSuite.scala ---
@@ -295,4 +295,17 @@ class DataFrameJoinSuite extends QueryTest with
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22179
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22112
**[Test build #95607 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95607/testReport)**
for PR 22112 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22317
**[Test build #95614 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95614/testReport)**
for PR 22317 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22218#discussion_r214675924
--- Diff:
core/src/main/scala/org/apache/spark/executor/ExecutorSource.scala ---
@@ -73,6 +76,28 @@ class ExecutorSource(threadPool: ThreadPoolExecutor,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22317
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95614/
Test PASSed.
---
Github user yifeih closed the pull request at:
https://github.com/apache/spark/pull/21743
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user yifeih commented on the issue:
https://github.com/apache/spark/pull/21743
Ah ok i see, let's close this out then.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22314
**[Test build #95617 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95617/testReport)**
for PR 22314 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22314
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22314
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95617/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22321
**[Test build #95615 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95615/testReport)**
for PR 22321 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22218
**[Test build #4330 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4330/testReport)**
for PR 22218 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21860
**[Test build #95618 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95618/testReport)**
for PR 21860 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22320
**[Test build #95619 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95619/testReport)**
for PR 22320 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22318
**[Test build #95625 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95625/testReport)**
for PR 22318 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/6
**[Test build #95622 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95622/testReport)**
for PR 6 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18906
**[Test build #95624 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95624/testReport)**
for PR 18906 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22179
**[Test build #95623 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95623/testReport)**
for PR 22179 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22319
**[Test build #95626 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95626/testReport)**
for PR 22319 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22320
**[Test build #95620 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95620/testReport)**
for PR 22320 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22314
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22306
**[Test build #95621 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95621/testReport)**
for PR 22306 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22314
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22320
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22319
It's too hard to work around the case class compatibility issue. I'm
leaving it unchanged, and add private mutable variables to store the nullable
info.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22320
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22317#discussion_r214646275
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala
---
@@ -471,9 +473,12 @@ class
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22317#discussion_r214646362
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala
---
@@ -439,6 +439,7 @@ class
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r214646343
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
---
@@ -38,6 +38,20 @@ abstract class QueryPlan[PlanType
Github user peter-toth commented on a diff in the pull request:
https://github.com/apache/spark/pull/22318#discussion_r214666333
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameJoinSuite.scala ---
@@ -295,4 +295,17 @@ class DataFrameJoinSuite extends QueryTest with
Github user szhem commented on the issue:
https://github.com/apache/spark/pull/19410
I've tested the mentioned checkpointers with
`spark.cleaner.referenceTracking.cleanCheckpoints` set to `true` and without
explicit checkpoint files removal.
It seems that there are somewhere
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21638#discussion_r214685953
--- Diff:
core/src/main/scala/org/apache/spark/input/PortableDataStream.scala ---
@@ -47,7 +47,7 @@ private[spark] abstract class StreamFileInputFormat[T]
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22318#discussion_r214689183
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -805,10 +807,10 @@ class Analyzer(
*
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21968#discussion_r214691997
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/RowBasedHashMapGenerator.scala
---
@@ -48,6 +48,8 @@ class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22306
**[Test build #95612 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95612/testReport)**
for PR 22306 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22179
**[Test build #95613 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95613/testReport)**
for PR 22179 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22179
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22318
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22306
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user steveloughran commented on the issue:
https://github.com/apache/spark/pull/17745
Patch is in the spark cloud integration module, you can take it and try to
get into ASF spark provided you also add some credit to me in the patch.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22179
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22179
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22306
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22320
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22320
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22319
**[Test build #95626 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95626/testReport)**
for PR 22319 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22319
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95626/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22263
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22320
**[Test build #95627 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95627/testReport)**
for PR 22320 at commit
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r214694881
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala
---
@@ -69,7 +69,7 @@ case class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22263
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22204
Thank you, @maropu . BTW, if this PR aims to provide `ANALYZE` command
interface to users, could you update the PR content and test cases for that?
---
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22204
ok, I'll do that.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22321
Thank you for your first contribution, @kisimple . As @kiszk mentioned,
could you fix those files, too?
---
-
To
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22315
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21860
cc: @cloud-fan @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22319
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22319
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22319
**[Test build #95644 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95644/testReport)**
for PR 22319 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22315
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95638/
Test PASSed.
---
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/22324
[SPARK-25237][SQL] Remove updateBytesReadWithFileSize in FileScanRDD
## What changes were proposed in this pull request?
This pr removed the method `updateBytesReadWithFileSize` in `FileScanRDD`
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22179
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22240
**[Test build #95642 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95642/testReport)**
for PR 22240 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22321
Mind fixing the PR title as well since we fix other broken links too.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22325
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user rezasafi opened a pull request:
https://github.com/apache/spark/pull/22325
[SPARK-25318]. Add exception handling when wrapping the input stream during
the the fetch or stage retry in response to a corrupted block
SPARK-4105 provided a solution to block corruption issue
Github user xuejianbest commented on a diff in the pull request:
https://github.com/apache/spark/pull/22048#discussion_r214778257
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2794,6 +2794,30 @@ private[spark] object Utils extends Logging {
}
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22313#discussion_r214778262
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala
---
@@ -383,4 +386,13 @@ class OrcFilterSuite
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22325
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22325
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22313
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95637/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22313
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22313
**[Test build #95637 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95637/testReport)**
for PR 22313 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22313#discussion_r214765115
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilters.scala
---
@@ -71,12 +71,24 @@ private[orc] object OrcFilters
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22313#discussion_r214769029
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala
---
@@ -383,4 +386,13 @@ class OrcFilterSuite
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22179
**[Test build #95646 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95646/testReport)**
for PR 22179 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22179
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22240
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95642/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22240
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22313#discussion_r214775155
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilters.scala
---
@@ -71,12 +71,24 @@ private[orc] object
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22324#discussion_r214776872
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceSuite.scala
---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22240
**[Test build #95648 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95648/testReport)**
for PR 22240 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22240
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22240
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22324
we can credit to multiple people now though :-)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22321
**[Test build #95647 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95647/testReport)**
for PR 22321 at commit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22313#discussion_r214778954
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilters.scala
---
@@ -71,12 +71,24 @@ private[orc] object
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22179
**[Test build #95643 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95643/testReport)**
for PR 22179 at commit
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r214751309
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
---
@@ -805,6 +805,80 @@ class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22313
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22313
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22315
**[Test build #95638 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95638/testReport)**
for PR 22315 at commit
201 - 300 of 485 matches
Mail list logo