[GitHub] spark issue #22305: [WIP][SPARK-24561][SQL][Python] User-defined window aggr...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22305 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22305: [WIP][SPARK-24561][SQL][Python] User-defined window aggr...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22305 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96260/ Test PASSed. ---

[GitHub] spark issue #22448: [SPARK-25417][SQL] Improve findTightestCommonType to coe...

2018-09-19 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/22448 > Do you know the reason for it ? It is better to ask @HyukjinKwon > Seems like we may need to refactor to see if we can avoid duplicating findTightestCommonType here ? Can we

[GitHub] spark issue #22472: [SPARK-23173][SQL] Reverting of spark.sql.fromJsonForceN...

2018-09-19 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/22472 > Let's not mix the reverting and adding a deprecation note ok. I will revert the last commit from the PR. > Also, SPARK-25384 is about Removing

[GitHub] spark issue #22470: [SPARK-25454][SQL] should not generate negative scale as...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22470 **[Test build #96271 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96271/testReport)** for PR 22470 at commit

[GitHub] spark issue #22470: [SPARK-25454][SQL] should not generate negative scale as...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22470 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22470: [SPARK-25454][SQL] should not generate negative scale as...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22470 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96271/ Test FAILed. ---

[GitHub] spark issue #22472: [SPARK-23173][SQL] Reverting of spark.sql.fromJsonForceN...

2018-09-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22472 The reverting PR title is usually `Revert "[SPARK-23173][SQL] rename spark.sql.fromJsonForceNullableSchema"` --- - To

[GitHub] spark pull request #22474: [SPARK-25425][SQL][BACKPORT-2.4] Extra options sh...

2018-09-19 Thread MaxGekk
GitHub user MaxGekk opened a pull request: https://github.com/apache/spark/pull/22474 [SPARK-25425][SQL][BACKPORT-2.4] Extra options should override session options in DataSource V2 ## What changes were proposed in this pull request? In the PR, I propose overriding session

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-19 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218939333 --- Diff: common/network-common/src/main/java/org/apache/spark/network/TransportContext.java --- @@ -98,21 +98,32 @@ public TransportContext(

[GitHub] spark issue #22474: [SPARK-25425][SQL][BACKPORT-2.4] Extra options should ov...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22474 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22474: [SPARK-25425][SQL][BACKPORT-2.4] Extra options should ov...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22474 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22474: [SPARK-25425][SQL][BACKPORT-2.4] Extra options should ov...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22474 **[Test build #96282 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96282/testReport)** for PR 22474 at commit

[GitHub] spark issue #22473: [SPARK-25449][CORE] Heartbeat shouldn't include accumula...

2018-09-19 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/22473 add to whitelist --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22173: [SPARK-24335] Spark external shuffle server improvement ...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22173 **[Test build #96283 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96283/testReport)** for PR 22173 at commit

[GitHub] spark issue #22413: [SPARK-25425][SQL] Extra options should override session...

2018-09-19 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/22413 @dongjoon-hyun Here is the PR for 2.4: https://github.com/apache/spark/pull/22474 . I will check does it have conflicts in 2.3 and if so, I will backport it to 2.3 ---

[GitHub] spark pull request #22473: [SPARK-25449][CORE] Heartbeat shouldn't include a...

2018-09-19 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/22473#discussion_r218941326 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -799,7 +799,8 @@ private[spark] class Executor( if (taskRunner.task

[GitHub] spark issue #22473: [SPARK-25449][CORE] Heartbeat shouldn't include accumula...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22473 **[Test build #96284 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96284/testReport)** for PR 22473 at commit

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-19 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218942035 --- Diff: common/network-common/src/main/java/org/apache/spark/network/TransportContext.java --- @@ -77,17 +82,54 @@ private static final

[GitHub] spark issue #16677: [SPARK-19355][SQL] Use map output statistics to improve ...

2018-09-19 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/16677 I understood the two major concerns regarding this change. I'm going to submit a pr to revert the change. I will look into this idea further with new design. ---

[GitHub] spark pull request #19810: [SPARK-22599][SQL] In-Memory Table Pruning withou...

2018-09-19 Thread eyalfa
Github user eyalfa commented on a diff in the pull request: https://github.com/apache/spark/pull/19810#discussion_r218704390 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala --- @@ -52,6 +52,68 @@ object InMemoryRelation {

[GitHub] spark pull request #19810: [SPARK-22599][SQL] In-Memory Table Pruning withou...

2018-09-19 Thread eyalfa
Github user eyalfa commented on a diff in the pull request: https://github.com/apache/spark/pull/19810#discussion_r218705219 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala --- @@ -193,38 +195,68 @@ case class

[GitHub] spark pull request #22138: [SPARK-25151][SS] Apply Apache Commons Pool to Ka...

2018-09-19 Thread gaborgsomogyi
Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/22138#discussion_r218709909 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/InternalKafkaConsumerPool.scala --- @@ -0,0 +1,243 @@ +/* + *

[GitHub] spark issue #22449: [SPARK-22666][ML][FOLLOW-UP] Improve testcase to tolerat...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22449 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96239/ Test FAILed. ---

[GitHub] spark issue #22449: [SPARK-22666][ML][FOLLOW-UP] Improve testcase to tolerat...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22449 **[Test build #96239 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96239/testReport)** for PR 22449 at commit

[GitHub] spark issue #22449: [SPARK-22666][ML][FOLLOW-UP] Improve testcase to tolerat...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22449 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19810: [SPARK-22599][SQL] In-Memory Table Pruning withou...

2018-09-19 Thread eyalfa
Github user eyalfa commented on a diff in the pull request: https://github.com/apache/spark/pull/19810#discussion_r218714493 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/CachedColumnarRDD.scala --- @@ -0,0 +1,99 @@ +/* + * Licensed to the

[GitHub] spark issue #22449: [SPARK-22666][ML][FOLLOW-UP] Improve testcase to tolerat...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22449 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22449: [SPARK-22666][ML][FOLLOW-UP] Improve testcase to tolerat...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22449 **[Test build #96239 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96239/testReport)** for PR 22449 at commit

[GitHub] spark issue #22449: [SPARK-22666][ML][FOLLOW-UP] Improve testcase to tolerat...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22449 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request #22138: [SPARK-25151][SS] Apply Apache Commons Pool to Ka...

2018-09-19 Thread gaborgsomogyi
Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/22138#discussion_r218699852 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/FetchedPoolSuite.scala --- @@ -0,0 +1,299 @@ +/* + * Licensed

[GitHub] spark issue #22433: [SPARK-25442][SQL][K8S] Support STS to run in k8s deploy...

2018-09-19 Thread nrchakradhar
Github user nrchakradhar commented on the issue: https://github.com/apache/spark/pull/22433 This PR is now same as [PR-20272](https://github.com/apache/spark/pull/20272). The conversation in [PR-20272](https://github.com/apache/spark/pull/20272), has some useful information which

[GitHub] spark pull request #19810: [SPARK-22599][SQL] In-Memory Table Pruning withou...

2018-09-19 Thread eyalfa
Github user eyalfa commented on a diff in the pull request: https://github.com/apache/spark/pull/19810#discussion_r218716111 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/CachedColumnarRDD.scala --- @@ -0,0 +1,99 @@ +/* + * Licensed to the

[GitHub] spark pull request #22138: [SPARK-25151][SS] Apply Apache Commons Pool to Ka...

2018-09-19 Thread gaborgsomogyi
Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/22138#discussion_r218719952 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaDataConsumer.scala --- @@ -18,222 +18,247 @@ package

[GitHub] spark issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaData...

2018-09-19 Thread gaborgsomogyi
Github user gaborgsomogyi commented on the issue: https://github.com/apache/spark/pull/22138 No objection about `org.apache.commons.pool2.impl.GenericKeyedObjectPool` stuff but just wondering why `org.apache.spark.sql.kafka010.CachedKafkaProducer` uses

[GitHub] spark pull request #22464: Revert [SPARK-19355][SPARK-25352]

2018-09-19 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/22464 Revert [SPARK-19355][SPARK-25352] ## What changes were proposed in this pull request? This goes to revert [SPARK-19355](https://github.com/apache/spark/pull/16677) and

[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]

2018-09-19 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22464 cc @cloud-fan @rxin @hvanhovell --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #22138: [SPARK-25151][SS] Apply Apache Commons Pool to Ka...

2018-09-19 Thread gaborgsomogyi
Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/22138#discussion_r218725548 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/InternalKafkaConsumerPool.scala --- @@ -0,0 +1,241 @@ +/* + *

[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22464 **[Test build #96240 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96240/testReport)** for PR 22464 at commit

[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22464 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22464 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22449: [SPARK-22666][ML][FOLLOW-UP] Improve testcase to tolerat...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22449 **[Test build #96241 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96241/testReport)** for PR 22449 at commit

[GitHub] spark issue #22449: [SPARK-22666][ML][FOLLOW-UP] Improve testcase to tolerat...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22449 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22449: [SPARK-22666][ML][FOLLOW-UP] Improve testcase to tolerat...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22449 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19810: [SPARK-22599][SQL] In-Memory Table Pruning without Extra...

2018-09-19 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/19810 @CodingCat Is this still active? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #19810: [SPARK-22599][SQL] In-Memory Table Pruning withou...

2018-09-19 Thread eyalfa
Github user eyalfa commented on a diff in the pull request: https://github.com/apache/spark/pull/19810#discussion_r218743585 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/CachedColumnarRDD.scala --- @@ -0,0 +1,99 @@ +/* + * Licensed to the

[GitHub] spark issue #19868: [SPARK-22676] Avoid iterating all partition paths when s...

2018-09-19 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19868 We switched to a totally different approach in the middle and forgot to update the PR description... @jinxing64 can you update it? thanks! ---

[GitHub] spark issue #22381: [SPARK-25394][CORE] Add an application status metrics so...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22381 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96215/ Test PASSed. ---

[GitHub] spark issue #22381: [SPARK-25394][CORE] Add an application status metrics so...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22381 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22450: [SPARK-25454][SQL] Avoid precision loss in division with...

2018-09-19 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22450 cc @cloud-fan @dongjoon-hyun --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22463: remove annotation @Experimental

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22463 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22450: [SPARK-25454][SQL] Avoid precision loss in division with...

2018-09-19 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22450 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22451: [SPARK-24777][SQL] Add write benchmark for AVRO

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22451 **[Test build #96217 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96217/testReport)** for PR 22451 at commit

[GitHub] spark pull request #22456: [SPARK-19355][SQL] Fix variable names numberOfOut...

2018-09-19 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22456#discussion_r218685917 --- Diff: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala --- @@ -31,7 +31,7 @@ import org.apache.spark.util.Utils /** *

[GitHub] spark issue #22454: [SPARK-25445][BUILD][FOLLOWUP] Resolve issues in release...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22454 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22454: [SPARK-25445][BUILD][FOLLOWUP] Resolve issues in release...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22454 **[Test build #96227 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96227/testReport)** for PR 22454 at commit

[GitHub] spark issue #21632: [SPARK-19591][ML][MLlib] Add sample weights to decision ...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21632 **[Test build #96219 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96219/testReport)** for PR 21632 at commit

[GitHub] spark issue #22447: [SPARK-25450][SQL] PushProjectThroughUnion rule uses the...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22447 **[Test build #96221 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96221/testReport)** for PR 22447 at commit

[GitHub] spark issue #22461: [SPARK-25453][SQL][TEST] OracleIntegrationSuite IllegalA...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22461 **[Test build #96228 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96228/testReport)** for PR 22461 at commit

[GitHub] spark issue #22450: [SPARK-25454][SQL] Avoid precision loss in division with...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22450 **[Test build #96229 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96229/testReport)** for PR 22450 at commit

[GitHub] spark pull request #22450: [SPARK-25454][SQL] Avoid precision loss in divisi...

2018-09-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22450#discussion_r218688998 --- Diff: sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/decimalArithmeticOperations.sql --- @@ -83,4 +83,7 @@ select

[GitHub] spark issue #22450: [SPARK-25454][SQL] Avoid precision loss in division with...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22450 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22450: [SPARK-25454][SQL] Avoid precision loss in division with...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22450 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22448: [SPARK-25417][SQL] Improve findTightestCommonType to coe...

2018-09-19 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/22448 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22447: [SPARK-25450][SQL] PushProjectThroughUnion rule uses the...

2018-09-19 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/22447 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22461: [SPARK-25453][SQL][TEST] OracleIntegrationSuite IllegalA...

2018-09-19 Thread seancxmao
Github user seancxmao commented on the issue: https://github.com/apache/spark/pull/22461 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22443: [SPARK-25339][TEST] Refactor FilterPushdownBenchmark

2018-09-19 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/22443 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22462: [SPARK-25460][SS] DataSourceV2: SS sources do not respec...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22462 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22448: [SPARK-25417][SQL] Improve findTightestCommonType to coe...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22448 **[Test build #96232 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96232/testReport)** for PR 22448 at commit

[GitHub] spark issue #22461: [SPARK-25453][SQL][TEST] OracleIntegrationSuite IllegalA...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22461 **[Test build #96231 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96231/testReport)** for PR 22461 at commit

[GitHub] spark issue #22448: [SPARK-25417][SQL] Improve findTightestCommonType to coe...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22448 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22443: [SPARK-25339][TEST] Refactor FilterPushdownBenchmark

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22443 **[Test build #96234 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96234/testReport)** for PR 22443 at commit

[GitHub] spark issue #22462: [SPARK-25460][SS] DataSourceV2: SS sources do not respec...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22462 **[Test build #96230 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96230/testReport)** for PR 22462 at commit

[GitHub] spark pull request #22450: [SPARK-25454][SQL] Avoid precision loss in divisi...

2018-09-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22450#discussion_r218690339 --- Diff: sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/decimalArithmeticOperations.sql --- @@ -83,4 +83,7 @@ select

[GitHub] spark issue #21632: [SPARK-19591][ML][MLlib] Add sample weights to decision ...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21632 **[Test build #96235 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96235/testReport)** for PR 21632 at commit

[GitHub] spark issue #22447: [SPARK-25450][SQL] PushProjectThroughUnion rule uses the...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22447 **[Test build #96233 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96233/testReport)** for PR 22447 at commit

[GitHub] spark issue #22450: [SPARK-25454][SQL] Avoid precision loss in division with...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22450 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22450: [SPARK-25454][SQL] Avoid precision loss in division with...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22450 **[Test build #96237 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96237/testReport)** for PR 22450 at commit

[GitHub] spark issue #22454: [SPARK-25445][BUILD][FOLLOWUP] Resolve issues in release...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22454 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22449: [SPARK-22666][ML][FOLLOW-UP] Return a correctly formatte...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22449 **[Test build #96238 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96238/testReport)** for PR 22449 at commit

[GitHub] spark issue #22454: [SPARK-25445][BUILD][FOLLOWUP] Resolve issues in release...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22454 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22454: [SPARK-25445][BUILD][FOLLOWUP] Resolve issues in release...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22454 **[Test build #96236 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96236/testReport)** for PR 22454 at commit

[GitHub] spark issue #22449: [SPARK-22666][ML][FOLLOW-UP] Return a correctly formatte...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22449 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96238/ Test FAILed. ---

[GitHub] spark issue #22449: [SPARK-22666][ML][FOLLOW-UP] Return a correctly formatte...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22449 **[Test build #96238 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96238/testReport)** for PR 22449 at commit

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-09-19 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r218677837 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -665,3 +667,219 @@ case class

[GitHub] spark issue #22381: [SPARK-25394][CORE] Add an application status metrics so...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22381 **[Test build #96215 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96215/testReport)** for PR 22381 at commit

[GitHub] spark issue #22429: [SPARK-25440][SQL] Dumping query execution info to a fil...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22429 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22429: [SPARK-25440][SQL] Dumping query execution info to a fil...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22429 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96214/ Test PASSed. ---

[GitHub] spark issue #22165: [SPARK-25017][Core] Add test suite for BarrierCoordinato...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22165 **[Test build #96216 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96216/testReport)** for PR 22165 at commit

[GitHub] spark issue #22165: [SPARK-25017][Core] Add test suite for BarrierCoordinato...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22165 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96216/ Test PASSed. ---

[GitHub] spark issue #22165: [SPARK-25017][Core] Add test suite for BarrierCoordinato...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22165 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22463: remove annotation @Experimental

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22463 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22375: [SPARK-25388][Test][SQL] Detect incorrect nullabl...

2018-09-19 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22375#discussion_r218686614 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelperSuite.scala --- @@ -35,6 +36,13 @@ class

[GitHub] spark issue #22450: [SPARK-25454][SQL] Avoid precision loss in division with...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22450 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96226/ Test FAILed. ---

[GitHub] spark issue #22461: [SPARK-25453][SQL][TEST] OracleIntegrationSuite IllegalA...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22461 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96224/ Test FAILed. ---

[GitHub] spark issue #22443: [SPARK-25339][TEST] Refactor FilterPushdownBenchmark

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22443 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22461: [SPARK-25453][SQL][TEST] OracleIntegrationSuite IllegalA...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22461 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22462: [SPARK-25460][SS] DataSourceV2: SS sources do not respec...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22462 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22450: [SPARK-25454][SQL] Avoid precision loss in division with...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22450 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22448: [SPARK-25417][SQL] Improve findTightestCommonType to coe...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22448 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96222/ Test FAILed. ---

<    3   4   5   6   7   8   9   10   >