Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22788#discussion_r229538040
--- Diff:
sql/core/src/test/resources/sql-tests/results/columnresolution-negative.sql.out
---
@@ -161,7 +161,7 @@ SELECT db1.t1.i1 FROM t1, mydb2.t1
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22847#discussion_r229538148
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -812,6 +812,17 @@ object SQLConf {
.intConf
.cr
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22713
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22895#discussion_r229539055
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroDataToCatalyst.scala
---
@@ -100,9 +100,14 @@ case class AvroDataToCatalyst(
Github user patrickbrownsync commented on a diff in the pull request:
https://github.com/apache/spark/pull/22883#discussion_r229539016
--- Diff:
core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ---
@@ -1105,6 +1095,15 @@ private[spark] class AppStatusListener(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22895#discussion_r229539289
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroDataToCatalyst.scala
---
@@ -100,9 +100,14 @@ case class AvroDataToCatalyst(
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22713
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22847
**[Test build #98288 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98288/testReport)**
for PR 22847 at commit
[`ba392c8`](https://github.com/apache/spark/commit/ba
Github user yucai commented on the issue:
https://github.com/apache/spark/pull/22847
@cloud-fan @dongjoon-hyun @kiszk I just add a negative check, maybe we need
another PR to figure better value later if it is not easy to decide now.
---
-
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22608
**[Test build #98281 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98281/testReport)**
for PR 22608 at commit
[`0de8c87`](https://github.com/apache/spark/commit/0
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22608
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22608
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98281/
Test PASSed.
---
Github user yucai commented on the issue:
https://github.com/apache/spark/pull/22879
`tpcdsQueries` and `tpcdsQueriesV2_7` are duplicated to
`TPCDSQueryBenchmark`'s, should we maintain them together?
---
-
To unsubs
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22844
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22844
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22896
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22896
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22896
@shaneknapp, I just got this in since that's orthogonal to this PR :-) .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@sp
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22275
**[Test build #98284 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98284/testReport)**
for PR 22275 at commit
[`7d19977`](https://github.com/apache/spark/commit/7
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22275
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22275
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98284/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21860
**[Test build #98287 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98287/testReport)**
for PR 21860 at commit
[`8f5eb2b`](https://github.com/apache/spark/commit/8
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21860
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21860
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98287/
Test FAILed.
---
Github user shaneknapp commented on the issue:
https://github.com/apache/spark/pull/22896
thanks @HyukjinKwon !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: revi
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/22864
Hi @gengliangwang , Yes the parameter is not used from the beginning.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22844
Thank you, @heary-cao , @yucai , @wangyum , and @HyukjinKwon .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apac
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22275
**[Test build #98285 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98285/testReport)**
for PR 22275 at commit
[`6457e42`](https://github.com/apache/spark/commit/6
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22275
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98285/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22275
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22895#discussion_r229553381
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroDataToCatalyst.scala
---
@@ -100,9 +100,14 @@ case class AvroDataToCatalyst(
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22895#discussion_r229553580
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroDataToCatalyst.scala
---
@@ -100,9 +100,14 @@ case class AvroDataToCatalyst(
Github user shaneknapp commented on the issue:
https://github.com/apache/spark/pull/22896
actually can we merge this? it's causing spurious lintr errors.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apach
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22482
**[Test build #98289 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98289/testReport)**
for PR 22482 at commit
[`c03c946`](https://github.com/apache/spark/commit/c0
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21860
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21860
**[Test build #98290 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98290/testReport)**
for PR 21860 at commit
[`5deb39b`](https://github.com/apache/spark/commit/5d
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22870
LGTM Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-m
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22883
Seems reasonable. Ping @vanzin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22870
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22896
@shaneknapp, I already merged this into master branch
(https://github.com/apache/spark/commit/243ce319a06f20365d5b08d479642d75748645d9)
:-). AppVeyor tests were passed
(https://ci.appveyor.com/
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22895#discussion_r229562284
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroDataToCatalyst.scala
---
@@ -100,9 +100,14 @@ case class AvroDataToCatalyst(
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22891
I don't think we should map decimals to float. It will loses precisions and
it's a breaking change.
---
-
To unsubscribe, e-
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22895#discussion_r229563086
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroDataToCatalyst.scala
---
@@ -100,9 +100,14 @@ case class AvroDataToCatalyst(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22895#discussion_r229563551
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroDataToCatalyst.scala
---
@@ -100,9 +100,14 @@ case class AvroDataToCatalyst(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22891#discussion_r229564044
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -2064,6 +2064,7 @@ def toDF(self, *cols):
@since(1.3)
def toPandas(self):
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22895#discussion_r229564121
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroDataToCatalyst.scala
---
@@ -100,9 +100,14 @@ case class AvroDataToCatalyst(
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22847
**[Test build #98288 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98288/testReport)**
for PR 22847 at commit
[`ba392c8`](https://github.com/apache/spark/commit/b
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22847
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98288/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22847
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22895
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22895
**[Test build #98291 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98291/testReport)**
for PR 22895 at commit
[`24244cc`](https://github.com/apache/spark/commit/24
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22895
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4646/
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/22898
[SPARK-25746][SQL][followup] do not add unnecessary If expression
## What changes were proposed in this pull request?
a followup of https://github.com/apache/spark/pull/22749.
Wh
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22898
cc @viirya
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@sp
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22898
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22898
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4647/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22898
**[Test build #98292 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98292/testReport)**
for PR 22898 at commit
[`8266443`](https://github.com/apache/spark/commit/82
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22868
Merged to `master` since we are voting now. We can have this later to
`branch-2.4/branch-2.3`.
---
-
To unsubscribe, e-mai
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22847#discussion_r229572426
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -812,6 +812,18 @@ object SQLConf {
.intConf
.c
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22868
Thank you all!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22868
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22899
cc @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/22899
[SPARK-25573] Combine resolveExpression and resolve in the Analyzer
## What changes were proposed in this pull request?
Currently in the Analyzer, we have two methods 1) Resolve
2)ResolveEx
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22899
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4648/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22899
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22778
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4649/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22778
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22899
**[Test build #98293 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98293/testReport)**
for PR 22899 at commit
[`ff37569`](https://github.com/apache/spark/commit/ff
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22778
**[Test build #98294 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98294/testReport)**
for PR 22778 at commit
[`80bf621`](https://github.com/apache/spark/commit/80
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22847
**[Test build #98295 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98295/testReport)**
for PR 22847 at commit
[`2fc6417`](https://github.com/apache/spark/commit/2f
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/22900
[SPARK-25618][SQL][TEST] Reduce time taken to execute
KafkaContinuousSourceStressForDontFailOnDataLossSuite
## What changes were proposed in this pull request?
In this test, i have reduced
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22900
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22900
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4650/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22900
**[Test build #98296 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98296/testReport)**
for PR 22900 at commit
[`5a6907c`](https://github.com/apache/spark/commit/5a
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22847#discussion_r229577345
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -812,6 +812,17 @@ object SQLConf {
.intConf
.create
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22881#discussion_r229577581
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala
---
@@ -471,4 +472,33 @@ object SparkHadoopUtil {
hadoopConf.se
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22847#discussion_r229577559
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -812,6 +812,18 @@ object SQLConf {
.intConf
.create
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22788#discussion_r229577806
--- Diff:
sql/core/src/test/resources/sql-tests/results/columnresolution-negative.sql.out
---
@@ -161,7 +161,7 @@ SELECT db1.t1.i1 FROM t1, mydb2.t1
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22788#discussion_r229578738
--- Diff:
sql/core/src/test/resources/sql-tests/results/columnresolution-negative.sql.out
---
@@ -161,7 +161,7 @@ SELECT db1.t1.i1 FROM t1, mydb2.t1
Github user WangTaoTheTonic commented on the issue:
https://github.com/apache/spark/pull/22575
Nice! I am looking forward to it.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22900
**[Test build #98296 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98296/testReport)**
for PR 22900 at commit
[`5a6907c`](https://github.com/apache/spark/commit/5
401 - 481 of 481 matches
Mail list logo
