Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23052
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23034
Thank you @BryanCutler.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/23054
[SPARK-26085][SQL] Key attribute of primitive type under typed aggregation
should be named as "key" too
## What changes were proposed in this pull request?
When doing typed aggregation on
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/23054
cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23038
**[Test build #98894 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98894/testReport)**
for PR 23038 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23031
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23031
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user shaneknapp commented on the issue:
https://github.com/apache/spark/pull/23026
> > if such a list exists it should be the same list that triggers regular
tests.
>
> I defer that to @shaneknapp
no, @vanzin is right. i'll update that tomorrow.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23056#discussion_r234080468
--- Diff: python/pyspark/mllib/tests/test_linalg.py ---
@@ -0,0 +1,642 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23056
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/23055#discussion_r234080578
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala ---
@@ -74,8 +74,13 @@ private[spark] abstract class BasePythonRunner[IN, OUT](
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23056
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23056#discussion_r234080249
--- Diff: python/pyspark/testing/mllibutils.py ---
@@ -0,0 +1,44 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23055#discussion_r234081475
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala ---
@@ -74,8 +74,13 @@ private[spark] abstract class BasePythonRunner[IN,
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/23049
Hi @vanzin ,
thanks for pointing it out! I have updated the script and PR description.
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23046#discussion_r234088968
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala
---
@@ -280,7 +280,7 @@ object ShuffleExchangeExec {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23045
**[Test build #98901 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98901/testReport)**
for PR 23045 at commit
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/23034
> Also, @BryanCutler, I think we can talk about locations of
testing/...util.py later when we finished to split the tests. Moving utils
would probably cause less conflicts and should be good
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23052#discussion_r234062564
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala
---
@@ -174,13 +174,18 @@ private[csv] class
Github user carsonwang commented on the issue:
https://github.com/apache/spark/pull/20303
@cloud-fan @gatorsmile , are you ready to start reviewing this? I can bring
this update to date.
---
-
To unsubscribe,
Github user shahidki31 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23038#discussion_r234072070
--- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala ---
@@ -63,6 +63,7 @@ case class ApplicationAttemptInfo private[spark](
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23038
**[Test build #98893 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98893/testReport)**
for PR 23038 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23046#discussion_r234073703
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala
---
@@ -280,7 +280,7 @@ object ShuffleExchangeExec
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23026
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23026
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user BryanCutler opened a pull request:
https://github.com/apache/spark/pull/23056
[SPARK-26034][PYTHON][TESTS] Break large mllib/tests.py file into smaller
files
## What changes were proposed in this pull request?
This PR breaks down the large mllib/tests.py file
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/23056
Dist by line count:
```
313 ./test_algorithms.py
201 ./test_feature.py
642 ./test_linalg.py
197 ./test_stat.py
523 ./test_streaming_algorithms.py
115 ./test_util.py
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23037
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23037
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/23055
Thanks for fixing this so quickly, @HyukjinKwon! I'd like a couple of
changes, but overall it is going in the right direction.
We should also plan on porting this to the 2.4 branch when it
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23056
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23056
**[Test build #98898 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98898/testReport)**
for PR 23056 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22309
adding @liancheng BTW. IIRC, he took a look for this one before and
abandoned the change (fix me if I'm wrongly remembering this).
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23044
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/23056#discussion_r234093063
--- Diff: python/pyspark/testing/mllibutils.py ---
@@ -0,0 +1,44 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23054
**[Test build #98891 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98891/testReport)**
for PR 23054 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23055
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23055
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/23025#discussion_r234071565
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2813,6 +2819,11 @@ class Dataset[T] private[sql](
* When no explicit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22598
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22598
**[Test build #98890 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98890/testReport)**
for PR 22598 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22598
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98890/
Test FAILed.
---
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23046#discussion_r234073072
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala
---
@@ -280,7 +280,7 @@ object ShuffleExchangeExec {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23031
**[Test build #98896 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98896/testReport)**
for PR 23031 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23041
**[Test build #4427 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4427/testReport)**
for PR 23041 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23049
**[Test build #98899 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98899/testReport)**
for PR 23049 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23049
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23049
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user mt40 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22309#discussion_r234085471
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -373,6 +383,32 @@ object ScalaReflection extends
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23046
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23054
makes sense to me. This is a behavior change right? Shall we write a
migration guide?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23054
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23054
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23054
**[Test build #98891 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98891/testReport)**
for PR 23054 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23056
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23056
**[Test build #98897 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98897/testReport)**
for PR 23056 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23056
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98897/
Test FAILed.
---
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/23055#discussion_r234080290
--- Diff: python/pyspark/worker.py ---
@@ -268,9 +272,11 @@ def main(infile, outfile):
# set up memory limits
memory_limit_mb
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23049
**[Test build #98900 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98900/testReport)**
for PR 23049 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23055#discussion_r234086569
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala ---
@@ -74,8 +74,13 @@ private[spark] abstract class BasePythonRunner[IN,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23042#discussion_r234091858
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -138,6 +138,11 @@ object TypeCoercion {
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23044
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23054
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/23054
Ok. Let me update migration guide.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23054
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98891/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23045
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23045
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23054
**[Test build #98902 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98902/testReport)**
for PR 23054 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23046#discussion_r234063905
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala
---
@@ -280,7 +280,7 @@ object ShuffleExchangeExec
Github user AzureQ commented on the issue:
https://github.com/apache/spark/pull/23037
> > This is fine, but please file a bug.
>
> Okay, as such, @AzureQ could you add an integration test to
`ClientModeTestsSuite`
Sure
---
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/23025#discussion_r234071213
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2813,6 +2819,11 @@ class Dataset[T] private[sql](
* When no explicit
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/23055
[SPARK-26080][SQL] Disable 'spark.executor.pyspark.memory' always on Windows
## What changes were proposed in this pull request?
`resource` package is a Unit specific package. See
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23055
**[Test build #98892 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98892/testReport)**
for PR 23055 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23055
cc @rdblue, @vanzin and @haydenjeune
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23038
**[Test build #98895 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98895/testReport)**
for PR 23038 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23056
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23056
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/23056
cc @HyukjinKwon @squito
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23056
**[Test build #98897 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98897/testReport)**
for PR 23056 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23049
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23049
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/23055#discussion_r234084002
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala ---
@@ -74,8 +74,13 @@ private[spark] abstract class BasePythonRunner[IN, OUT](
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23046
thanks, merging to master/2.4!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23054
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23054
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23043
IIUC, we discussed handling `+0.0` and `-0.0` before in another PR.
@srowen do you remember the previous discussion?
---
-
To
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23044
LGTM, pending Jenkins
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23043
@kiszk This spun out of https://issues.apache.org/jira/browse/SPARK-24834
and https://github.com/apache/spark/pull/21794 ; is that what you may be
thinking of? I'm not aware of others.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23050
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23050
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23049
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23049
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98879/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23049
**[Test build #98876 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98876/testReport)**
for PR 23049 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23040
**[Test build #98878 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98878/testReport)**
for PR 23040 at commit
Github user rezasafi commented on the issue:
https://github.com/apache/spark/pull/22612
@squito @mccheah @dhruve Let me know if there are more comments or this
can be merged. I appreciate it.
---
-
To unsubscribe,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23031
**[Test build #98896 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98896/testReport)**
for PR 23031 at commit
Github user JulienPeloton commented on a diff in the pull request:
https://github.com/apache/spark/pull/23025#discussion_r234099956
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2813,6 +2819,11 @@ class Dataset[T] private[sql](
* When no
Github user JulienPeloton commented on a diff in the pull request:
https://github.com/apache/spark/pull/23025#discussion_r234099934
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2813,6 +2819,11 @@ class Dataset[T] private[sql](
* When no
Github user gengliangwang closed the pull request at:
https://github.com/apache/spark/pull/23047
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23038
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
201 - 300 of 453 matches
Mail list logo
