Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23207
**[Test build #99677 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99677/testReport)**
for PR 23207 at commit
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23207#discussion_r238836448
--- Diff: core/src/main/scala/org/apache/spark/shuffle/metrics.scala ---
@@ -50,3 +50,57 @@ private[spark] trait ShuffleWriteMetricsReporter {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23217
**[Test build #99680 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99680/testReport)**
for PR 23217 at commit
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23196#discussion_r238853314
--- Diff:
sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala
---
@@ -49,8 +49,8 @@ class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23215
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23218
**[Test build #4452 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4452/testReport)**
for PR 23218 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23169
**[Test build #99686 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99686/testReport)**
for PR 23169 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23169
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23169
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22612
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99684/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22612
**[Test build #99684 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99684/testReport)**
for PR 22612 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22612
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23203#discussion_r238887812
--- Diff: python/run-tests.py ---
@@ -93,17 +93,18 @@ def run_individual_python_test(target_dir, test_name,
pyspark_python):
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/23220
[SPARK-25877][k8s] Move all feature logic to feature classes.
This change makes the driver and executor builders a lot simpler
by encapsulating almost all feature logic into the respective
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23220
**[Test build #99687 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99687/testReport)**
for PR 23220 at commit
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22721#discussion_r238891454
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/CommandUtils.scala
---
@@ -45,6 +45,8 @@ object CommandUtils extends Logging {
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22721
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22721
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23220
**[Test build #99687 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99687/testReport)**
for PR 23220 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23220
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99687/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23108
**[Test build #99688 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99688/testReport)**
for PR 23108 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23220
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5739/
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23220
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22721
**[Test build #99689 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99689/testReport)**
for PR 22721 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23196
**[Test build #99685 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99685/testReport)**
for PR 23196 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22721
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23220
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23220
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5739/
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23220
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22468#discussion_r238894837
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverterSuite.scala
---
@@ -535,4 +535,98 @@ class
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23221
I applied my own feedback to the original PR and will merge pending tests
(since it was already reviewed), unless someone comments first.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23221
**[Test build #99691 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99691/testReport)**
for PR 23221 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23221
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23218
**[Test build #4452 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4452/testReport)**
for PR 23218 at commit
Github user 10110346 commented on the issue:
https://github.com/apache/spark/pull/23216
>
>
> Are you sure it's even a field in the class? it looks like it's only used
to define this:
>
> ```
> @transient private[this] val preferredLocs: Seq[TaskLocation] = {
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23217
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23217
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22514#discussion_r238902415
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala ---
@@ -181,62 +180,39 @@ case class RelationConversions(
conf:
Github user 10110346 closed the pull request at:
https://github.com/apache/spark/pull/23216
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user 10110346 commented on the issue:
https://github.com/apache/spark/pull/23216
Ok, I will close this PR, thank you very much
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/23213#discussion_r238905795
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala
---
@@ -53,6 +55,133 @@ class ExplainSuite extends QueryTest with
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21486
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23213
**[Test build #99692 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99692/testReport)**
for PR 23213 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23108
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23196
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99685/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23108
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23196
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23216#discussion_r238892679
--- Diff: core/src/main/scala/org/apache/spark/scheduler/ResultTask.scala
---
@@ -56,7 +56,7 @@ private[spark] class ResultTask[T, U](
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22721
**[Test build #99690 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99690/testReport)**
for PR 22721 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22721
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/23221
[SPARK-24243][CORE] Expose exceptions from InProcessAppHandle
## What changes were proposed in this pull request?
Adds a new method to SparkAppHandle called getError which returns
the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23221
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/23213#discussion_r238895286
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -144,9 +144,10 @@ class SQLQueryTestSuite extends QueryTest with
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/23213#discussion_r238899777
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2899,6 +2899,144 @@ class SQLQuerySuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22514#discussion_r238899698
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala ---
@@ -181,62 +180,39 @@ case class RelationConversions(
conf:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23216
I think just leave it. The `@transient` in `ShuffleMapTasks`'s `locs` is
just superfluous here, not sure it's worth changing.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23215
**[Test build #99681 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99681/testReport)**
for PR 23215 at commit
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/22952
@gaborgsomogyi @steveloughran
`GlobExpander` only looks like handling `{}` pattern. We need to still deal
with `*` and `?` which can't be expanded like this.
It would only work if
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22721#discussion_r238864486
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/CommandUtils.scala
---
@@ -45,6 +45,8 @@ object CommandUtils extends Logging {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23196
**[Test build #99685 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99685/testReport)**
for PR 23196 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23092
Merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23196
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23196
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/23159
> Rather than change every single call to this method, if this should
generally be the value of the argument, then why not make it the default value
or something?
New parameter aims to
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23092
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22514#discussion_r238871523
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala ---
@@ -181,62 +180,39 @@ case class RelationConversions(
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23216
Are you sure it's even a field in the class? it looks like it's only used
to define this:
```
@transient private[this] val preferredLocs: Seq[TaskLocation] = {
if (locs ==
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23088
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23215
**[Test build #99672 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99672/testReport)**
for PR 23215 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22612
**[Test build #99684 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99684/testReport)**
for PR 22612 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23218
**[Test build #99679 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99679/testReport)**
for PR 23218 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23215
**[Test build #99671 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99671/testReport)**
for PR 23215 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23218
**[Test build #4451 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4451/testReport)**
for PR 23218 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23216
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99674/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23216
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23207
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99677/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23207
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23215
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99681/
Test PASSed.
---
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/23203#discussion_r238868565
--- Diff: python/run-tests.py ---
@@ -93,17 +93,18 @@ def run_individual_python_test(target_dir, test_name,
pyspark_python):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23218
**[Test build #4451 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4451/testReport)**
for PR 23218 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23159#discussion_r238869530
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1777,7 +1777,7 @@ class Analyzer(
case
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23120
Hi @MaxGekk , since this changes the result(although makes it better), do
you mind adding a migration guide? thanks!
---
-
To
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/23222
cc @ptkool @jiangxb1987 @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/23222
[SPARK-20636] Add the rule TransposeWindow to the optimization batch
## What changes were proposed in this pull request?
This PR is a follow-up of the PR
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23222
**[Test build #99698 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99698/testReport)**
for PR 23222 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23222
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22514#discussion_r238933039
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala ---
@@ -181,62 +180,39 @@ case class RelationConversions(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23222
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23213
**[Test build #99692 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99692/testReport)**
for PR 23213 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99692/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22514
**[Test build #99694 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99694/testReport)**
for PR 22514 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22514
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22514
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99694/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99693 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99693/testReport)**
for PR 22683 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99693/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/23211
I generated the TPC-DS plans to compare the differences after this patch to
help review:
301 - 400 of 468 matches
Mail list logo
