Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20227#discussion_r161022261
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/AlreadyExistException.scala
---
@@ -33,6 +33,9 @@ class
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20220
Hi, @srowen .
Is this the first Spark 2.4-only commit?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20208
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/20240
[SPARK-23049][SQL] `spark.sql.files.ignoreCorruptFiles` should work for ORC
files
## What changes were proposed in this pull request?
When `spark.sql.files.ignoreCorruptFiles=true
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20240#discussion_r161107216
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala
---
@@ -608,4 +609,33 @@ class OrcQuerySuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20240#discussion_r161107654
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala
---
@@ -608,4 +609,33 @@ class OrcQuerySuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20240#discussion_r161107677
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala
---
@@ -50,23 +50,35 @@ object OrcUtils extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20240#discussion_r161108103
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala
---
@@ -608,4 +609,33 @@ class OrcQuerySuite
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20240
Hi, @gatorsmile and @cloud-fan .
Could you review this, too?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20240
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/20242
[MINOR][BUILD] Fix Java linter errors
## What changes were proposed in this pull request?
This PR cleans up the java-lint errors (for v2.3.0-rc1 tag). Hopefully,
this will be the
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20242
cc @srowen , @HyukjinKwon , @sameeragarwal .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20242
Thank you for review and approval, @HyukjinKwon .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20222#discussion_r161140353
--- Diff: dev/run-tests-jenkins.py ---
@@ -181,8 +181,8 @@ def main():
short_commit_hash = ghprb_actual_commit[0:7]
# format
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20240
Retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20242
This is the all for RC1 tag.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20242
Retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20222
No, all the others seems to suffer together.
I think this might be related to the intel patch done by Shane a few days
ago
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20240
Retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20242
Thank you all!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/18991
Oh, do we have time for 2.3?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20023#discussion_r161297231
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1048,6 +1048,16 @@ object SQLConf {
.booleanConf
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20023#discussion_r161297154
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1048,6 +1048,16 @@ object SQLConf {
.booleanConf
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20228
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20230
Hi, @aarondav .
Could you review this too?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20240
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20242
Great! Thank you!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20240
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20240#discussion_r161375637
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala
---
@@ -608,4 +609,31 @@ class OrcQuerySuite
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20230
Thank you for review and approval, @felixcheung .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20254
Also, cc @gatorsmile .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20208
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20208
Thank you for review, @gatorsmile .
Is there any concern to shake 2.3 release? This is a *test case* only PR to
build a clear consensus since Apache Spark 2.3.0. I think it's safe
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20240
Thank you for review, @gatorsmile . Sure!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20240
Hi, @HyukjinKwon and @gatorsmile .
It's ready for review again. Thanks!
---
-
To unsubscribe, e-mail: reviews-uns
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20230
Thank you, @felixcheung and @srowen .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/20265
[SPARK-21783][SQL] Turn on ORC filter push-down by default
## What changes were proposed in this pull request?
ORC filter push-down is disabled by default from the beginning, SPARK
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/18991
I see. I opened a new PR, #20265.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20265
cc @cloud-fan , @gatorsmile .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/20266
[SPARK-23072][SQL] Add a Unicode schema test for file-based data sources
## What changes were proposed in this pull request?
After [SPARK-20682](https://github.com/apache/spark/pull
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20265#discussion_r161403798
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala ---
@@ -483,6 +484,64 @@ object OrcReadBenchmark
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20194
cc @hvanhovell , too.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20265#discussion_r161406728
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala ---
@@ -483,6 +484,64 @@ object OrcReadBenchmark
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20265#discussion_r161406817
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala ---
@@ -483,6 +484,64 @@ object OrcReadBenchmark
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20266
cc @gatorsmile and @cloud-fan .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20246
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20265#discussion_r161425712
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala ---
@@ -483,6 +484,64 @@ object OrcReadBenchmark
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20265#discussion_r161426568
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala ---
@@ -483,6 +484,64 @@ object OrcReadBenchmark
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20240
Thank you so much for considering this at the last minute! @cloud-fan ,
@HyukjinKwon , and @gatorsmile .
---
-
To
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20266#discussion_r161599692
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2773,4 +2773,22 @@ class SQLQuerySuite extends QueryTest with
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20271#discussion_r161609860
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala ---
@@ -89,7 +89,7 @@ class UDFSuite extends QueryTest with SharedSQLContext
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20223
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20265#discussion_r161619207
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala ---
@@ -483,6 +484,64 @@ object OrcReadBenchmark
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20265#discussion_r161619856
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala ---
@@ -483,6 +484,64 @@ object OrcReadBenchmark
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20265#discussion_r161620557
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala ---
@@ -483,6 +484,64 @@ object OrcReadBenchmark
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20265
Hi, @cloud-fan and @gatorsmile .
Your questions are valid for all PPD cases. According to the comments, I
added the following expressions (positive and negative) for both ORC/Parquet
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20266#discussion_r161637206
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala ---
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20265#discussion_r161637473
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala ---
@@ -0,0 +1,195 @@
+/*
+ * Licensed to the Apache
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20208
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20266#discussion_r161668286
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala ---
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20266#discussion_r161668457
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala ---
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20265#discussion_r161671835
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala ---
@@ -0,0 +1,195 @@
+/*
+ * Licensed to the Apache
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20265#discussion_r161671868
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala ---
@@ -0,0 +1,195 @@
+/*
+ * Licensed to the Apache
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20265#discussion_r161672316
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala ---
@@ -0,0 +1,195 @@
+/*
+ * Licensed to the Apache
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20265#discussion_r161672411
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala ---
@@ -0,0 +1,195 @@
+/*
+ * Licensed to the Apache
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20265#discussion_r161671821
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala ---
@@ -0,0 +1,195 @@
+/*
+ * Licensed to the Apache
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20265
I'll update the PR tomorrow.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comman
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20266
Retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun closed the pull request at:
https://github.com/apache/spark/pull/21093
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21093
Thank you for review, @cloud-fan and @gatorsmile .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
GitHub user dongjoon-hyun reopened a pull request:
https://github.com/apache/spark/pull/21093
[SPARK-23340][SQL][BRANCH-2.3] Upgrade Apache ORC to 1.4.3
## What changes were proposed in this pull request?
This PR updates Apache ORC dependencies to 1.4.3 released on February
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21093
Oops. I mistakenly click `close and comments` button.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21093
@gatorsmile . Sorry for late response. I'm currently at Dataworks Summit
Berlin.
I took a look. It seems that the last two failures are due to
`JsonInferSchem
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21093
`BucketedWriteWithoutHiveSupportSuite` is testing for `Seq("parquet",
"json")`, and the testsuite fails after `insertInto` and at `write bucketed
data`. So, the f
Github user dongjoon-hyun closed the pull request at:
https://github.com/apache/spark/pull/21093
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21093
Thank you all! :D
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21122#discussion_r183268517
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -31,10 +30,16 @@ import
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21122#discussion_r183269033
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -31,10 +30,16 @@ import
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21118
@rdblue . Could you fix the remaining `KafkaMicroBatchSourceSuite.scala`,
too?
```scala
[error]
/home/jenkins/workspace/SparkPullRequestBuilder@2/external/kafka-0-10-sql/src/test
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20923#discussion_r183470258
--- Diff: pom.xml ---
@@ -2671,6 +2671,15 @@
+
+ hadoop-3.1
--- End diff --
+1 for skipping
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20923
+1 for @jerryshao 's comment. Some of Hive UTs will fail with Hadoop 3
profile.
---
-
To unsubscribe, e-mail: re
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/21141
[SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark tests only for
`-Phive`
## What changes were proposed in this pull request?
When `PyArrow` or `Pandas` are not available, the
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21141
Hi, @holdenk .
Could you review this PR when you have some time?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20909#discussion_r183791249
--- Diff: python/pyspark/sql/readwriter.py ---
@@ -964,6 +964,21 @@ def _test():
except py4j.protocol.Py4JError:
spark
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21066
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21066
Hi, @mridulm . Could you review this PR please?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21122#discussion_r184228752
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -31,10 +30,16 @@ import
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21145#discussion_r184232476
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchReader.scala
---
@@ -299,13 +299,13 @@ private
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21041
Hi, @squito and @cloud-fan .
Could you take a look at `branch-2.3/sbt` build?
After this commit on `branch-2.3`, the following two test cases of
ParquetQuerySuite never
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20522
@gatorsmile . Sorry for late updating. I updated this PR by narrowing the
scope of configuration key names specifically for ORC and Parquet. The test
coverage is reading and writing non
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20522
Thank you for review and merge, @cloud-fan !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21141
Thank you for review, @HyukjinKwon , @holdenk , @bersprockets .
I didn't notice SPARK-23776 when I chose SPARK-23853 . I think we can merge
those PRs now.
@berspro
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/21186
[SPARK-22279][SPARK-24112] Enable `convertMetastoreOrc` and add
`convertMetastore.TableProperty` conf
## What changes were proposed in this pull request?
We reverted
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21041
Thank you, @squito !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21186
@gatorsmile and @cloud-fan .
Could you review this PR? This is a first try after the reverting (#20536).
---
-
To
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21190
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21141
I see. Thanks, @bersprockets . I'll proceed this PR according to your and
other peoples comments.
---
-
To unsubscri
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21141#discussion_r184894865
--- Diff: python/pyspark/sql/tests.py ---
@@ -3021,6 +3021,17 @@ def test_sort_with_nulls_order(self):
class HiveSparkSubmitTests
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21141#discussion_r184894916
--- Diff: python/pyspark/sql/tests.py ---
@@ -3021,6 +3021,17 @@ def test_sort_with_nulls_order(self):
class HiveSparkSubmitTests
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21141
The PR is updated now. Could you review this again, @holdenk, @HyukjinKwon
, @felixcheung , @bersprockets ?
---
-
To
1201 - 1300 of 7376 matches
Mail list logo
