Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/21214
> Just curious how this happened?
I've taken a look at 2 logs you've shown and seen the same pattern. Namely
the test which killed threads passed and right after the upcoming test st
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/21214#discussion_r185836245
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameRangeSuite.scala ---
@@ -153,23 +153,17 @@ class DataFrameRangeSuite extends
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/21214
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/21214#discussion_r185792166
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameRangeSuite.scala ---
@@ -153,23 +153,17 @@ class DataFrameRangeSuite extends
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19431#discussion_r158375331
--- Diff:
external/kafka-0-8/src/main/scala/org/apache/spark/streaming/kafka/DirectKafkaInputDStream.scala
---
@@ -108,7 +115,9 @@ class
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/19431
Until now it was not fully clear documented in which situation does this
parameter take effect. I would personally add things into the doc to be a bit
more specific
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19431#discussion_r158382365
--- Diff:
external/kafka-0-8/src/main/scala/org/apache/spark/streaming/kafka/DirectKafkaInputDStream.scala
---
@@ -91,9 +91,16 @@ class
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19431#discussion_r158382300
--- Diff:
external/kafka-0-10/src/main/scala/org/apache/spark/streaming/kafka010/DirectKafkaInputDStream.scala
---
@@ -126,7 +129,10 @@ private
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19431#discussion_r158374124
--- Diff:
external/kafka-0-8/src/main/scala/org/apache/spark/streaming/kafka/DirectKafkaInputDStream.scala
---
@@ -91,9 +91,16 @@ class
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19431#discussion_r158375540
--- Diff:
external/kafka-0-10/src/main/scala/org/apache/spark/streaming/kafka010/DirectKafkaInputDStream.scala
---
@@ -126,7 +129,10 @@ private
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/19893
gentle ping @jiangxb1987
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20022#discussion_r158585754
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowFunctionsSuite.scala
---
@@ -518,9 +519,46 @@ class
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19893#discussion_r159842007
--- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala ---
@@ -31,15 +31,28 @@ import org.apache.spark.util.AccumulatorContext
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19893#discussion_r159841944
--- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala ---
@@ -31,15 +31,28 @@ import org.apache.spark.util.AccumulatorContext
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19893#discussion_r159838691
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/DataSourceAnalysisSuite.scala
---
@@ -29,16 +29,24 @@ import
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19893#discussion_r159831631
--- Diff: core/src/test/scala/org/apache/spark/ThreadAudit.scala ---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19893#discussion_r159834709
--- Diff: core/src/test/scala/org/apache/spark/ThreadAudit.scala ---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19893#discussion_r159840754
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSessionStateSuite.scala
---
@@ -28,14 +28,18 @@ import
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19893#discussion_r159831366
--- Diff: core/src/test/scala/org/apache/spark/ThreadAudit.scala ---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19893#discussion_r159832598
--- Diff: core/src/test/scala/org/apache/spark/ThreadAudit.scala ---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19893#discussion_r159832729
--- Diff: core/src/test/scala/org/apache/spark/ThreadAudit.scala ---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19893#discussion_r159837804
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SessionStateSuite.scala ---
@@ -39,6 +41,7 @@ class SessionStateSuite extends SparkFunSuite
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19893#discussion_r159851476
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/SharedSQLContext.scala ---
@@ -17,4 +17,17 @@
package
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20019#discussion_r160143221
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
---
@@ -263,21 +263,60 @@ class
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19893#discussion_r160158067
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/SharedSQLContext.scala ---
@@ -17,4 +17,22 @@
package
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19893#discussion_r160158241
--- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala ---
@@ -27,19 +27,55 @@ import org.apache.spark.util.AccumulatorContext
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19893#discussion_r160158308
--- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala ---
@@ -27,19 +27,55 @@ import org.apache.spark.util.AccumulatorContext
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20019#discussion_r161810800
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
---
@@ -263,21 +263,60 @@ class
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/20362
cc @jkbradley @WeichenXu123
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
GitHub user gaborgsomogyi opened a pull request:
https://github.com/apache/spark/pull/20362
[Spark-22886][ML][TESTS] ML test for structured streaming: ml.recommeâ¦
## What changes were proposed in this pull request?
Converting spark.ml.recommendation tests to also check
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20235#discussion_r163241569
--- Diff: mllib/src/test/scala/org/apache/spark/ml/fpm/FPGrowthSuite.scala
---
@@ -34,86 +35,122 @@ class FPGrowthSuite extends SparkFunSuite
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/19893
@vanzin @squito @srowen @jiangxb1987 @henryr
Big thanks to everybody for the constructive comments, learned a lot from
them.
I'll take a look at further possibilities like
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/20019
@gatorsmile @jiangxb1987 @smurakozi Thanks for the help!
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/19893
Checked and seems like unrelated.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19893#discussion_r161308026
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/SharedSQLContext.scala ---
@@ -17,4 +17,37 @@
package
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/19893
Checked the failure but seems like unrelated.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/19893
Related hive please see my comment on 11 Dec 2017.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/19893
Thread audit disabled in hive.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19893#discussion_r161370006
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/SharedSQLContext.scala ---
@@ -17,4 +17,37 @@
package
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20362#discussion_r165379876
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -599,8 +599,15 @@ class ALSSuite
(ex, act
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20362#discussion_r165382316
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -628,18 +635,24 @@ class ALSSuite
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20362#discussion_r165382596
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -653,6 +666,7 @@ class ALSSuite
test("ALS cold
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20362#discussion_r165378573
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -566,6 +565,7 @@ class ALSSuite
test("read/
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20474#discussion_r165377643
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2168,7 +2168,17 @@ private[spark] object Utils extends Logging
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20474#discussion_r165411432
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2168,7 +2168,17 @@ private[spark] object Utils extends Logging
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20362#discussion_r165392031
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -693,7 +711,9 @@ class ALSSuite
val data
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20362#discussion_r165396480
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -662,28 +676,32 @@ class ALSSuite
val knownItem
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20362#discussion_r167005865
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -599,8 +598,11 @@ class ALSSuite
(ex, act
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/19431
@tdas could you take a look at it?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19431#discussion_r167281176
--- Diff:
external/kafka-0-10/src/test/scala/org/apache/spark/streaming/kafka010/DirectKafkaStreamSuite.scala
---
@@ -22,6 +22,7 @@ import java.lang
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19431#discussion_r167281995
--- Diff:
external/kafka-0-8/src/test/scala/org/apache/spark/streaming/kafka/DirectKafkaStreamSuite.scala
---
@@ -539,6 +456,58 @@ class
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19431#discussion_r167281427
--- Diff:
external/kafka-0-8/src/test/scala/org/apache/spark/streaming/kafka/DirectKafkaStreamSuite.scala
---
@@ -21,6 +21,7 @@ import java.io.File
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19431#discussion_r167281937
--- Diff:
external/kafka-0-10/src/test/scala/org/apache/spark/streaming/kafka010/DirectKafkaStreamSuite.scala
---
@@ -687,6 +618,51 @@ class
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/20362
@smurakozi fix added for the original test issue.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
GitHub user gaborgsomogyi opened a pull request:
https://github.com/apache/spark/pull/20608
[SPARK-23422][Core] YarnShuffleIntegrationSuite fix when SPARK_PREPENâ¦
â¦D_CLASSES set to 1
## What changes were proposed in this pull request
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/20608
cc @ConeyLiu @vanzin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19431#discussion_r166952263
--- Diff:
external/kafka-0-10/src/main/scala/org/apache/spark/streaming/kafka010/DirectKafkaInputDStream.scala
---
@@ -126,7 +129,10 @@ private
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19431#discussion_r166953894
--- Diff:
external/kafka-0-10/src/test/scala/org/apache/spark/streaming/kafka010/DirectKafkaStreamSuite.scala
---
@@ -551,6 +551,76 @@ class
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19431#discussion_r166953800
--- Diff:
external/kafka-0-8/src/test/scala/org/apache/spark/streaming/kafka/DirectKafkaStreamSuite.scala
---
@@ -387,6 +387,89 @@ class
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19431#discussion_r166953742
--- Diff:
external/kafka-0-8/src/test/scala/org/apache/spark/streaming/kafka/DirectKafkaStreamSuite.scala
---
@@ -387,6 +387,89 @@ class
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19431#discussion_r166952412
--- Diff:
external/kafka-0-8/src/main/scala/org/apache/spark/streaming/kafka/DirectKafkaInputDStream.scala
---
@@ -91,9 +91,16 @@ class
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19431#discussion_r166953420
--- Diff:
external/kafka-0-10/src/test/scala/org/apache/spark/streaming/kafka010/DirectKafkaStreamSuite.scala
---
@@ -551,6 +551,76 @@ class
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/19431
I mean the difference between `test("use backpressure.initialRate with
backpressure")` and `test("backpressure.initialRate should honor
maxRatePerPartition")` are
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20620#discussion_r168914525
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceivedBlockTracker.scala
---
@@ -193,12 +193,15 @@ private[streaming
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/20620
Seems like unrelated issue.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/20362
gentle ping @jkbradley @WeichenXu123
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user gaborgsomogyi opened a pull request:
https://github.com/apache/spark/pull/20620
[SPARK-23438][DSTREAMS] Fix DStreams data loss with WAL when driver crashes
## What changes were proposed in this pull request?
There is a race condition introduced in SPARK-11141
GitHub user gaborgsomogyi opened a pull request:
https://github.com/apache/spark/pull/20652
[SPARK-23476][SPARK-SHELL] Generate secret in local mode when
authentication on
## What changes were proposed in this pull request?
If spark is run with "spark.authenticate
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/20652
cc @vanzin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20652#discussion_r169797492
--- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
@@ -529,7 +529,8 @@ private[spark] class SecurityManager(
return
GitHub user gaborgsomogyi opened a pull request:
https://github.com/apache/spark/pull/20639
[SPARK-23288][SS] Fix output metrics with parquet sink
## What changes were proposed in this pull request?
Output metrics were not filled when parquet sink used.
This PR
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20652#discussion_r170003945
--- Diff: core/src/test/scala/org/apache/spark/SecurityManagerSuite.scala
---
@@ -440,23 +440,41 @@ class SecurityManagerSuite extends SparkFunSuite
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/20362
ping @srowen
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20362#discussion_r170072578
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -413,34 +411,36 @@ class ALSSuite
.setSeed(0
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20362#discussion_r170074167
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -586,6 +586,68 @@ class ALSSuite
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20362#discussion_r170072392
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -586,6 +586,68 @@ class ALSSuite
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/18672
Looks like a shortcut to me as well.
There is already a PR for backpressure:
https://github.com/apache/spark/pull/19431
Could you explain what exactly would like to achieve
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/20620
@jose-torres @tdas @zsxwing could you take a look at this please?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20019#discussion_r159196803
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
---
@@ -263,21 +263,60 @@ class
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20019#discussion_r159196842
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
---
@@ -263,21 +263,60 @@ class
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/20022
@gatorsmile @cloud-fan @jiangxb1987 Thanks for the help!
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20019#discussion_r158289422
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowFramesSuite.scala
---
@@ -0,0 +1,381 @@
+/*
+ * Licensed to the Apache
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20019#discussion_r158290356
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowFramesSuite.scala
---
@@ -0,0 +1,381 @@
+/*
+ * Licensed to the Apache
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20045#discussion_r158292663
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowFunctionsSuite.scala
---
@@ -32,6 +32,217 @@ import
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20045#discussion_r158298186
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
---
@@ -246,13 +246,23 @@ class
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20045#discussion_r158298350
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
---
@@ -246,13 +246,23 @@ class
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/20019
ExpressionParserSuite window related part is a bit reorganized and enhanced.
---
-
To unsubscribe, e-mail: reviews
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20022#discussion_r158525031
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowFunctionsSuite.scala
---
@@ -518,9 +519,46 @@ class
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19893#discussion_r158527212
--- Diff: core/src/test/scala/org/apache/spark/ThreadAudit.scala ---
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19893#discussion_r158527190
--- Diff: core/src/test/scala/org/apache/spark/ThreadAudit.scala ---
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19893#discussion_r158527262
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/SharedSQLContext.scala ---
@@ -17,4 +17,17 @@
package
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/19819
I think this can be closed as the problem solved.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/22138#discussion_r215277752
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/FetchedPoolSuite.scala
---
@@ -0,0 +1,299 @@
+/*
+ * Licensed
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/22138#discussion_r215274047
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/InternalKafkaConsumerPool.scala
---
@@ -0,0 +1,241
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/22138#discussion_r215268638
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/FetchedDataPool.scala
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/22138#discussion_r215270783
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/InternalKafkaConsumerPool.scala
---
@@ -0,0 +1,241
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/22138#discussion_r215274150
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaDataConsumer.scala
---
@@ -414,17 +468,37 @@ private[kafka010
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/22138#discussion_r215281569
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/FetchedDataPool.scala
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/22138#discussion_r215275456
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/InternalKafkaConsumerPool.scala
---
@@ -0,0 +1,241
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/22138#discussion_r215591546
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/InternalKafkaConsumerPool.scala
---
@@ -0,0 +1,241
101 - 200 of 467 matches
Mail list logo
