[GitHub] spark pull request #16989: [SPARK-19659] Fetch big blocks to disk when shuff...

Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/16989#discussion_r118482160 --- Diff: core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala --- @@ -401,4 +413,64 @@ class

[GitHub] spark issue #16989: [SPARK-19659] Fetch big blocks to disk when shuffle-read...

Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/16989 @cloud-fan @JoshRosen @mridulm @squito @viirya Thanks a lot for taking so much time reviewing this patch ! Sorry for the stupid mistakes I made. I will be more careful next time

[GitHub] spark pull request #18117: [SPARK-19659][CORE][FOLLOW-UP] Fetch big blocks t...

Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/18117#discussion_r118731891 --- Diff: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala --- @@ -214,11 +214,12 @@ final class

[GitHub] spark pull request #18117: [SPARK-19659][CORE][FOLLOW-UP] Fetch big blocks t...

Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/18117#discussion_r118731980 --- Diff: core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala --- @@ -443,34 +445,34 @@ class

[GitHub] spark issue #18117: [SPARK-19659][CORE][FOLLOW-UP] Fetch big blocks to disk ...

Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/18117 @cloud-fan Thanks a lot for notification. I think it's really good change here 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] spark issue #17634: [SPARK-20333] HashPartitioner should be compatible with ...

Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/17634 @squito Thanks a lot for merging :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17312: [SPARK-19973] Display num of executors for the stage.

Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/17312 Sorry, I will close it for now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #17312: [SPARK-19973] Display num of executors for the st...

Github user jinxing64 closed the pull request at: https://github.com/apache/spark/pull/17312 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17603: [SPARK-20288] Avoid generating the MapStatus by stageId ...

Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/17603 @squito Thank you so much :-) :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17603: [SPARK-20288] Avoid generating the MapStatus by stageId ...

Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/17603 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #21330: [SPARK-22234] Support distinct window functions

Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/21330#discussion_r213000357 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1883,7 +1883,19 @@ class Analyzer

[GitHub] spark issue #22202: [SPARK-25211][Core] speculation and fetch failed result ...

Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/22202 Thanks for ping~ Seems that `ShuffleMapTask0.1` is a speculation, please update the description. The change seems fine for me. But give https://github.com/apache/spark/pull/21019, the

[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/21330 If this feature is interested, could you please help start the review @jiangxb1987 Thanks a lot. --- - To unsubscribe, e

[GitHub] spark pull request #22712: [SPARK-25724] Add sorting functionality in MapTyp...

GitHub user jinxing64 opened a pull request: https://github.com/apache/spark/pull/22712 [SPARK-25724] Add sorting functionality in MapType. ## What changes were proposed in this pull request? This is related to https://github.com/apache/spark/pull/19330. As subtask of

[GitHub] spark issue #22712: [SPARK-25724] Add sorting functionality in MapType.

Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/22712 @maropu I want to split https://github.com/apache/spark/pull/19330 to two parts: 1. Approach to compare two Maps with themselves already sorted. (This PR) 2. Approach to sort the

[GitHub] spark pull request #22712: [SPARK-25724] Add sorting functionality in MapTyp...

Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/22712#discussion_r224961789 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/MapType.scala --- @@ -73,6 +74,90 @@ case class MapType( override private[spark

[GitHub] spark pull request #22712: [SPARK-25724] Add sorting functionality in MapTyp...

Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/22712#discussion_r225628985 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ordering.scala --- @@ -53,6 +53,10 @@ class InterpretedOrdering(ordering

[GitHub] spark issue #22712: [SPARK-25724] Add sorting functionality in MapType.

Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/22712 > BTW, how does hive implement comparable maps? Is it below piece of code ? https://github.com/apache/hive/blob/master/serde/src/java/org/apache/hadoop/hive/serde2/objectinspec

[GitHub] spark pull request #19330: [SPARK-18134][SQL] Orderable MapType

Github user jinxing64 closed the pull request at: https://github.com/apache/spark/pull/19330 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

<    3   4   5   6   7   8