Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159630335
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -199,13 +199,60 @@ case class Cast(child: Expression
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20149
Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159774668
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -597,6 +619,44 @@ case class Cast(child: Expression
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20024
Thanks for the kindly checks in the year start and all the comments done.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20024
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159800597
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -608,6 +665,17 @@ case class Cast(child: Expression
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20024
Thanks! I'll do.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: revi
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/20166
[SPARK-22973][SQL] Fix incorrect results of Casting Map to String
## What changes were proposed in this pull request?
This pr fixed the issue when casting maps into strings;
```
scala
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20166
@cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20135
@gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20166#discussion_r160022276
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -228,6 +228,35 @@ case class Cast(child: Expression
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20166
BTW, the current `Datset.showString` prints rows thru `RowEncoder`
deserializers like;
```
scala> Seq(Seq(Seq(1, 2), Seq(3), Seq(4, 5, 6))).toDF("a"
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20174#discussion_r160040256
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -666,4 +666,16 @@ class DataFrameAggregateSuite extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20174#discussion_r160040214
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -245,11 +252,15 @@ case class HashAggregateExec
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20174#discussion_r160040102
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -106,6 +106,8 @@ case class HashAggregateExec
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20174#discussion_r160040260
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -666,4 +666,16 @@ class DataFrameAggregateSuite extends
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20174
(This is not related to this pr and too trivial things though, I just leave
comments) `PropagateEmptyRelation` does not collapse
`spark.emptyDataFrame.dropDuplicates` because `spark.emptyDataFrame
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20166
ok, I'll fix struct in a next following pr first.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.or
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/20176
[SPARK-22981][SQL] Fix incorrect results of Casting Struct to String
## What changes were proposed in this pull request?
This pr fixed the issue when casting structs into strings
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20176#discussion_r160041886
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -259,6 +259,29 @@ case class Cast(child: Expression
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20174#discussion_r160126732
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -230,6 +236,7 @@ case class HashAggregateExec
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20176
@cloud-fan ping
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20174#discussion_r160301233
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -230,6 +236,7 @@ case class HashAggregateExec
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19330
Any update?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20176#discussion_r160310736
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -732,6 +755,39 @@ case class Cast(child: Expression
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20176
Thanks! Next, I'll fix `showString` though, one question; currently casting
binary to string is different between
[Cast](https://github.com/apache/spark/blob/2250cb75b99d257e698fe5418a51d8cddb4
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20176
hive one is the same with mysql one;
```
hive> create table t(a BINARY);
OK
hive> INSERT INTO t values('abc');
OK
hive> select CAST(a AS STRING) fro
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20176
ok, I'll make a follow-up for `showString` later.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.or
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/20214
[SPARK-23023][SQL] Cast field data to strings in showString
## What changes were proposed in this pull request?
The current `Datset.showString` prints rows thru `RowEncoder` deserializers
like
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20214
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20214#discussion_r160613267
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -1255,6 +1255,34 @@ class DataFrameSuite extends QueryTest with
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20214
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19330
Aha, I think we can't touch the stable interface (`MapType`) until the next
release (v3.0). So, I think we need to hold this for a while. Or, we need to
look for other approaches to fix
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20214
`org.apache.spark.sql.streaming.StreamingOuterJoinSuite` is flaky? (It
seems this pr is not related to the test).
---
-
To
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20214
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20224
We always need to turn on this? It seems this is debug info for developers?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20214
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20214#discussion_r161130049
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -237,13 +237,19 @@ class Dataset[T] private[sql](
private[sql] def
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20214#discussion_r161131086
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -237,13 +237,18 @@ class Dataset[T] private[sql](
private[sql] def
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/20245
[SPARK-21213][SQL][FOLLOWUP] Use compatible types for comparisons in
compareAndGetNewStats
## What changes were proposed in this pull request?
This pr fixed code to compare values in
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20245
nitpicking though, could you check? @gatorsmile @wzhfy @mbasmanova
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20245
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20214#discussion_r161156501
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -237,13 +237,18 @@ class Dataset[T] private[sql](
private[sql] def
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/20246
[SPARK-23054][SQL] Fix incorrect results of casting UserDefinedType to
String
## What changes were proposed in this pull request?
This pr fixed the issue when casting `UserDefinedType`s into
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20214
Please check #20246 first? Thanks! @ueshin @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20245
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20246
sure!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20246
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20246
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20246
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/20247
[SPARK-23021][SQL] AnalysisBarrier should override innerChildren to print
correct explain output
## What changes were proposed in this pull request?
`AnalysisBarrier` in the current master cuts
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20245
yea, it's a super corner-case (almost impossible). So, this is just a
correctness issue as intellij suggests incompatible comparisons. (Actually, I'm
not sure why we use `BigInt` for the
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20214#discussion_r161358894
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -1255,6 +1255,34 @@ class DataFrameSuite extends QueryTest with
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20246#discussion_r161359566
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -282,6 +282,8 @@ case class Cast(child: Expression
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20246
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20247
@rednaxelafx yea, I'm also ok to print `AnalysisBarrier` cuz this info is
some informative.
---
-
To unsubscribe, e
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20247
Could you check? @viirya @cloud-fan (btw, I'm bit surprise @viirya moved to
fukuoka?)
---
-
To unsubscribe, e-mail: re
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20246#discussion_r161368596
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -282,6 +282,8 @@ case class Cast(child: Expression
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20247#discussion_r161369191
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -2228,4 +2229,26 @@ class DataFrameSuite extends QueryTest with
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r161387055
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -575,7 +609,10 @@ case class CollapseCodegenStages(conf
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20214
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21018#discussion_r182612846
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala ---
@@ -119,26 +119,60 @@ class CacheManager extends Logging
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21018#discussion_r182626260
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala ---
@@ -119,26 +119,60 @@ class CacheManager extends Logging
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20345
@wzhfy ping
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20965#discussion_r182653261
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -254,6 +256,80 @@ case class HashAggregateExec
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20965#discussion_r182673750
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -266,28 +342,53 @@ case class HashAggregateExec
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20965#discussion_r182677131
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -254,6 +256,80 @@ case class HashAggregateExec
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21018
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20757
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20778
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20980
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21052
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20757#discussion_r182903518
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -1615,13 +1616,50 @@ case class
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20757
Many thanks for your checks! I'll fix soon!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For addit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21018
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21018#discussion_r182929830
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala ---
@@ -119,26 +119,60 @@ class CacheManager extends Logging
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20980#discussion_r182930489
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala
---
@@ -415,6 +417,36 @@ class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20980#discussion_r182933940
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -1197,8 +1197,64 @@ case class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20980#discussion_r182945511
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala
---
@@ -415,6 +417,36 @@ class
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20979
ok, thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/21112
[SPARK-23588][SQL][FOLLOW-UP] Resolve a map builder method per execution
in CatalystToExternalMap
## What changes were proposed in this pull request?
This pr is a follow-up pr of #20979 and
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21112
@hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21112
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20980
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20757
Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20980#discussion_r183070120
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala
---
@@ -472,6 +474,61 @@ class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20965#discussion_r183185144
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -254,6 +256,80 @@ case class HashAggregateExec
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21052#discussion_r183190136
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala ---
@@ -382,4 +382,34 @@ class StatisticsCollectionSuite extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21052#discussion_r183190221
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala ---
@@ -382,4 +382,34 @@ class StatisticsCollectionSuite extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21052#discussion_r183190234
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala ---
@@ -382,4 +382,34 @@ class StatisticsCollectionSuite extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21052#discussion_r183190383
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala ---
@@ -382,4 +382,34 @@ class StatisticsCollectionSuite extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21052#discussion_r183190432
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala ---
@@ -382,4 +382,34 @@ class StatisticsCollectionSuite extends
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20345
@cloud-fan @wzhfy ping
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21018
@cloud-fan @viirya could you check this? Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21018#discussion_r183288666
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -794,4 +794,17 @@ class CachedTableSuite extends QueryTest with
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21018#discussion_r183288749
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala
---
@@ -55,56 +42,38 @@ object InMemoryRelation
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20980
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20345
ping
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21018#discussion_r183362208
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala
---
@@ -55,56 +42,39 @@ object InMemoryRelation
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21018#discussion_r183362225
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala
---
@@ -155,31 +125,76 @@ case class InMemoryRelation
501 - 600 of 3608 matches
Mail list logo
