Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97220246
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -260,6 +264,10 @@ class Dataset[T] private[sql](
case binary: Array
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97220249
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -250,6 +252,8 @@ class Dataset[T] private[sql](
val hasMoreData
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97220274
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala
---
@@ -314,7 +315,7 @@ object FileFormatWriter extends
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97221574
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -69,49 +69,68 @@ object DateTimeUtils
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r102132850
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -859,6 +859,48 @@ class CSVSuite extends QueryTest
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r102132903
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/ResolvedDataSourceSuite.scala
---
@@ -19,11 +19,15 @@ package org.apache.spark.sql.sources
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/17053
[SPARK-18939][SQL] Timezone support in partition values.
## What changes were proposed in this pull request?
This is a follow-up pr of #16308 and #16750.
This pr enables timezone
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17053#discussion_r102890922
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -251,7 +251,8 @@ abstract class ExternalCatalog
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/17053
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/17053
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r100729875
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -859,6 +859,48 @@ class CSVSuite extends QueryTest
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r100729866
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -58,13 +59,15 @@ private[sql] class JSONOptions
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/16750
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/16308
I'll add some more comments to explain `DateFunctionsSuite` later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96179000
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -316,30 +329,43 @@ class CastSuite extends
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96178803
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -195,19 +231,26 @@ case class Hour(child
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96178830
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -32,20 +34,20 @@ import
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96260869
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ---
@@ -107,6 +107,7 @@ package object dsl
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/16308
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15276#discussion_r81274823
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -906,7 +906,7 @@ case class AssertNotNull(child
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/15276
@rxin Yes, in my case, I used `RowEncoder` with a schema having a lot of
fields (>250) and processed some logic. `RowEncoder` uses `GetExternalRowField`
and `ValidateExternalType` and they ad
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15276#discussion_r81073701
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -85,6 +85,27 @@ class CodegenContext
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15276#discussion_r81072832
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -85,6 +85,27 @@ class CodegenContext
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15276#discussion_r81074449
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -85,6 +85,27 @@ class CodegenContext
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15276#discussion_r81074395
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -85,6 +85,27 @@ class CodegenContext
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/15276
[SPARK-17703][SQL] Add unnamed version of addReferenceObj for minor objects.
## What changes were proposed in this pull request?
There are many minor objects in references, which
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/15275
[SPARK-17702][SQL] Code generation including too many mutable states
exceeds JVM size limit.
## What changes were proposed in this pull request?
Code generation including too many mutable
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15275#discussion_r81446511
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -589,6 +592,11 @@ class CodegenContext
Github user ueshin closed the pull request at:
https://github.com/apache/spark/pull/15808
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/15808
Sure. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/15627
@kishorvpatil Thank you for fixing this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15627#discussion_r86930468
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -600,10 +600,14 @@ private[spark] class Client(
val
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/15276
@davies @rxin Should I send a PR to backport this to `branch-2.0` if you
don't have time?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/15627
@kishorvpatil @tgravescs It seems this pr is breaking functionalities of
`--files` or `--archives`.
Using `--files` or `--archives` with files which are not included to
`--jars` doesn't work
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/15276
I sent a new PR #15808. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/15276
Oh, I see, wait for a while.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/15808
[SPARK-17703][SQL][BACKPORT-2.0] Add unnamed version of addReferenceObj for
minor objects.
## What changes were proposed in this pull request?
This is a backport of #15276
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/15840
@hvanhovell @kiszk I tried to use `CodegenContext.nullSafeExec()` in
`MapObjects` as an example.
If you can bear with this for now, I'll apply it to other places to
generate nullability checking
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/15840
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/15840
[SPARK-18398][SQL] Fix nullabilities of MapObjects and optimize not to
check null if lambda is not nullable.
## What changes were proposed in this pull request?
The nullabilities
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/15840
I found that we could use `CodegenContext.nullSafeExec()` for most case,
which is not so generic but we can easily replace nullability checking for now.
---
If your project is set up for it, you
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/15548
[SPARK-17985][CORE] Bump commons-lang3 version to 3.5.
## What changes were proposed in this pull request?
`SerializationUtils.clone()` of commons-lang3 (<3.5) has a bug that breaks
thr
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/15525
@rxin I submitted a new pr #15548. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/15525
I see. I'll submit soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/15548
The build for hadoop-2.2 has finished successfully.
https://amplab.cs.berkeley.edu/jenkins/job/spark-master-test-sbt-hadoop-2.2/1956/
Thanks.
---
If your project is set up for it, you can
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r83803058
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -118,7 +118,45 @@ object
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r83530039
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -118,7 +118,45 @@ object
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r83530625
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -118,7 +118,45 @@ object
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r83837138
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -537,7 +537,6 @@ class CodegenContext
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/15525
[SPARK-17985][CORE] Bump commons-lang3 version to 3.5.
## What changes were proposed in this pull request?
`SerializationUtils.clone()` of commons-lang3 (<3.5) has a bug that breaks
thr
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/15525
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/15525
@rxin I think the failure is not related to this PR.
The build for hadoop-2.2 is failing after reverted.
https://amplab.cs.berkeley.edu/jenkins/job/spark-master-test-sbt-hadoop-2.2/1948
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/15780
Needs `AssertNotNull()`
[here](https://github.com/kiszk/spark/blob/38991d00cbaa50ffc9d22c54f643ed03e51b4785/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala#L577
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/15840
@hvanhovell The pattern basically I used to replace nullability checking
here is like:
```scala
val eval = child.genCode(ctx)
ev.copy(code = s"""
${eval.code
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/15887
[SPARK-18442][SQL] Fix nullability of WrapOption.
## What changes were proposed in this pull request?
The nullability of `WrapOption` should be `false`.
## How was this patch
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/15840
I replaced nullability checking where we can use
`CodegenContext.nullSafeExec()`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/16007
@rxin And also we should modify the generated code to check the value is
null or not, shouldn't we?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/16007
I see, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/16007
@rxin The default value is `""` (`UTF8String.fromString("")`) if input file
name is not set for now.
https://github.com/apache/spark/blob/master/core/src/main/scala/
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/16007
@rxin Sorry but finally we can change the nullable value to `false`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/16007
I see, I'll revert this and add the comment. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/16007
[SPARK-18583][SQL] Fix nullability of InputFileName.
## What changes were proposed in this pull request?
The nullability of `InputFileName` should be `false`.
## How was this patch
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/16008
[SPARK-18585][SQL] Use `ev.isNull = "false"` if possible for Janino to have
a chance to optimize.
## What changes were proposed in this pull request?
Janino can optimize `tr
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r89802303
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -118,7 +118,42 @@ object
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/16008
Hmm, it is a great idea, but I think it would be very hard to submit such a
patch (at least for me now).
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r89712401
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -405,13 +406,14 @@ case class WrapOption(child
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r89712321
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -177,9 +177,10 @@ case class Invoke
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r89713304
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -177,9 +177,10 @@ case class Invoke
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r89715546
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -590,7 +591,11 @@ object ScalaReflection extends
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r89718035
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -177,9 +177,10 @@ case class Invoke
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r89718517
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -177,9 +177,10 @@ case class Invoke
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r89721863
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -405,13 +406,14 @@ case class WrapOption(child
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r89737732
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -643,8 +645,9 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r89737836
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ReferenceToExpressions.scala
---
@@ -74,7 +74,8 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r89744772
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSinkSuite.scala
---
@@ -86,7 +86,7 @@ class FileStreamSinkSuite extends
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15901#discussion_r88426162
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -33,6 +33,85 @@ import
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15901#discussion_r88415438
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -33,6 +33,85 @@ import
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15901#discussion_r88415808
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -245,51 +316,36 @@ case class NewInstance
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/15901
@viirya @cloud-fan I addressed your comments and updated pr title and
description.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15901#discussion_r88389718
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -33,6 +33,88 @@ import
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15901#discussion_r88390158
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -33,6 +33,88 @@ import
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15901#discussion_r88413619
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -33,6 +33,85 @@ import
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15901#discussion_r88389738
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -245,51 +319,36 @@ case class NewInstance
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15901#discussion_r88389723
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -33,6 +33,88 @@ import
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15901#discussion_r88389735
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -50,7 +132,7 @@ case class StaticInvoke
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/15901
@rxin I introduced features as follows:
1. `StaticInvoke` and `Invoke` had a risk to exceed 64kb JVM limit to
prepare arguments but after this patch they can handle them because they share
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r88189832
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,29 +56,49 @@ case class CreateArray
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15901#discussion_r88682412
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -245,51 +311,31 @@ case class NewInstance
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15901#discussion_r88682370
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -164,28 +232,26 @@ case class Invoke
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15901#discussion_r88684544
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -164,23 +233,20 @@ case class Invoke
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/15901
[SPARK-18467][SQL] Refactor StaticInvoke, Invoke and NewInstance.
## What changes were proposed in this pull request?
Refactor `StaticInvoke`, `Invoke` and `NewInstance
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r88479931
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -603,7 +603,14 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r88588544
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -574,7 +574,12 @@ object ScalaReflection extends
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r88591439
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -603,7 +603,14 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15901#discussion_r88593070
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -164,23 +233,20 @@ case class Invoke
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/15840
@hvanhovell I'd like to revert some of commits in this pr which replace
null checking with `ctx.nullSafeExec()` to focus on the original purpose of
this pr, and send another pr to discuss null
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15901#discussion_r88612839
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -33,6 +33,79 @@ import
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/15927
[SPARK-18500][SQL] Make GenericStrategy be able to prune plans by itself
after placeholders are replaced.
## What changes were proposed in this pull request?
This pr adds a functionality
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/15927
@marmbrus Could you review this pr please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/15927
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
401 - 500 of 2567 matches
Mail list logo
