[GitHub] spark pull request #21258: [SPARK-23933][SQL] Add map_from_arrays function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21258#discussion_r192921149 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -235,6 +235,86 @@ case class CreateMap

[GitHub] spark pull request #21045: [SPARK-23931][SQL] Adds zip function to sparksql

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21045#discussion_r193236096 --- Diff: python/pyspark/sql/functions.py --- @@ -2394,6 +2394,23 @@ def array_repeat(col, count): return Column(sc._jvm.functions.array_repeat

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r193826690 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -308,6 +308,170 @@ case class MapEntries

[GitHub] spark pull request #21045: [SPARK-23931][SQL] Adds zip function to sparksql

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21045#discussion_r193837080 --- Diff: python/pyspark/sql/functions.py --- @@ -2394,6 +2394,23 @@ def array_repeat(col, count): return Column(sc._jvm.functions.array_repeat

[GitHub] spark pull request #21050: [SPARK-23912][SQL]add array_distinct

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21050#discussion_r193841141 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1882,3 +1883,134 @@ case class

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r193895158 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1468,3 +1472,388 @@ case class Flatten

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r193927263 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1887,6 +1889,402 @@ case class Flatten

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r193899743 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1887,6 +1889,402 @@ case class Flatten

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r193926459 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1887,6 +1889,402 @@ case class Flatten

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r193926035 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1887,6 +1889,402 @@ case class Flatten

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r193928034 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala --- @@ -308,6 +313,292 @@ class

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r193928619 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala --- @@ -308,6 +313,292 @@ class

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r193926575 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1887,6 +1889,402 @@ case class Flatten

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r193927174 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1887,6 +1889,402 @@ case class Flatten

[GitHub] spark pull request #21258: [SPARK-23933][SQL] Add map_from_arrays function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21258#discussion_r193929635 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -236,6 +236,76 @@ case class CreateMap

[GitHub] spark pull request #21258: [SPARK-23933][SQL] Add map_from_arrays function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21258#discussion_r193929951 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -236,6 +236,76 @@ case class CreateMap

[GitHub] spark pull request #21282: [SPARK-23934][SQL] Adding map_from_entries functi...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21282#discussion_r193958595 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -308,6 +309,234 @@ case class MapEntries

[GitHub] spark issue #21082: [SPARK-22239][SQL][Python] Enable grouped aggregate pand...

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21082 LGTM. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21045: [SPARK-23931][SQL] Adds zip function to sparksql

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21045#discussion_r194208465 --- Diff: python/pyspark/sql/functions.py --- @@ -2394,6 +2394,23 @@ def array_repeat(col, count): return Column(sc._jvm.functions.array_repeat

[GitHub] spark pull request #21045: [SPARK-23931][SQL] Adds zip function to sparksql

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21045#discussion_r194501372 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -128,6 +128,170 @@ case class MapKeys

[GitHub] spark pull request #21258: [SPARK-23933][SQL] Add map_from_arrays function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21258#discussion_r194514611 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ComplexTypeSuite.scala --- @@ -186,6 +186,50 @@ class ComplexTypeSuite

[GitHub] spark pull request #21258: [SPARK-23933][SQL] Add map_from_arrays function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21258#discussion_r194514576 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ComplexTypeSuite.scala --- @@ -186,6 +186,50 @@ class ComplexTypeSuite

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r194520589 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2189,3 +2189,293 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r194520120 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2189,3 +2189,293 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r194517152 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2189,3 +2189,293 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r194530787 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2189,3 +2189,293 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r194527119 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2189,3 +2189,293 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r194516045 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2189,3 +2189,293 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r194523480 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2189,3 +2189,293 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r194520924 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2189,3 +2189,293 @@ case class

[GitHub] spark issue #20991: [SPARK-10399][SPARK-23879][HotFix] Fix Java lint errors

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20991 LGTM pending Jenkins. I've confirmed that `lint-java` passed in my local environment. --- - To unsubscribe, e-mail: re

[GitHub] spark pull request #20991: [SPARK-10399][SPARK-23879][HotFix] Fix Java lint ...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20991#discussion_r179669069 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java --- @@ -54,7 +54,7 @@ public static int

[GitHub] spark pull request #20994: [SPARK-21898][ML][FOLLOWUP] Fix Scala 2.12 build.

GitHub user ueshin opened a pull request: https://github.com/apache/spark/pull/20994 [SPARK-21898][ML][FOLLOWUP] Fix Scala 2.12 build. ## What changes were proposed in this pull request? This is a follow-up pr of #19108 which broke Scala 2.12 build. ``` [error

[GitHub] spark issue #20994: [SPARK-21898][ML][FOLLOWUP] Fix Scala 2.12 build.

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20994 cc @WeichenXu123 @MrBago @jkbradley --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #20991: [SPARK-10399][SPARK-23879][HotFix] Fix Java lint errors

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20991 Thanks! merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #20994: [SPARK-21898][ML][FOLLOWUP] Fix Scala 2.12 build.

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20994 @jkbradley Yes, I've confirmed that I was able to build with Scala 2.12 in my local environment. --- - To unsubscribe, e

[GitHub] spark issue #20995: [SPARK-23882][Core] UTF8StringSuite.writeToOutputStreamU...

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20995 Seems like this broke `lint-java`. ``` [ERROR] src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java:[28,8] (imports) UnusedImports: Unused import

[GitHub] spark issue #20994: [SPARK-21898][ML][FOLLOWUP] Fix Scala 2.12 build.

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20994 Thanks for reviewing! merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20904: [SPARK-23751][ML][PySpark] Kolmogorov-Smirnoff te...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20904#discussion_r181006772 --- Diff: mllib/src/main/scala/org/apache/spark/ml/stat/KolmogorovSmirnovTest.scala --- @@ -81,32 +81,37 @@ object KolmogorovSmirnovTest { * Java

[GitHub] spark pull request #21024: [SPARK-23917][SQL] Add array_max function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21024#discussion_r181085033 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,68 @@ case class

[GitHub] spark issue #21024: [SPARK-23917][SQL] Add array_max function

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21024 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #21024: [SPARK-23917][SQL] Add array_max function

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21024 LGTM pending Jenkins. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #21025: [SPARK-23918][SQL] Add array_min function

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21025 LGTM. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #21024: [SPARK-23917][SQL] Add array_max function

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21024 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #20938: [SPARK-23821][SQL] Collection function: flatten

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20938#discussion_r181342596 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +289,160 @@ case class

[GitHub] spark pull request #20938: [SPARK-23821][SQL] Collection function: flatten

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20938#discussion_r181345710 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +289,160 @@ case class

[GitHub] spark pull request #20938: [SPARK-23821][SQL] Collection function: flatten

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20938#discussion_r181347402 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +289,160 @@ case class

[GitHub] spark pull request #20938: [SPARK-23821][SQL] Collection function: flatten

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20938#discussion_r181333291 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +289,160 @@ case class

[GitHub] spark pull request #21011: [SPARK-23916][SQL] Add array_join function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21011#discussion_r181371786 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +288,173 @@ case class

[GitHub] spark pull request #21011: [SPARK-23916][SQL] Add array_join function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21011#discussion_r181371299 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +288,173 @@ case class

[GitHub] spark pull request #21011: [SPARK-23916][SQL] Add array_join function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21011#discussion_r181371352 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +288,173 @@ case class

[GitHub] spark pull request #21011: [SPARK-23916][SQL] Add array_join function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21011#discussion_r181371571 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +288,173 @@ case class

[GitHub] spark pull request #21011: [SPARK-23916][SQL] Add array_join function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21011#discussion_r181371816 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +288,173 @@ case class

[GitHub] spark pull request #21011: [SPARK-23916][SQL] Add array_join function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21011#discussion_r181363454 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +288,173 @@ case class

[GitHub] spark pull request #21011: [SPARK-23916][SQL] Add array_join function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21011#discussion_r181371114 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +288,173 @@ case class

[GitHub] spark pull request #21011: [SPARK-23916][SQL] Add array_join function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21011#discussion_r181380233 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +288,173 @@ case class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r181616266 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala --- @@ -105,4 +106,26 @@ class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r181613044 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,60 @@ case class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r181613270 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,60 @@ case class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r181615751 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,60 @@ case class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r181614388 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,61 @@ case class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r181614224 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,60 @@ case class

[GitHub] spark pull request #21053: [SPARK-23924][SQL] Add element_at function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21053#discussion_r181617303 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeExtractors.scala --- @@ -354,3 +336,37 @@ case class GetMapValue

[GitHub] spark pull request #21053: [SPARK-23924][SQL] Add element_at function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21053#discussion_r181619450 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,106 @@ case class

[GitHub] spark pull request #21053: [SPARK-23924][SQL] Add element_at function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21053#discussion_r181619426 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,106 @@ case class

[GitHub] spark pull request #21053: [SPARK-23924][SQL] Add element_at function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21053#discussion_r181618055 --- Diff: python/pyspark/sql/functions.py --- @@ -1846,6 +1846,27 @@ def array_contains(col, value): return Column(sc._jvm.functions.array_contains

[GitHub] spark pull request #21053: [SPARK-23924][SQL] Add element_at function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21053#discussion_r181623803 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,106 @@ case class

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r181639154 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +290,231 @@ case class

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r181640349 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +290,231 @@ case class

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r181638570 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +290,231 @@ case class

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r181643397 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +290,231 @@ case class

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r181641673 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +290,231 @@ case class

[GitHub] spark issue #21034: [SPARK-23926][SQL] Extending reverse function to support...

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21034 LGTM. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #21025: [SPARK-23918][SQL] Add array_min function

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21025 Thanks! merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #20938: [SPARK-23821][SQL] Collection function: flatten

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20938#discussion_r182024380 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -417,3 +419,179 @@ case class ArrayMax

[GitHub] spark pull request #20938: [SPARK-23821][SQL] Collection function: flatten

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20938#discussion_r182026581 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -417,3 +419,179 @@ case class ArrayMax

[GitHub] spark pull request #20938: [SPARK-23821][SQL] Collection function: flatten

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20938#discussion_r182018964 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -417,3 +419,179 @@ case class ArrayMax

[GitHub] spark pull request #20938: [SPARK-23821][SQL] Collection function: flatten

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20938#discussion_r182024316 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -417,3 +419,179 @@ case class ArrayMax

[GitHub] spark pull request #21094: [SPARK-24007][SQL] EqualNullSafe for FloatType an...

GitHub user ueshin opened a pull request: https://github.com/apache/spark/pull/21094 [SPARK-24007][SQL] EqualNullSafe for FloatType and DoubleType might generate a wrong result by codegen. ## What changes were proposed in this pull request? `EqualNullSafe` for `FloatType

[GitHub] spark issue #21094: [SPARK-24007][SQL] EqualNullSafe for FloatType and Doubl...

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21094 cc @gatorsmile @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r182297625 --- Diff: python/pyspark/sql/functions.py --- @@ -1846,6 +1846,23 @@ def array_contains(col, value): return Column(sc._jvm.functions.array_contains

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r182316985 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala --- @@ -18,6 +18,7 @@ package

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r182298375 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -353,3 +353,61 @@ case class ArrayMax

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r182297896 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -353,3 +353,61 @@ case class ArrayMax

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r182298195 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -353,3 +353,61 @@ case class ArrayMax

[GitHub] spark issue #21094: [SPARK-24007][SQL] EqualNullSafe for FloatType and Doubl...

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21094 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #21053: [SPARK-23924][SQL] Add element_at function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21053#discussion_r182323290 --- Diff: python/pyspark/sql/functions.py --- @@ -1846,6 +1846,28 @@ def array_contains(col, value): return Column(sc._jvm.functions.array_contains

[GitHub] spark pull request #21053: [SPARK-23924][SQL] Add element_at function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21053#discussion_r182326476 --- Diff: python/pyspark/sql/functions.py --- @@ -1846,6 +1846,28 @@ def array_contains(col, value): return Column(sc._jvm.functions.array_contains

[GitHub] spark pull request #21053: [SPARK-23924][SQL] Add element_at function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21053#discussion_r182327230 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -417,3 +417,106 @@ case class ArrayMax

[GitHub] spark pull request #21053: [SPARK-23924][SQL] Add element_at function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21053#discussion_r182325781 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -417,3 +417,106 @@ case class ArrayMax

[GitHub] spark pull request #21011: [SPARK-23916][SQL] Add array_join function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21011#discussion_r182333814 --- Diff: python/pyspark/sql/functions.py --- @@ -1846,6 +1846,27 @@ def array_contains(col, value): return Column(sc._jvm.functions.array_contains

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20938 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r182349064 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -353,3 +356,218 @@ case class ArrayMax

[GitHub] spark issue #20858: [SPARK-23736][SQL] Extending the concat function to supp...

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20858 LGTM except for nits. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r182350135 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -353,3 +356,218 @@ case class ArrayMax

[GitHub] spark pull request #21053: [SPARK-23924][SQL] Add element_at function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21053#discussion_r182362454 --- Diff: python/pyspark/sql/functions.py --- @@ -1846,6 +1846,28 @@ def array_contains(col, value): return Column(sc._jvm.functions.array_contains

[GitHub] spark issue #21034: [SPARK-23926][SQL] Extending reverse function to support...

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21034 Thanks! merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #21094: [SPARK-24007][SQL] EqualNullSafe for FloatType and Doubl...

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21094 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20288#discussion_r161969687 --- Diff: python/pyspark/sql/context.py --- @@ -147,7 +147,8 @@ def udf(self): :return: :class:`UDFRegistration

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20239 @BryanCutler Any comments on this? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

<    4   5   6   7   8   9   10   11   12   13   >