[GitHub] spark pull request: Localise hadoop configuration when submitting ...

2014-07-24 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1574#issuecomment-50024391 This is a good idea. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-2037]: yarn client mode doesn't support...

2014-07-24 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/1180#discussion_r15352693 --- Diff: yarn/common/src/main/scala/org/apache/spark/scheduler/cluster/YarnClientSchedulerBackend.scala --- @@ -115,7 +117,33 @@ private[spark] class

[GitHub] spark pull request: [SPARK-2037]: yarn client mode doesn't support...

2014-07-24 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/1180#discussion_r15352756 --- Diff: yarn/alpha/src/main/scala/org/apache/spark/deploy/yarn/ExecutorLauncher.scala --- @@ -282,15 +298,22 @@ class ExecutorLauncher(args

[GitHub] spark pull request: [SPARK-2037]: yarn client mode doesn't support...

2014-07-24 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1180#issuecomment-50044511 This situation exists in theory. [SparkContext.scala#L992](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/SparkContext.scala#L992) deal

[GitHub] spark pull request: [SPARK-2670] FetchFailedException should be th...

2014-07-26 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1578#issuecomment-50232324 Here also should throw an `FetchFailedException `? ```scala override def next(): (BlockId, Option[Iterator[Any]]) = { resultsGotten += 1 val

[GitHub] spark pull request: ConnectionManager throws out of "Could not fin...

2014-07-26 Thread witgo
GitHub user witgo opened a pull request: https://github.com/apache/spark/pull/1603 ConnectionManager throws out of "Could not find reference for received ack message xxx" exception. You can merge this pull request into a Git repository by running: $ git

[GitHub] spark pull request: Build should not run hive tests by default.

2014-07-26 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1565#issuecomment-50237538 @ScrapCodes I think that the solution is simple and effective, is a better. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: ConnectionManager throws out of "Could not fin...

2014-07-26 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1603#issuecomment-50239511 Throw an exception here cause `System.exit(ExecutorExitCode.UNCAUGHT_EXCEPTION)` is called. This is not necessary. --- If your project is set up for it, you can reply

[GitHub] spark pull request: Spark-2447 : Spark on HBase

2014-07-26 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/1608#discussion_r15437166 --- Diff: external/hbase/pom.xml --- @@ -0,0 +1,217 @@ +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchem

[GitHub] spark pull request: Spark-2447 : Spark on HBase

2014-07-26 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/1608#discussion_r15437173 --- Diff: external/hbase/pom.xml --- @@ -0,0 +1,217 @@ +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchem

[GitHub] spark pull request: Spark-2447 : Spark on HBase

2014-07-26 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/1608#discussion_r15437185 --- Diff: external/hbase/pom.xml --- @@ -0,0 +1,217 @@ +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchem

[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1

2014-07-27 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/940#issuecomment-50293501 @mengxr Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1

2014-07-27 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/940#issuecomment-50297230 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2532] WIP Consolidated shuffle fixes

2014-07-27 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/1609#discussion_r15446910 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockObjectWriter.scala --- @@ -107,68 +109,296 @@ private[spark] class DiskBlockObjectWriter

[GitHub] spark pull request: [SPARK-2532] WIP Consolidated shuffle fixes

2014-07-27 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/1609#discussion_r15446921 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockObjectWriter.scala --- @@ -176,10 +406,17 @@ private[spark] class DiskBlockObjectWriter

[GitHub] spark pull request: [SPARK-2532] WIP Consolidated shuffle fixes

2014-07-27 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/1609#discussion_r15447384 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockObjectWriter.scala --- @@ -107,68 +109,296 @@ private[spark] class DiskBlockObjectWriter

[GitHub] spark pull request: [SPARK-2532] WIP Consolidated shuffle fixes

2014-07-27 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/1609#discussion_r15447402 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockObjectWriter.scala --- @@ -107,68 +109,296 @@ private[spark] class DiskBlockObjectWriter

[GitHub] spark pull request: [SPARK-2532] WIP Consolidated shuffle fixes

2014-07-27 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/1609#discussion_r15447397 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockObjectWriter.scala --- @@ -107,68 +109,296 @@ private[spark] class DiskBlockObjectWriter

[GitHub] spark pull request: [SPARK-2532] WIP Consolidated shuffle fixes

2014-07-27 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/1609#discussion_r15447401 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockObjectWriter.scala --- @@ -107,68 +109,296 @@ private[spark] class DiskBlockObjectWriter

[GitHub] spark pull request: [SPARK-2532] WIP Consolidated shuffle fixes

2014-07-27 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/1609#discussion_r15447436 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockObjectWriter.scala --- @@ -107,68 +109,296 @@ private[spark] class DiskBlockObjectWriter

[GitHub] spark pull request: [SPARK-2532] WIP Consolidated shuffle fixes

2014-07-27 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/1609#discussion_r15447430 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockObjectWriter.scala --- @@ -107,68 +109,296 @@ private[spark] class DiskBlockObjectWriter

[GitHub] spark pull request: [SPARK-2532] WIP Consolidated shuffle fixes

2014-07-27 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/1609#discussion_r15447449 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockObjectWriter.scala --- @@ -107,68 +109,296 @@ private[spark] class DiskBlockObjectWriter

[GitHub] spark pull request: [SPARK-2532] WIP Consolidated shuffle fixes

2014-07-27 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/1609#discussion_r15447510 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -935,15 +941,22 @@ private[spark] object Utils extends Logging { * Currently

[GitHub] spark pull request: [SPARK-2532] WIP Consolidated shuffle fixes

2014-07-27 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/1609#discussion_r15447541 --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala --- @@ -353,26 +368,53 @@ class ExternalAppendOnlyMap[K, V, C

[GitHub] spark pull request: [SPARK-2532] WIP Consolidated shuffle fixes

2014-07-27 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/1609#discussion_r15447535 --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala --- @@ -353,26 +368,53 @@ class ExternalAppendOnlyMap[K, V, C

[GitHub] spark pull request: [WIP][SPARK-2677]BasicBlockFetchIterator#next ...

2014-07-28 Thread witgo
GitHub user witgo opened a pull request: https://github.com/apache/spark/pull/1619 [WIP][SPARK-2677]BasicBlockFetchIterator#next can wait forever You can merge this pull request into a Git repository by running: $ git pull https://github.com/witgo/spark SPARK-2677

[GitHub] spark pull request: [SPARK-2677] BasicBlockFetchIterator#next can ...

2014-07-28 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/1632#discussion_r15508224 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockFetcherIterator.scala --- @@ -117,31 +121,45 @@ object BlockFetcherIterator

[GitHub] spark pull request: [WIP][SPARK-2677]BasicBlockFetchIterator#next ...

2014-07-29 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1619#issuecomment-50456598 @sarutak I think add a heartbeat detection mechanism is a good solution --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [WIP][SPARK-2677]BasicBlockFetchIterator#next ...

2014-07-29 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1619#issuecomment-50458991 @sarutak [ConnectionManager.scala#L259](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/network/ConnectionManager.scala#L259) to deal

[GitHub] spark pull request: [SPARK-2544][MLLIB] Improve ALS algorithm reso...

2014-07-29 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/929#issuecomment-50492147 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2544][MLLIB] Improve ALS algorithm reso...

2014-07-29 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/929#issuecomment-50503214 @mengxr Done. Tomorrow, I will test in detail. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-2199] [mllib] topic modeling

2014-07-29 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/1269#discussion_r15560968 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/clustering/topicmodeling/topicmodels/RobustPLSASuite.scala --- @@ -0,0 +1,40 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-2544][MLLIB] Improve ALS algorithm reso...

2014-07-29 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/929#issuecomment-50573353 @mengxr The test pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-2544][MLLIB] Improve ALS algorithm reso...

2014-07-29 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/929#discussion_r15566577 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala --- @@ -255,6 +255,9 @@ class ALS private ( rank, lambda, alpha

[GitHub] spark pull request: [SPARK-2544][MLLIB] Improve ALS algorithm reso...

2014-07-29 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/929#discussion_r15566754 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala --- @@ -255,6 +255,9 @@ class ALS private ( rank, lambda, alpha

[GitHub] spark pull request: [SPARK-2544][MLLIB] Improve ALS algorithm reso...

2014-07-29 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/929#issuecomment-50574926 Ok, I will try it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-2098: All Spark processes should support...

2014-07-30 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1256#issuecomment-50586734 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-2532: Minimal shuffle consolidation fixe...

2014-07-30 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1678#issuecomment-50706018 We can also merge it to 1.0 branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: SPARK-2766: ScalaReflectionSuite throw an lleg...

2014-07-30 Thread witgo
GitHub user witgo opened a pull request: https://github.com/apache/spark/pull/1683 SPARK-2766: ScalaReflectionSuite throw an llegalArgumentException in JDK 6 You can merge this pull request into a Git repository by running: $ git pull https://github.com/witgo/spark SPARK

[GitHub] spark pull request: SPARK-2098: All Spark processes should support...

2014-07-30 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1256#issuecomment-50718557 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-2766: ScalaReflectionSuite throw an lleg...

2014-07-31 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1683#issuecomment-50841416 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-1470][SPARK-1842] Use the scala-logging...

2014-07-31 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1369#issuecomment-50851936 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1

2014-08-01 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/940#issuecomment-50855187 @mengxr done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1

2014-08-01 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/940#discussion_r15684437 --- Diff: mllib/pom.xml --- @@ -60,6 +60,14 @@ junit junit +

[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1

2014-08-01 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/940#issuecomment-50860276 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1

2014-08-01 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/940#issuecomment-50906124 How do we resolve this issue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-1470][SPARK-1842] Use the scala-logging...

2014-08-01 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1369#issuecomment-50910604 @srowen Thank you for your comments. And how to modify `GenerateMIMAIgnore` file to exclude a method? An example? --- If your project is set up for it, you can reply to

[GitHub] spark pull request: SPARK-2800: Exclude scalastyle-output.xml Apac...

2014-08-01 Thread witgo
GitHub user witgo opened a pull request: https://github.com/apache/spark/pull/1729 SPARK-2800: Exclude scalastyle-output.xml Apache RAT checks You can merge this pull request into a Git repository by running: $ git pull https://github.com/witgo/spark SPARK-2800 Alternatively

[GitHub] spark pull request: [SPARK-1470][SPARK-1842] Use the scala-logging...

2014-08-01 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1369#issuecomment-50951603 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-1470][SPARK-1842] Use the scala-logging...

2014-08-01 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1369#issuecomment-50953905 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [WIP][SPARK-1470]: Remove scalalogging-slf4j d...

2014-08-02 Thread witgo
GitHub user witgo reopened a pull request: https://github.com/apache/spark/pull/1208 [WIP][SPARK-1470]: Remove scalalogging-slf4j dependency You can merge this pull request into a Git repository by running: $ git pull https://github.com/witgo/spark SPARK-1470 Alternatively

[GitHub] spark pull request: [WIP][SPARK-1470]: Remove scalalogging-slf4j d...

2014-08-02 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1208#issuecomment-50956956 @pwendell @marmbrus How to test the performance impact of the PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-1470][SPARK-1842] Use the scala-logging...

2014-08-02 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1369#issuecomment-50957000 How to re-open this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-1470] remove scalalogging-slf4j depende...

2014-08-02 Thread witgo
GitHub user witgo reopened a pull request: https://github.com/apache/spark/pull/332 [SPARK-1470] remove scalalogging-slf4j dependency You can merge this pull request into a Git repository by running: $ git pull https://github.com/witgo/spark remove_scalalogging Alternatively

[GitHub] spark pull request: [SPARK-1470][SPARK-1842] Use the scala-logging...

2014-08-02 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/332#issuecomment-50961153 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-1470][SPARK-1842] Use the scala-logging...

2014-08-02 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1369#issuecomment-50965670 @pwendell #1208 fits your idea? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: SPARK-2804: Remove scalalogging-slf4j dependen...

2014-08-02 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1208#issuecomment-50979440 Cool thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-1470][SPARK-1842] Use the scala-logging...

2014-08-02 Thread witgo
Github user witgo closed the pull request at: https://github.com/apache/spark/pull/332 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: SPARK-2481: The environment variables SPARK_HI...

2014-08-02 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1341#issuecomment-50979611 @pwendell I think the PR can be merged into 1.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-1855] Local checkpointing

2015-07-17 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/7279#issuecomment-122477288 This is a very good performance for ML.I will test this feature on [cloudml/zen](https://github.com/cloudml/zen) --- If your project is set up for it, you can reply

[GitHub] spark pull request: [WIP] [SPARK-7292] Cheap checkpointing

2015-07-07 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/7279#issuecomment-119401465 This is very cool PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-9471] [ML] Multilayer Perceptron

2015-07-30 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/7621#issuecomment-126402467 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-2352] [ML] Add Artificial Neural Networ...

2015-07-23 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/7621#discussion_r35390543 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/ann/Layer.scala --- @@ -0,0 +1,856 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: [SPARK-2352] [ML] Add Artificial Neural Networ...

2015-07-24 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/7621#discussion_r35408460 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/ann/Layer.scala --- @@ -0,0 +1,856 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: [SPARK-2352] [ML] Add Artificial Neural Networ...

2015-07-24 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/7621#discussion_r35409451 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/ann/Layer.scala --- @@ -0,0 +1,856 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: [SPARK-2352] [ML] Add Artificial Neural Networ...

2015-07-24 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/7621#discussion_r35410425 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/ann/Layer.scala --- @@ -0,0 +1,856 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: [SPARK-2352] [ML] Add Artificial Neural Networ...

2015-07-24 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/7621#discussion_r35433813 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala --- @@ -0,0 +1,130 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-2352] [ML] Add Artificial Neural Networ...

2015-07-24 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/7621#discussion_r35435404 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/ann/Layer.scala --- @@ -0,0 +1,857 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: [SPARK-2352] [ML] Add Artificial Neural Networ...

2015-07-24 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/7621#discussion_r35436475 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/ann/Layer.scala --- @@ -0,0 +1,856 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: [SPARK-2352] [ML] Add Artificial Neural Networ...

2015-07-27 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/7621#discussion_r35607344 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala --- @@ -0,0 +1,130 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-8273]Driver hangs up when yarn shutdown...

2015-06-09 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/6717#issuecomment-110612334 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [MLLIB] [spark-2352] Implementation of an Arti...

2015-05-20 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1290#issuecomment-104111324 @ankurdave The `DBN` related code: https://github.com/witgo/spark/tree/ann-interface-gemm-dbn --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-7850][BUILD] Hive 0.12.0 profile in POM...

2015-05-25 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/6393#issuecomment-105154271 The code is useless ? https://github.com/apache/spark/tree/master/sql/hive --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: DAGScheduler should get map output statuses di...

2016-03-27 Thread witgo
GitHub user witgo opened a pull request: https://github.com/apache/spark/pull/11986 DAGScheduler should get map output statuses directly. ## What changes were proposed in this pull request? Add a new method to `MapOutputTracker` class ```scala def

[GitHub] spark pull request: [CORE][SPARK-14178]DAGScheduler should get map...

2016-03-27 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/11986#issuecomment-202179133 In actual use of MapStatus. The array stored in MapStatus is only removed or added.The elements in this array are not modified. Therefore, this array can be used outside

[GitHub] spark pull request: [CORE][SPARK-14178]DAGScheduler should get map...

2016-03-29 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/11986#issuecomment-202778045 retest please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-14667] Remove HashShuffleManager

2016-04-17 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/12423#issuecomment-211219477 I think the following should be deleted 1. [FileShuffleBlockResolver.scala](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/shuffle

[GitHub] spark pull request: [CORE][SPARK-14178]DAGScheduler should get map...

2016-03-30 Thread witgo
Github user witgo closed the pull request at: https://github.com/apache/spark/pull/11986 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [CORE][SPARK-14178]DAGScheduler should get map...

2016-03-30 Thread witgo
GitHub user witgo reopened a pull request: https://github.com/apache/spark/pull/11986 [CORE][SPARK-14178]DAGScheduler should get map output statuses directly. ## What changes were proposed in this pull request? Add a new method to `MapOutputTracker` class ```scala

[GitHub] spark pull request: [CORE][SPARK-14178]DAGScheduler should get map...

2016-03-30 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/11986#issuecomment-203695553 There are lots of map and reduce, MapStatus deserialization may take a few seconds --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [CORE][SPARK-14178]DAGScheduler should get map...

2016-04-02 Thread witgo
Github user witgo closed the pull request at: https://github.com/apache/spark/pull/11986 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-1239] Improve fetching of map output st...

2016-04-03 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/12113#discussion_r58324785 --- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala --- @@ -428,40 +503,93 @@ private[spark] class MapOutputTrackerMaster(conf: SparkConf

[GitHub] spark pull request: [SPARK-1239] Improve fetching of map output st...

2016-04-03 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/12113#discussion_r58325719 --- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala --- @@ -296,10 +290,89 @@ private[spark] class MapOutputTrackerMaster(conf: SparkConf

[GitHub] spark pull request: [SPARK-1239] Improve fetching of map output st...

2016-04-05 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/12113#discussion_r58502169 --- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala --- @@ -296,10 +290,89 @@ private[spark] class MapOutputTrackerMaster(conf: SparkConf

[GitHub] spark pull request: [SPARK-1239] Improve fetching of map output st...

2016-04-05 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/12113#discussion_r58503061 --- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala --- @@ -428,40 +503,93 @@ private[spark] class MapOutputTrackerMaster(conf: SparkConf

[GitHub] spark pull request: [SPARK-1239] Improve fetching of map output st...

2016-04-05 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/12113#discussion_r58637905 --- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala --- @@ -428,40 +503,93 @@ private[spark] class MapOutputTrackerMaster(conf: SparkConf

[GitHub] spark pull request: [SPARK-1239] Improve fetching of map output st...

2016-04-05 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/12113#discussion_r58641966 --- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala --- @@ -296,10 +290,89 @@ private[spark] class MapOutputTrackerMaster(conf: SparkConf

[GitHub] spark pull request: [SPARK-1239] Improve fetching of map output st...

2016-04-05 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/12113#discussion_r58643596 --- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala --- @@ -492,16 +624,51 @@ private[spark] object MapOutputTracker extends Logging

[GitHub] spark pull request: [SPARK-1239] Improve fetching of map output st...

2016-04-06 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/12113#discussion_r58711271 --- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala --- @@ -492,16 +624,51 @@ private[spark] object MapOutputTracker extends Logging

[GitHub] spark pull request #14647: [WIP][Test only][SPARK-6235]Address various 2G li...

2016-08-15 Thread witgo
GitHub user witgo opened a pull request: https://github.com/apache/spark/pull/14647 [WIP][Test only][SPARK-6235]Address various 2G limits ## What changes were proposed in this pull request? The main changes. 1. Replace DiskStore method `def getBytes (blockId: BlockId

[GitHub] spark issue #14647: [WIP][Test only][DEMO][SPARK-6235]Address various 2G lim...

2016-08-15 Thread witgo
Github user witgo commented on the issue: https://github.com/apache/spark/pull/14647 @hvanhovell I will submit some small PRs and provide a more high level description of them. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request #14658: [WIP][SPARK-5928] Remote Shuffle Blocks cannot be...

2016-08-15 Thread witgo
GitHub user witgo opened a pull request: https://github.com/apache/spark/pull/14658 [WIP][SPARK-5928] Remote Shuffle Blocks cannot be more than 2 GB ## What changes were proposed in this pull request? Add class `ChunkFetchInputStream` and it have the following effects

[GitHub] spark pull request #14662: [WIP][SPARK-17082][CORE]Replace ByteBuffer with C...

2016-08-16 Thread witgo
GitHub user witgo opened a pull request: https://github.com/apache/spark/pull/14662 [WIP][SPARK-17082][CORE]Replace ByteBuffer with ChunkedByteBuffer ## What changes were proposed in this pull request? Replace `ByteBuffer` with `ChunkedByteBuffer

[GitHub] spark pull request #14664: Spark 6236 caching blocks 2G

2016-08-16 Thread witgo
GitHub user witgo opened a pull request: https://github.com/apache/spark/pull/14664 Spark 6236 caching blocks 2G ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How was this patch tested? (Please

[GitHub] spark issue #14647: [WIP][Test only][DEMO][SPARK-6235]Address various 2G lim...

2016-08-16 Thread witgo
Github user witgo commented on the issue: https://github.com/apache/spark/pull/14647 @hvanhovell #14658 , #14662 and #14664 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14751: [WIP][SPARK-17184][[CORE]]Replace ByteBuf with In...

2016-08-22 Thread witgo
GitHub user witgo opened a pull request: https://github.com/apache/spark/pull/14751 [WIP][SPARK-17184][[CORE]]Replace ByteBuf with InputStream ## What changes were proposed in this pull request? The size of ByteBuf can not be greater than 2G, should be replaced by

[GitHub] spark pull request #17480: [SPARK-20079][Core][yarn] Re registration of AM h...

2017-04-07 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/17480#discussion_r110361779 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -249,7 +249,14 @@ private[spark] class ExecutorAllocationManager

[GitHub] spark issue #17567: [SPARK-19991][CORE][YARN] FileSegmentManagedBuffer perfo...

2017-04-07 Thread witgo
Github user witgo commented on the issue: https://github.com/apache/spark/pull/17567 LGTM. Are there any performance test reports? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17567: [SPARK-19991][CORE][YARN] FileSegmentManagedBuffer perfo...

2017-04-08 Thread witgo
Github user witgo commented on the issue: https://github.com/apache/spark/pull/17567 OK, I see. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #17480: [SPARK-20079][Core][yarn] Re registration of AM h...

2017-04-10 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/17480#discussion_r110796578 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -249,7 +249,14 @@ private[spark] class ExecutorAllocationManager

<    4   5   6   7   8   9   10   >