gengliangwang commented on PR #46286:
URL: https://github.com/apache/spark/pull/46286#issuecomment-205469
@dongjoon-hyun Thanks a lot. I will create a backport for 3.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dongjoon-hyun commented on PR #46286:
URL: https://github.com/apache/spark/pull/46286#issuecomment-2088873791
Let me revert `branch-3.5` commit first to recover the CI. Could you make a
PR to branch-3.5, @gengliangwang ?
--
This is an automated message from the Apache Git Service.
To
dongjoon-hyun commented on PR #46286:
URL: https://github.com/apache/spark/pull/46286#issuecomment-2088871262
Hi, @gengliangwang .
It's a little weird because
- This PR doesn't contain `sql/core/src/test/resources/log4j2.properties`.
- master commit also does.
- branch-3.5
gengliangwang commented on PR #46289:
URL: https://github.com/apache/spark/pull/46289#issuecomment-2083898461
This one is to backport https://github.com/apache/spark/pull/46286 to branch
3.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please
gengliangwang opened a new pull request, #46289:
URL: https://github.com/apache/spark/pull/46289
### What changes were proposed in this pull request?
Currently, the following query will throw DIVIDE_BY_ZERO error instead of
returning null
```
SELECT
gengliangwang closed pull request #46286: [SPARK-48016][SQL] Fix a bug in
try_divide function when with decimals
URL: https://github.com/apache/spark/pull/46286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
gengliangwang commented on PR #46286:
URL: https://github.com/apache/spark/pull/46286#issuecomment-2083870320
@HyukjinKwon @dongjoon-hyun @yaooqinn Thanks for the review. Merging to
master/branch-3.5/branch-3.4
--
This is an automated message from the Apache Git Service.
To respond to
dongjoon-hyun commented on PR #46286:
URL: https://github.com/apache/spark/pull/46286#issuecomment-2083850831
BTW, thank you for adding new test coverage, @gengliangwang .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dongjoon-hyun commented on PR #46286:
URL: https://github.com/apache/spark/pull/46286#issuecomment-2083664898
cc @yaooqinn too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
gengliangwang commented on PR #46286:
URL: https://github.com/apache/spark/pull/46286#issuecomment-2083474220
There is another approach at https://github.com/apache/spark/pull/46251,
which fails a test case in the `CanonicalizeSuite`.
Using `withNewChildren` is better here.
--
This
gengliangwang opened a new pull request, #46286:
URL: https://github.com/apache/spark/pull/46286
### What changes were proposed in this pull request?
Currently, the following query will throw DIVIDE_BY_ZERO error instead of
returning null
```
SELECT
11 matches
Mail list logo
