gengliangwang closed pull request #46312: [SPARK-48067][SQL] Fix variant
default columns
URL: https://github.com/apache/spark/pull/46312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
gengliangwang commented on PR #46312:
URL: https://github.com/apache/spark/pull/46312#issuecomment-2091365435
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gengliangwang commented on code in PR #46312:
URL: https://github.com/apache/spark/pull/46312#discussion_r1586864884
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala:
##
@@ -549,6 +549,7 @@ case class Literal (value: Any, dataType:
gengliangwang commented on PR #46312:
URL: https://github.com/apache/spark/pull/46312#issuecomment-2089162196
Sync with @richardc-db offline. I suggest changing the `.sql` method of
variant expressions instead.
--
This is an automated message from the Apache Git Service.
To respond to
richardc-db commented on code in PR #46312:
URL: https://github.com/apache/spark/pull/46312#discussion_r1586835635
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala:
##
@@ -84,9 +84,16 @@ object ResolveDefaultColumns extends
gengliangwang commented on code in PR #46312:
URL: https://github.com/apache/spark/pull/46312#discussion_r1586809054
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala:
##
@@ -84,9 +84,16 @@ object ResolveDefaultColumns extends
richardc-db commented on code in PR #46312:
URL: https://github.com/apache/spark/pull/46312#discussion_r1586798259
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala:
##
@@ -84,9 +84,16 @@ object ResolveDefaultColumns extends
richardc-db commented on code in PR #46312:
URL: https://github.com/apache/spark/pull/46312#discussion_r1586798259
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala:
##
@@ -84,9 +84,16 @@ object ResolveDefaultColumns extends
richardc-db commented on code in PR #46312:
URL: https://github.com/apache/spark/pull/46312#discussion_r1586798259
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala:
##
@@ -84,9 +84,16 @@ object ResolveDefaultColumns extends
richardc-db commented on code in PR #46312:
URL: https://github.com/apache/spark/pull/46312#discussion_r1586798259
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala:
##
@@ -84,9 +84,16 @@ object ResolveDefaultColumns extends
gengliangwang commented on code in PR #46312:
URL: https://github.com/apache/spark/pull/46312#discussion_r1586788998
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala:
##
@@ -84,9 +84,16 @@ object ResolveDefaultColumns extends
richardc-db commented on code in PR #46312:
URL: https://github.com/apache/spark/pull/46312#discussion_r1586783457
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala:
##
@@ -84,9 +84,16 @@ object ResolveDefaultColumns extends
richardc-db commented on code in PR #46312:
URL: https://github.com/apache/spark/pull/46312#discussion_r1586783457
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala:
##
@@ -84,9 +84,16 @@ object ResolveDefaultColumns extends
richardc-db commented on code in PR #46312:
URL: https://github.com/apache/spark/pull/46312#discussion_r1586782740
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala:
##
@@ -84,9 +84,16 @@ object ResolveDefaultColumns extends
gengliangwang commented on code in PR #46312:
URL: https://github.com/apache/spark/pull/46312#discussion_r1586770080
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala:
##
@@ -84,9 +84,16 @@ object ResolveDefaultColumns extends
richardc-db commented on code in PR #46312:
URL: https://github.com/apache/spark/pull/46312#discussion_r1586697875
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala:
##
@@ -84,9 +84,16 @@ object ResolveDefaultColumns extends
richardc-db commented on code in PR #46312:
URL: https://github.com/apache/spark/pull/46312#discussion_r1586697875
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala:
##
@@ -84,9 +84,16 @@ object ResolveDefaultColumns extends
richardc-db commented on code in PR #46312:
URL: https://github.com/apache/spark/pull/46312#discussion_r1586697875
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala:
##
@@ -84,9 +84,16 @@ object ResolveDefaultColumns extends
dtenedor commented on code in PR #46312:
URL: https://github.com/apache/spark/pull/46312#discussion_r1586664236
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala:
##
@@ -84,9 +84,16 @@ object ResolveDefaultColumns extends
dtenedor commented on PR #46312:
URL: https://github.com/apache/spark/pull/46312#issuecomment-2088934443
```
previously we could not set a variant default column like
create table t(
v6 variant default parse_json('{\"k\": \"v\"}')
)
```
@richardc-db this
dtenedor commented on code in PR #46312:
URL: https://github.com/apache/spark/pull/46312#discussion_r1586662927
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala:
##
@@ -84,9 +84,16 @@ object ResolveDefaultColumns extends
richardc-db opened a new pull request, #46312:
URL: https://github.com/apache/spark/pull/46312
### What changes were proposed in this pull request?
lazily evaluates variant default column expressions. This is because Spark
currently evaluates the default column expression and
22 matches
Mail list logo
