Re: [PR] [SPARK-48068][PYTHON] `mypy` should have `--python-executable` parameter [spark]

2024-05-01 Thread via GitHub
dongjoon-hyun commented on PR #46314: URL: https://github.com/apache/spark/pull/46314#issuecomment-2088982611 Thank you, @viirya ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-48068][PYTHON] `mypy` should have `--python-executable` parameter [spark]

2024-05-01 Thread via GitHub
viirya commented on PR #46314: URL: https://github.com/apache/spark/pull/46314#issuecomment-204973 Looks good to me. Thanks @dongjoon-hyun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [SPARK-48068][PYTHON] `mypy` should have `--python-executable` parameter [spark]

2024-05-01 Thread via GitHub
dongjoon-hyun closed pull request #46314: [SPARK-48068][PYTHON] `mypy` should have `--python-executable` parameter URL: https://github.com/apache/spark/pull/46314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [SPARK-48068][PYTHON] `mypy` should have `--python-executable` parameter [spark]

2024-05-01 Thread via GitHub
dongjoon-hyun commented on PR #46314: URL: https://github.com/apache/spark/pull/46314#issuecomment-2088824377 Thank you, @huaxingao ! Merged to master/3.5/3.4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [SPARK-48068][PYTHON] `mypy` should have `--python-executable` parameter [spark]

2024-05-01 Thread via GitHub
dongjoon-hyun commented on PR #46314: URL: https://github.com/apache/spark/pull/46314#issuecomment-2088820775 Could you review this PR, @huaxingao ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [SPARK-48068][PYTHON] `mypy` should have `--python-executable` parameter [spark]

2024-05-01 Thread via GitHub
dongjoon-hyun commented on PR #46314: URL: https://github.com/apache/spark/pull/46314#issuecomment-2088817665 All linters passed. ![Screenshot 2024-05-01 at 10 35 56](https://github.com/apache/spark/assets/9700541/c62cc30e-7f3a-4e4e-a871-c37fa11ab051) Could you review this PR,

Re: [PR] [SPARK-48068][PYTHON] `mypy` should have `--python-executable` parameter [spark]

2024-05-01 Thread via GitHub
dongjoon-hyun commented on PR #46314: URL: https://github.com/apache/spark/pull/46314#issuecomment-2088785354 For the record, I refocused this PR to `--python-executable` issue only in this PR. Python linter passed without any issues. ![Screenshot 2024-05-01 at 10 11