Re: [PR] [SPARK-48074][Core] Improve the readability of JSON loggings [spark]

2024-05-01 Thread via GitHub
panbingkun commented on PR #46322: URL: https://github.com/apache/spark/pull/46322#issuecomment-2089299522 +1, LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [SPARK-48074][Core] Improve the readability of JSON loggings [spark]

2024-05-01 Thread via GitHub
dongjoon-hyun closed pull request #46322: [SPARK-48074][Core] Improve the readability of JSON loggings URL: https://github.com/apache/spark/pull/46322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [SPARK-48074][Core] Improve the readability of JSON loggings [spark]

2024-05-01 Thread via GitHub
dongjoon-hyun commented on PR #46322: URL: https://github.com/apache/spark/pull/46322#issuecomment-2089202215 Merged to master for Apache spark 4.0.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [SPARK-48074][Core] Improve the readability of JSON loggings [spark]

2024-05-01 Thread via GitHub
gengliangwang commented on code in PR #46322: URL: https://github.com/apache/spark/pull/46322#discussion_r1586740612 ## common/utils/src/test/scala/org/apache/spark/util/StructuredLoggingSuite.scala: ## @@ -192,8 +192,8 @@ class StructuredLoggingSuite extends LoggingSuiteBase {

Re: [PR] [SPARK-48074][Core] Improve the readability of JSON loggings [spark]

2024-05-01 Thread via GitHub
gengliangwang commented on code in PR #46322: URL: https://github.com/apache/spark/pull/46322#discussion_r1586724715 ## common/utils/src/test/scala/org/apache/spark/util/StructuredLoggingSuite.scala: ## @@ -192,8 +192,8 @@ class StructuredLoggingSuite extends LoggingSuiteBase {

Re: [PR] [SPARK-48074][Core] Improve the readability of JSON loggings [spark]

2024-05-01 Thread via GitHub
dongjoon-hyun commented on code in PR #46322: URL: https://github.com/apache/spark/pull/46322#discussion_r1586720608 ## common/utils/src/test/scala/org/apache/spark/util/StructuredLoggingSuite.scala: ## @@ -192,8 +192,8 @@ class StructuredLoggingSuite extends LoggingSuiteBase {

Re: [PR] [SPARK-48074][Core] Improve the readability of JSON loggings [spark]

2024-05-01 Thread via GitHub
gengliangwang commented on PR #46322: URL: https://github.com/apache/spark/pull/46322#issuecomment-2088917364 cc @panbingkun @dtenedor as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] [SPARK-48074][Core] Improve the readability of JSON loggings [spark]

2024-05-01 Thread via GitHub
gengliangwang opened a new pull request, #46322: URL: https://github.com/apache/spark/pull/46322 ### What changes were proposed in this pull request? Improve the readability of JSON loggings via: 1. Use UTC in the timestamp so that the timestamp field value is more